While compiling Swift 5.1.2 on Linux I have found the following issues and would like some clarification on whether this is a problem and if a bug should be filed.
The swift-5.1-branch which Swift 5.1.2 should be built from is still versioned at 5.1.1
The tag swift-5.1.2-RELEASE does not appear to be for any current branch on Github.
I’m not sure what is going on here but I appreciate you surfacing this issue. A bunch of folks are out of the office this week (including me and Mishal) due to a Thanksgiving (in the USA) shutdown at Apple. We will take a look at this next week when everyone is back in the office.
$ ./swift-5.1.2-RELEASE-ubuntu14.04/usr/bin/swift --version
Swift version 5.1.2 (swift-5.1.2-RELEASE)
Target: x86_64-unknown-linux-gnu
$ ./swift-5.1.2-RELEASE-ubuntu16.04/usr/bin/swift --version
Swift version 5.1.2 (swift-5.1.2-RELEASE)
Target: x86_64-unknown-linux-gnu
$ ./swift-5.1.2-RELEASE-ubuntu18.04/usr/bin/swift --version
Swift version 5.1.2 (swift-5.1.2-RELEASE)
Target: x86_64-unknown-linux-gnu
$ /Library/Developer/Toolchains/swift-5.1.2-RELEASE.xctoolchain/usr/bin/swift --version
Apple Swift version 5.1.2 (swift-5.1.2-RELEASE)
Target: x86_64-apple-darwin18.6.0
@mishal_shah I am sorry but this doesn't make any sense.
Where is the commit that made these changes?
The swift-5.1-branch is still versioned at 5.1.1.
Where did this branch come from? It is not from the swift-5.1-branch or the master .
To resolve the version issue for Swift 5.1.2, we made the fix on top of swift-5.1.2-RELEASE tag and created new toolchains.
Also the swift version string is still being hard coded in the lib/Basic/Version.cpp file.
We hard code the tag info in lib/Basic/Version.cpp to display (swift-5.1.2-RELEASE). This makes it easier for us to know which tag the compiler was built from. However, we don't hard code this in the master or release branch.