GitHub project links on the “Related Projects” page

Clicking on the GitHub project link in one of the top boxes at https://forums.swift.org/c/related-projects does not open the GitHub page, but the forums page. For example, if I click on the GitHub link in the box

           SwiftNIO

https://github.com/apple/swift-nio

then https://forums.swift.org/c/related-projects/swiftnio opens, even if hovering over the link displays

open “https://github.com/apple/swift-nio” in a new tab.

This happens with

  • Safari on macOS 10.13
  • Mobile Safari on iOS 11.3
  • Firefox on Windows 10

“Open Link in New Tab" and “Open Link in New Windows” from the context menu do work correctly though, and open https://github.com/apple/swift-nio.

This is the HTML source code for one of the boxes (reformatted to show the structure better):

<div class="category-box-inner">
  <a href="/c/related-projects/swiftnio">
    <div class="category-box-heading">
      <h3>
        SwiftNIO
      </h3>
    </div>
    <div class="description">
      <div id="ember1264" class="overflow ember-view">
        <div style="margin: 0px; padding: 0px; border: 0px;">
           <a href="https://github.com/apple/swift-nio" class="onebox" target="_blank">https://github.com/apple/swift-nio</a>
        </div>
      </div>
    </div>
  </a>
</div>

I am not an HTML expert, but that looks like a violation of 12.2.2 Nested links are illegal to me.

1 Like

@sam.saffron any idea?

Yes, this was a bug I just fixed and deployed the fix, @Martin is it looking better now?

2 Likes

Works fine now, thanks!

1 Like