viewWill/DidAppear and viewWill/DidDisappear should have "animated" argument label (Victor Gao)


(Victor Gao) #1

Hi all,

In the new iOS SDK with Swift 3, I noticed that the viewWillAppear, viewDidAppear, viewWillDisappear and viewDidDisappear hide the animated argument label. Which means when the SDK calls those methods it will look like this:

viewWillAppear(true)
viewDidAppear(true)
//and others

Obviously this runs counter to the Swift API Design Guidelines, thus results in unclear and confusing code. Instead, these methods should have the “animated" argument label so it would be clear what the boolean flag means.

Cheers,
Victor Gao