Hi @mishal_shah,
I have a few feedback points about the rebranch.
First and foremost, I hoped that the next rebranch would fix the apple/main
branch of llvm-project
but that doesn't seem to be happening. Other than myself, it seems like nobody is testing building Swift's next
branch against apple/main
as opposed to the recommended/supported swift/next
. This is of course, understandable. That being said, building/testing Swift without the REPL used to work until early December and it arguably should still work. Do you mind if I cherry-pick the two(?) LLVM fixes that should be on the apple/main
branch from swift/next
?
Also, the rebranch of clang has one test that is failing on my Fedora 33 box:
FAIL: Clang :: CodeGenObjC/availability-check.m (5609 of 27365)
******************** TEST 'Clang :: CodeGenObjC/availability-check.m' FAILED ********************
Script:
--
: 'RUN: at line 1'; /home/dave/b/n/t/bin/clang -cc1 -internal-isystem /home/dave/b/n/t/lib/clang/12.0.0/include -nostdsysteminc -triple x86_64-apple-macosx10.11 -emit-llvm -o - /home/dave/ro_s/n/llvm-project/clang/test/CodeGenObjC/availability-check.m | /home/dave/b/n/t/bin/FileCheck /home/dave/ro_s/n/llvm-project/clang/test/CodeGenObjC/availability-check.m
--
Exit Code: 1
Command Output (stderr):
--
/home/dave/ro_s/n/llvm-project/clang/test/CodeGenObjC/availability-check.m:30:12: error: CHECK: expected string not found in input
// CHECK: call i32 @__isOSVersionAtLeast(i32 10, i32 16, i32 0)
^
<stdin>:41:12: note: scanning from here
br i1 true, label %if.then7, label %if.end8
^
<stdin>:47:7: note: possible intended match here
%6 = call i32 @__isPlatformVersionAtLeast(i32 1, i32 10, i32 16, i32 0) #1
^
Input file: <stdin>
Check file: /home/dave/ro_s/n/llvm-project/clang/test/CodeGenObjC/availability-check.m
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
36:
37: if.then5: ; preds = %if.end4
38: br label %if.end6
39:
40: if.end6: ; preds = %if.then5, %if.end4
41: br i1 true, label %if.then7, label %if.end8
check:30'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
42:
check:30'0 ~
43: if.then7: ; preds = %if.end6
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
44: br label %if.end8
check:30'0 ~~~~~~~~~~~~~~~~~~
45:
check:30'0 ~
46: if.end8: ; preds = %if.then7, %if.end6
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
47: %6 = call i32 @__isPlatformVersionAtLeast(i32 1, i32 10, i32 16, i32 0) #1
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:30'1 ? possible intended match
48: %7 = icmp ne i32 %6, 0
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~
49: br i1 %7, label %if.then9, label %if.end10
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
50:
check:30'0 ~
51: if.then9: ; preds = %if.end8
check:30'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
52: br label %if.end10
check:30'0 ~~~~~~~~~~~~~~~~~~~
.
.
.
>>>>>>
--
********************
Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
********************
Failed Tests (1):
Clang :: CodeGenObjC/availability-check.m
Dave