Unexpected swapAt free/malloc overhead

I have a program that performs many swapAt(::) calls on an
Array, where Memo is a class I define. In principle, it seems
that when swapAt returns, the Memos that change place should never have
a different number of references than when swapAt began. I had hoped
that the compiler would infer the constancy of the reference counts and
emit no retains or releases. However, my performance profile shows
swapAt calling retain and release, malloc and free.

I have a couple of questions about this:

Can I give a hint in my source code that will help the compiler to avoid
needless retains/releases in swapAt?

I am building my project with swift run -c release Records .... It is
my understanding that -c release will enable optimization. (I have
also tried -Xswiftc -O---no difference.) Can I use a higher level of
optimization that will eliminate unnecessary retains and releases?

Dave

FWIW, it should be using this one–https://github.com/apple/swift/blob/53bdffd120c41fa0a9810612d4df3ac6310fa911/stdlib/public/core/MutableCollection.swift#L262. I don't think array rolls its own implementation.

I’m afraid this is a known limitation of swapAt. With that said I can’t find a bugs.swift.org covering this, so you should file it, but I definitely know that I know this problem and that the Swift performance team know about it.

1 Like

You may be able to avoid these by dropping down to UnsafeMutableBufferPointer.

You shouldn’t have to, of course, and I hope you file a bug report, but it may help you work-around the issue for now.

Thanks for the info. I will file a bug.

Should I expect similar code to be generated for a value type as for
a reference type? I ask because I have found a way to use a value
type instead of a reference type as my Array's Element, however, the
unexpected retain/release and malloc/free still appear in my profile.

Dave

What does the value type contain? Some value types are class-backed, which means they still require retains/releases. This applies to any standard library type that is variable-size, e.g. String, Array, Dictionary, Set.

The value type contains value types.

Last week I stepped through some of the assembly for swapAt and for
the subscript "get", and it looks like the compiler may have emitted
code that is applicable both to value types and to reference types.
Is that something the compiler will do? Can a value type have no-op
retain/release methods?

Details:

The value type is Proxy. Proxy and its dependencies:

struct Proxy : Comparable {
let idx: Int
let key: T.Key
static func <(_ l: Self, _ r: Self) -> Bool {
return l.key < r.key
}
static func ==(_ l: Self, _ r: Self) -> Bool {
return l.key == r.key
}
}

public protocol KeyComparable {
associatedtype Key : Comparable
var key : Key { get }
}

extension Memo : KeyComparable {
struct Key : Comparable {
let position: Position
let priority: Cost
static func <(_ l: Key, _ r: Key) -> Bool {
if l.priority == r.priority {
return l.position.l < r.position.l
}
return l.priority < r.priority
}
static func ==(_ l: Key, _ r: Key) -> Bool {
return l.priority == r.priority &&
l.position.l == r.position.l
}
}
final var key: Key {
return Key(position: position, priority: priority)
}
}

public typealias Cost = Int

struct Position {
let l, r: Int
init(_ l: Int, _ r: Int) {
self.l = l
self.r = r
}
init(_ p: (l: Int, r: Int)) {
self.l = p.l
self.r = p.r
}
static func +(_ p: Position, _ q: (Int, Int)) -> Position {
return Position(p.l + q.0, p.r + q.1)
}
}

BTW, Memo is a class. Maybe I am missing something, but I don't
think any references to a Memo should appear in Proxy.

Dave

Is Proxy generic? Your code suggests it should be (there appears to be a generic type parameter T), but it doesn’t seem to actually be. I guess Memo is generic?

Is the swapAt code in the same module as the definition of these types?

Is Proxy generic? Your code suggests it should be (there appears to be a generic type parameter T), but it doesn’t seem to actually be. I guess Memo is generic?

Proxy is generic: the key property has type T.Key. Memo is not generic.

Is the swapAt code in the same module as the definition of these types?

Memo is in a different module than the swapAt code.

As an experiment, I put most of the code into the same module. That
yields a >4x improvement on my main test case. Very good.

Maybe inter-modular optimization is not one of SPM's strong suits? Or
is there some option flag I can use that makes it try harder?

Dave

Today Swift basically does no cross module optimisation. There are some ways to influence this, and some flags are coming to SwiftPM to do more, but they are limited in scope for now. This is why you still saw retains/releases: the compiler emitted unspecialised code, and that unspecialised code needs to handle arbitrary possibilities.

You can arrange for the compiler to specialise the swapAt code using @inlinable, or pass the -cross-module-optimisation flag which may help (it only enables optimisation in limited scenarios).

1 Like

In general, whenever I have to try and see if some performance critical piece of Swift code can be optimized, I'll find that the profile is dominated by ARC-related stuff that the optimizer hasn't been able to eliminate. Getting rid of it, by rewriting the code in various non-pretty ways, often makes the code run tens or even hundreds of times faster, which makes you wonder:

  • What % of an average app's energy consumption is due to needless retain/release/free/malloc?

  • How much energy (every day around the world) is spent on this?

(These questions are of course equally or more relevant when replacing "ARC-related stuff" with "not completely/ideally optimized code in general resulting from any programming language", but anyway.)

Terms of Service

Privacy Policy

Cookie Policy