[Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #389

jrose · 2017-10-02T22:48:37.000Z

Anton just reupdated AsyncNinja, but it looks we have a new problem there:

/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27: error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

···

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]

Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/389/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min

Changes

Commit 001b09747a153763b30ef8a02254c7a0419c6292 by pyaskevich:
[ConstraintSolver] Prioritize certain type variables while looking for

edit: test/Constraints/generics.swift
edit: lib/Sema/CSSimplify.cpp
edit: lib/Sema/CSBindings.cpp
edit: lib/Sema/ConstraintSystem.h

Commit 6fe4ff8be7ab142ba7427c665b955770fc6905ba by mnvrth:
[CMake] Fix status message when not building stdlib/runtime

edit: CMakeLists.txt

Commit 5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7 by mnvrth:
[CMake] Improve wording of stdlib/overlay/runtime build status

edit: CMakeLists.txt

Commit f2ef42baed96e16086481537cc7dc87bbd2368b0 by github:
[migrator] When renaming a function decl, we should use underscore to

edit: lib/Migrator/APIDiffMigratorPass.cpp
edit: test/Migrator/Inputs/Cities.swift
edit: test/Migrator/rename-func-decl.swift
edit: test/Migrator/rename-func-decl.swift.expected
edit: test/Migrator/Inputs/API.json

Commit c47287199bce9b4d2c9ae0dc308dc328461ce9f6 by arthur:
Updated Guitar support for Swift 4.0

edit: projects.json

Commit 1a82e4d490d4607da81f58327eb0f900f3056c08 by antonvmironov:
AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed

edit: projects.json

Commit ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b by arthur:
Re-added 3.1 compatibility

edit: projects.json

Commit 632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a by arthur:
Removed comma

edit: projects.json

Commit 87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494 by antonvmironov:
UnXFAIL AsyncNinja

edit: projects.json

xedin · 2017-10-02T23:36:42.000Z

Sorry it might be my commit actually, I am AFK for a bit, will revert once I am back.

···

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev <swift-dev@swift.org> wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem there:

/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27: error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]

Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/389/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min

Changes

Commit 001b09747a153763b30ef8a02254c7a0419c6292 by pyaskevich:
[ConstraintSolver] Prioritize certain type variables while looking for

edit: test/Constraints/generics.swift
edit: lib/Sema/CSSimplify.cpp
edit: lib/Sema/CSBindings.cpp
edit: lib/Sema/ConstraintSystem.h

Commit 6fe4ff8be7ab142ba7427c665b955770fc6905ba by mnvrth:
[CMake] Fix status message when not building stdlib/runtime

edit: CMakeLists.txt

Commit 5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7 by mnvrth:
[CMake] Improve wording of stdlib/overlay/runtime build status

edit: CMakeLists.txt

Commit f2ef42baed96e16086481537cc7dc87bbd2368b0 by github:
[migrator] When renaming a function decl, we should use underscore to

edit: lib/Migrator/APIDiffMigratorPass.cpp
edit: test/Migrator/Inputs/Cities.swift
edit: test/Migrator/rename-func-decl.swift
edit: test/Migrator/rename-func-decl.swift.expected
edit: test/Migrator/Inputs/API.json

Commit c47287199bce9b4d2c9ae0dc308dc328461ce9f6 by arthur:
Updated Guitar support for Swift 4.0

edit: projects.json

Commit 1a82e4d490d4607da81f58327eb0f900f3056c08 by antonvmironov:
AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed

edit: projects.json

Commit ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b by arthur:
Re-added 3.1 compatibility

edit: projects.json

Commit 632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a by arthur:
Removed comma

edit: projects.json

Commit 87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494 by antonvmironov:
UnXFAIL AsyncNinja

edit: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Pavel_Yaskevich · 2017-10-03T01:44:00.000Z

Merged revert into master

github.com/apple/swift

Merge pull request #12235 from xedin/fix-subtype-revert

committed 01:43AM - 03 Oct 17 UTC

xedin

+7 -62

Revert "[ConstraintSolver] Prioritize certain type variables while lo…

···

On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev < swift-dev@swift.org> wrote:

Sorry it might be my commit actually, I am AFK for a bit, will revert once
I am back.

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev <swift-dev@swift.org> > wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem there:

/Users/buildnode/jenkins/workspace-private/swift-
master-source-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27:
error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]
Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/389/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min
Changes

   - Commit *001b09747a153763b30ef8a02254c7a0419c6292* by *pyaskevich:*

   [ConstraintSolver] Prioritize certain type variables while looking for
   - *edit*: test/Constraints/generics.swift
      - *edit*: lib/Sema/CSSimplify.cpp
      - *edit*: lib/Sema/CSBindings.cpp
      - *edit*: lib/Sema/ConstraintSystem.h

   - Commit *6fe4ff8be7ab142ba7427c665b955770fc6905ba* by *mnvrth:*

   [CMake] Fix status message when not building stdlib/runtime
   - *edit*: CMakeLists.txt

   - Commit *5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7* by *mnvrth:*

   [CMake] Improve wording of stdlib/overlay/runtime build status
   - *edit*: CMakeLists.txt

   - Commit *f2ef42baed96e16086481537cc7dc87bbd2368b0* by *github:*

   [migrator] When renaming a function decl, we should use underscore to
   - *edit*: lib/Migrator/APIDiffMigratorPass.cpp
      - *edit*: test/Migrator/Inputs/Cities.swift
      - *edit*: test/Migrator/rename-func-decl.swift
      - *edit*: test/Migrator/rename-func-decl.swift.expected
      - *edit*: test/Migrator/Inputs/API.json

   - Commit *c47287199bce9b4d2c9ae0dc308dc328461ce9f6* by *arthur:*

   Updated Guitar support for Swift 4.0
   - *edit*: projects.json

   - Commit *1a82e4d490d4607da81f58327eb0f900f3056c08* by *antonvmironov:*

   AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed
   - *edit*: projects.json

   - Commit *ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b* by *arthur:*

   Re-added 3.1 compatibility
   - *edit*: projects.json

   - Commit *632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a* by *arthur:*

   Removed comma
   - *edit*: projects.json

   - Commit *87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494* by *antonvmironov:*

   UnXFAIL AsyncNinja
   - *edit*: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Pavel_Yaskevich · 2017-10-03T01:58:15.000Z

Jordan, let's see if this helps because when I merged my original PR there
were no failures and only one target of AsyncNinja has been disabled, but I
noticed (just now) that all of them fail now which might actually not be my
fault...

···

On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev < swift-dev@swift.org> wrote:

Merged revert into master Merge pull request #70171 from gottesmm/pr-b349a91e3e11b734533ef6be69… · apple/swift@4c754ae · GitHub
9642ff0ba6018f5c236186627a3038627ea05a29

On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev < > swift-dev@swift.org> wrote:

Sorry it might be my commit actually, I am AFK for a bit, will revert
once I am back.

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev < >> swift-dev@swift.org> wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem there:

/Users/buildnode/jenkins/workspace-private/swift-master-
source-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27:
error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]
Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/389/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min
Changes

   - Commit *001b09747a153763b30ef8a02254c7a0419c6292* by *pyaskevich:*

   [ConstraintSolver] Prioritize certain type variables while looking for
   - *edit*: test/Constraints/generics.swift
      - *edit*: lib/Sema/CSSimplify.cpp
      - *edit*: lib/Sema/CSBindings.cpp
      - *edit*: lib/Sema/ConstraintSystem.h

   - Commit *6fe4ff8be7ab142ba7427c665b955770fc6905ba* by *mnvrth:*

   [CMake] Fix status message when not building stdlib/runtime
   - *edit*: CMakeLists.txt

   - Commit *5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7* by *mnvrth:*

   [CMake] Improve wording of stdlib/overlay/runtime build status
   - *edit*: CMakeLists.txt

   - Commit *f2ef42baed96e16086481537cc7dc87bbd2368b0* by *github:*

   [migrator] When renaming a function decl, we should use underscore to
   - *edit*: lib/Migrator/APIDiffMigratorPass.cpp
      - *edit*: test/Migrator/Inputs/Cities.swift
      - *edit*: test/Migrator/rename-func-decl.swift
      - *edit*: test/Migrator/rename-func-decl.swift.expected
      - *edit*: test/Migrator/Inputs/API.json

   - Commit *c47287199bce9b4d2c9ae0dc308dc328461ce9f6* by *arthur:*

   Updated Guitar support for Swift 4.0
   - *edit*: projects.json

   - Commit *1a82e4d490d4607da81f58327eb0f900f3056c08* by
   *antonvmironov:*

   AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed
   - *edit*: projects.json

   - Commit *ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b* by *arthur:*

   Re-added 3.1 compatibility
   - *edit*: projects.json

   - Commit *632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a* by *arthur:*

   Removed comma
   - *edit*: projects.json

   - Commit *87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494* by
   *antonvmironov:*

   UnXFAIL AsyncNinja
   - *edit*: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Pavel_Yaskevich · 2017-10-03T05:11:19.000Z

Looks like it wasn't me after all, source compatibility suite still fails
in AsyncNinja even with my changes reverted -
https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/391/

···

On Mon, Oct 2, 2017 at 6:58 PM, Pavel Yaskevich via swift-dev < swift-dev@swift.org> wrote:

Jordan, let's see if this helps because when I merged my original PR there
were no failures and only one target of AsyncNinja has been disabled, but I
noticed (just now) that all of them fail now which might actually not be my
fault...

On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev < > swift-dev@swift.org> wrote:

Merged revert into master appl · GitHub
e/swift/commit/9642ff0ba6018f5c236186627a3038627ea05a29

On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev < >> swift-dev@swift.org> wrote:

Sorry it might be my commit actually, I am AFK for a bit, will revert
once I am back.

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev < >>> swift-dev@swift.org> wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem
there:

/Users/buildnode/jenkins/workspace-private/swift-master-sour
ce-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27:
error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]
Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/38
9/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min
Changes

   - Commit *001b09747a153763b30ef8a02254c7a0419c6292* by *pyaskevich:*

   [ConstraintSolver] Prioritize certain type variables while looking
   for
   - *edit*: test/Constraints/generics.swift
      - *edit*: lib/Sema/CSSimplify.cpp
      - *edit*: lib/Sema/CSBindings.cpp
      - *edit*: lib/Sema/ConstraintSystem.h

   - Commit *6fe4ff8be7ab142ba7427c665b955770fc6905ba* by *mnvrth:*

   [CMake] Fix status message when not building stdlib/runtime
   - *edit*: CMakeLists.txt

   - Commit *5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7* by *mnvrth:*

   [CMake] Improve wording of stdlib/overlay/runtime build status
   - *edit*: CMakeLists.txt

   - Commit *f2ef42baed96e16086481537cc7dc87bbd2368b0* by *github:*

   [migrator] When renaming a function decl, we should use underscore to
   - *edit*: lib/Migrator/APIDiffMigratorPass.cpp
      - *edit*: test/Migrator/Inputs/Cities.swift
      - *edit*: test/Migrator/rename-func-decl.swift
      - *edit*: test/Migrator/rename-func-decl.swift.expected
      - *edit*: test/Migrator/Inputs/API.json

   - Commit *c47287199bce9b4d2c9ae0dc308dc328461ce9f6* by *arthur:*

   Updated Guitar support for Swift 4.0
   - *edit*: projects.json

   - Commit *1a82e4d490d4607da81f58327eb0f900f3056c08* by
   *antonvmironov:*

   AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed
   - *edit*: projects.json

   - Commit *ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b* by *arthur:*

   Re-added 3.1 compatibility
   - *edit*: projects.json

   - Commit *632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a* by *arthur:*

   Removed comma
   - *edit*: projects.json

   - Commit *87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494* by
   *antonvmironov:*

   UnXFAIL AsyncNinja
   - *edit*: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Pavel_Yaskevich · 2017-10-03T05:28:15.000Z

It looks like the change was introduced by

github.com/AsyncNinja/AsyncNinja

Making propert queue and stack structures based on singly lined list

committed 02:39PM - 16 Sep 17 UTC

antonvmironov

+485 -138

which got into the suite along with the fix for

github.com/apple/swift

[SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type

opened 07:46PM - 26 Sep 17 UTC

closed 07:03PM - 02 Oct 17 UTC

xedin

bug compiler type checker source compatibility

| | | |------------------|-----------------|… |Previous ID | SR-5998 | |Radar | None | |Original Reporter | @xedin | |Type | Bug | |Status | Resolved | |Resolution | Done | <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Bug, SourceCompatibility, TypeChecker | |Assignee | @lplarson | |Priority | Medium | md5: 942e737fd1cf2fffc22d39b41c71eb36 </details> **Issue Description:** Changes in PR <https://github.com/apple/swift/pull/12072> fixed compiler bug related to enforcing of structural checks between return type and contextual type, which uncovered a bug in AsyncNinja project where return type of the closure doesn't match contextual type - \`value:\` vs. \`date:\` labels. /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite/project_cache/AsyncNinja/Sources/iOS.swift:653:40: error: expression type '(date: _, isAnimated: _)' is ambiguous without more context customGetter: \{ (date: $0.value, isAnimated: false) }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

···

On Mon, Oct 2, 2017 at 10:11 PM, Pavel Yaskevich via swift-dev < swift-dev@swift.org> wrote:

Looks like it wasn't me after all, source compatibility suite still fails
in AsyncNinja even with my changes reverted - https://ci.swift.org/view/
Source%20Compatibility/job/swift-master-source-compat-suite/391/

On Mon, Oct 2, 2017 at 6:58 PM, Pavel Yaskevich via swift-dev < > swift-dev@swift.org> wrote:

Jordan, let's see if this helps because when I merged my original PR
there were no failures and only one target of AsyncNinja has been disabled,
but I noticed (just now) that all of them fail now which might actually not
be my fault...

On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev < >> swift-dev@swift.org> wrote:

Merged revert into master appl · GitHub
e/swift/commit/9642ff0ba6018f5c236186627a3038627ea05a29

On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev < >>> swift-dev@swift.org> wrote:

Sorry it might be my commit actually, I am AFK for a bit, will revert
once I am back.

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev < >>>> swift-dev@swift.org> wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem
there:

/Users/buildnode/jenkins/workspace-private/swift-master-sour
ce-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27:
error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org wrote:

[FAILURE] swift-master-source-compat-suite [#389]
Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/38
9/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min
Changes

   - Commit *001b09747a153763b30ef8a02254c7a0419c6292* by *pyaskevich:*

   [ConstraintSolver] Prioritize certain type variables while looking
   for
   - *edit*: test/Constraints/generics.swift
      - *edit*: lib/Sema/CSSimplify.cpp
      - *edit*: lib/Sema/CSBindings.cpp
      - *edit*: lib/Sema/ConstraintSystem.h

   - Commit *6fe4ff8be7ab142ba7427c665b955770fc6905ba* by *mnvrth:*

   [CMake] Fix status message when not building stdlib/runtime
   - *edit*: CMakeLists.txt

   - Commit *5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7* by *mnvrth:*

   [CMake] Improve wording of stdlib/overlay/runtime build status
   - *edit*: CMakeLists.txt

   - Commit *f2ef42baed96e16086481537cc7dc87bbd2368b0* by *github:*

   [migrator] When renaming a function decl, we should use underscore
   to
   - *edit*: lib/Migrator/APIDiffMigratorPass.cpp
      - *edit*: test/Migrator/Inputs/Cities.swift
      - *edit*: test/Migrator/rename-func-decl.swift
      - *edit*: test/Migrator/rename-func-decl.swift.expected
      - *edit*: test/Migrator/Inputs/API.json

   - Commit *c47287199bce9b4d2c9ae0dc308dc328461ce9f6* by *arthur:*

   Updated Guitar support for Swift 4.0
   - *edit*: projects.json

   - Commit *1a82e4d490d4607da81f58327eb0f900f3056c08* by
   *antonvmironov:*

   AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed
   - *edit*: projects.json

   - Commit *ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b* by *arthur:*

   Re-added 3.1 compatibility
   - *edit*: projects.json

   - Commit *632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a* by *arthur:*

   Removed comma
   - *edit*: projects.json

   - Commit *87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494* by
   *antonvmironov:*

   UnXFAIL AsyncNinja
   - *edit*: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

jrose · 2017-10-03T17:18:52.000Z

[others to bcc, sorry for pulling you along] I think Ben's latest changes to the use of AnySequence have a good chance of fixing this.

Jordan

···

On Oct 2, 2017, at 22:28, Pavel Yaskevich <pavel.yaskevich@gmail.com> wrote:

It looks like the change was introduced by Making propert queue and stack structures based on singly lined list · AsyncNinja/AsyncNinja@1cc002e · GitHub which got into the suite along with the fix for [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub

On Mon, Oct 2, 2017 at 10:11 PM, Pavel Yaskevich via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Looks like it wasn't me after all, source compatibility suite still fails in AsyncNinja even with my changes reverted - https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/391/

On Mon, Oct 2, 2017 at 6:58 PM, Pavel Yaskevich via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Jordan, let's see if this helps because when I merged my original PR there were no failures and only one target of AsyncNinja has been disabled, but I noticed (just now) that all of them fail now which might actually not be my fault...

On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Merged revert into master Merge pull request #12235 from xedin/fix-subtype-revert · apple/swift@9642ff0 · GitHub

On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Sorry it might be my commit actually, I am AFK for a bit, will revert once I am back.

Sent from my iPhone

On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

Anton just reupdated AsyncNinja, but it looks we have a new problem there:

/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27: error: ambiguous use of 'suffix'
    _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize))
                          ^
Swift.Sequence:301:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> Self.SubSequence
                ^
Swift.Sequence:53:17: note: found this candidate
    public func suffix(_ maxLength: Int) -> AnySequence<Self.Element>
                ^

Pavel, there's already a bug for this, right?

Jordan

On Oct 2, 2017, at 15:44, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] swift-master-source-compat-suite [#389]

Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/389/
Project: swift-master-source-compat-suite
Date of build: Mon, 02 Oct 2017 15:15:01 -0500
Build duration: 2 hr 30 min

Changes

Commit 001b09747a153763b30ef8a02254c7a0419c6292 by pyaskevich:
[ConstraintSolver] Prioritize certain type variables while looking for

edit: test/Constraints/generics.swift
edit: lib/Sema/CSSimplify.cpp
edit: lib/Sema/CSBindings.cpp
edit: lib/Sema/ConstraintSystem.h

Commit 6fe4ff8be7ab142ba7427c665b955770fc6905ba by mnvrth:
[CMake] Fix status message when not building stdlib/runtime

edit: CMakeLists.txt

Commit 5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7 by mnvrth:
[CMake] Improve wording of stdlib/overlay/runtime build status

edit: CMakeLists.txt

Commit f2ef42baed96e16086481537cc7dc87bbd2368b0 by github:
[migrator] When renaming a function decl, we should use underscore to

edit: lib/Migrator/APIDiffMigratorPass.cpp
edit: test/Migrator/Inputs/Cities.swift
edit: test/Migrator/rename-func-decl.swift
edit: test/Migrator/rename-func-decl.swift.expected
edit: test/Migrator/Inputs/API.json

Commit c47287199bce9b4d2c9ae0dc308dc328461ce9f6 by arthur:
Updated Guitar support for Swift 4.0

edit: projects.json

Commit 1a82e4d490d4607da81f58327eb0f900f3056c08 by antonvmironov:
AsyncNinja updated. [SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type · Issue #48555 · apple/swift · GitHub fixed

edit: projects.json

Commit ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b by arthur:
Re-added 3.1 compatibility

edit: projects.json

Commit 632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a by arthur:
Removed comma

edit: projects.json

Commit 87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494 by antonvmironov:
UnXFAIL AsyncNinja

edit: projects.json

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev