gparker42
March 19, 2017, 11:59pm
1
Michael, one of your changes broke all three ASAN bots. Please fix or revert ASAP.
(Could this be related to [build-script] When building with asan, mangle asan into the build subdirectory name. by gottesmm · Pull Request #8169 · apple/swift · GitHub ? I didn't confirm that the bot's change lists are correct.)
···
On Mar 18, 2017, at 11:48 AM, no-reply@swift.org wrote:
[FAILURE] oss-swift-incremental-ASAN-RA-osx [#212 ]
Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/
Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/212/consoleFull#1684097467c38edd5a-00f9-40a2-abac-1db59f7a90ca> ;
Commit e52eea2199d8c23ceb82b6bbe85aeb341ccb0fa2 by Michael Gottesman:
edit: lib/SILGen/FormalEvaluation.cpp
Commit 53eab13be8dd1202428af1b5c315f17c1ab02186 by Michael Gottesman:
edit: lib/SILGen/ResultPlan.cpp
Michael, one of your changes broke all three ASAN bots. Please fix or revert ASAP.
(Could this be related to [build-script] When building with asan, mangle asan into the build subdirectory name. by gottesmm · Pull Request #8169 · apple/swift · GitHub ? I didn't confirm that the bot's change lists are correct.)
It is more complicated than you would think. I looked at this earlier. The change itself looks benign and in fact it was happening without ASAN when I had written it in a previous manner. I thought it was a compiler bug so I rewrote it in a simpler manner and the problem went away. If you look at 53eab13be8dd1202428af1b5c315f17c1ab02186, I am just moving some code into a method.
It is not related to the other PR which is due to more COW copies occuring. It appears that I fixed all of the COW issues with a release stdlib (when client is compiled in Debug), but there may be additional COW copies when the stdlib is compiled in Debug mode. = /.
Michael
···
On Mar 19, 2017, at 4:59 PM, Greg Parker <gparker@apple.com> wrote:
On Mar 18, 2017, at 11:48 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:
[FAILURE] oss-swift-incremental-ASAN-RA-osx [#212 ]
Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/
Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/212/consoleFull#1684097467c38edd5a-00f9-40a2-abac-1db59f7a90ca> ;
Commit e52eea2199d8c23ceb82b6bbe85aeb341ccb0fa2 by Michael Gottesman:
edit: lib/SILGen/FormalEvaluation.cpp
Commit 53eab13be8dd1202428af1b5c315f17c1ab02186 by Michael Gottesman:
edit: lib/SILGen/ResultPlan.cpp