I think the root problem is that some of the dispatch tests, including this
one, are trying to test that timers/events happen within a "reasonable"
interval of time from when they are supposed to. If deadlines are missed
too badly, then the test is marked as failing.
If we completely disabled all such tests, we run the risk of breaking the
timer/event subsystem of libdispatch and not noticing.
However, on the CI system there is unpredictable load, so "reasonable" is
hard to specify and with some probability, deadlines will be missed no
matter how loosely they are set.
If this test is failing frequently and the infrastructure does not support
rerunning or ignoring a flagged "flakey" test then disabling it is
probably the expedient option.
Probably what we need to do is strip down to (1) a very reliable subset of
the dispatch tests that are run on most CI jobs and a (2) more
comprehensive set of tests that is run in a separate job just for
libdispatch testing. Job (2) can afford to include tests with low
probability failures because only the dispatch team would need to pay
attention to them and decide if they were real failures or not. Is
something like this possible to set up?
--dave
<swift-corelibs-dev@swift.org>
<swift-corelibs-dev@swift.org>
0. OSS - Swift Incremental RA - Ubuntu 15.10 (master) #8568
Sent by: swift-corelibs-dev-bounces@swift.org
It has also been reported as a dup here:
https://bugs.swift.org/browse/SR-3110
It’s important that we fix this one so we stop wasting five minutes of many
peoples’ time several times a day.
Maybe we should disable it until it’s fixed?
···
From: Doug Coleman via swift-corelibs-dev
To: Jordan Rose <jordan_rose@apple.com>
Cc: swift-dev <swift-dev@swift.org>, swift-corelibs-dev
Date: 11/02/2016 01:48 PM
Subject: Re: [swift-corelibs-dev] [swift-dev] [Swift CI] Build Failure:
On Nov 2, 2016, at 10:46 AM, Jordan Rose <jordan_rose@apple.com> wrote:
Adding swift-corelibs-dev, since that’s where the Dispatch folks hang
out.
On Nov 2, 2016, at 10:44, Doug Coleman via swift-dev < swift-dev@swift.org> wrote:
[SR-2931] libdispatch `dispatch_suspend_timer` test needs robustification · Issue #717 · apple/swift-corelibs-libdispatch · GitHub
On Nov 2, 2016, at 10:43 AM, no-reply@swift.org wrote:
[FAILURE] oss-swift-incremental-RA-linux-ubuntu-15_10
[#8568]
Build URL: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/8568/
Project: oss-swift-incremental-RA-linux-ubuntu-15_10
Date of Wed, 02 Nov 2016 10:17:41 -0700
build:
Build 25 min
duration:
Tests:
Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 8487 test(s), Total: 8487 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 299 test(s), Total: 299 test(s)
Changes
Commit 3575ee1954ea68f3d569c1f4481ca850d9fe87a3 by
practicalswift:
[swiftc (94 vs. 5180)] Add crasher in ?
add:
validation-test/compiler_crashers/28463-child-source-range-not-contained-within-its-parent-guard-stmt.swift
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev