[Swift 2.2] IRGen: Don't try to bind witness tables for archetype protocol requirements that don't need them.

Joe_Groff · 2016-02-09T21:08:53.000Z

Hey Joe, I'm testing a fix for a crash regression reported on Swift 2.2 as rdar://problem/24568361. I'd like to get this cherry-picked into the 2.2 branch.

https://github.com/apple/swift/pull/1245

-Joe

Joe_Pamer · 2016-02-09T21:12:57.000Z

Thanks, Joe! The PR looks good to me, but would someone more familiar with IRGen mind taking a quick look? (Slava?)

- Joe

···

On Feb 9, 2016, at 1:08 PM, Joe Groff <jgroff@apple.com> wrote:

Hey Joe, I'm testing a fix for a crash regression reported on Swift 2.2 as rdar://problem/24568361. I'd like to get this cherry-picked into the 2.2 branch.

IRGen: Don't try to bind witness tables for archetype protocol requirements that don't need them. by jckarter · Pull Request #1245 · apple/swift · GitHub

-Joe

Slava_Pestov · 2016-02-09T22:43:45.000Z

I don't claim to have any kind of deep understanding of IRGen, but this change makes sense to me.

Slava

···

On Feb 9, 2016, at 1:12 PM, Joe Pamer <jpamer@apple.com> wrote:

Thanks, Joe! The PR looks good to me, but would someone more familiar with IRGen mind taking a quick look? (Slava?)

- Joe

On Feb 9, 2016, at 1:08 PM, Joe Groff <jgroff@apple.com> wrote:

Hey Joe, I'm testing a fix for a crash regression reported on Swift 2.2 as rdar://problem/24568361. I'd like to get this cherry-picked into the 2.2 branch.

IRGen: Don't try to bind witness tables for archetype protocol requirements that don't need them. by jckarter · Pull Request #1245 · apple/swift · GitHub

-Joe

Joe_Pamer · 2016-02-09T23:02:02.000Z

Your ringing endorsement, coupled with the fact that the CI tests are passing, means this change is approved for 2.2. Joe, please feel free to cherry-pick the change to swift-2.2-branch.

Thanks!
- Joe

···

On Feb 9, 2016, at 2:43 PM, Slava Pestov <spestov@apple.com> wrote:

I don't claim to have any kind of deep understanding of IRGen, but this change makes sense to me.

Slava

On Feb 9, 2016, at 1:12 PM, Joe Pamer <jpamer@apple.com> wrote:

Thanks, Joe! The PR looks good to me, but would someone more familiar with IRGen mind taking a quick look? (Slava?)

- Joe

On Feb 9, 2016, at 1:08 PM, Joe Groff <jgroff@apple.com> wrote:

Hey Joe, I'm testing a fix for a crash regression reported on Swift 2.2 as rdar://problem/24568361. I'd like to get this cherry-picked into the 2.2 branch.

IRGen: Don't try to bind witness tables for archetype protocol requirements that don't need them. by jckarter · Pull Request #1245 · apple/swift · GitHub

-Joe