The review of SSWG-0028: Oracle-NIO begins now and runs for two weeks, until January 31, 2024.
Reviews are an important part of the Swift Server Work Group incubation process . All review feedback should be either on this forum thread or, if you would like to keep your feedback private, directly to the review manager (via email) or direct message in the Swift forums.
The package is being proposed at the Sandbox maturity level.
What goes into a review of a proposal?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, become listed on the Swift Server Ecosystem index page .
When reviewing a proposal, here are some questions to consider:
What is your evaluation of the proposal and its APIs/implementation?
Is the problem being addressed relevant for the wider Swift on Server ecosystem?
Does this proposal fit well with the feel and direction of the Swift Server ecosystem?
If you have used other libraries in Swift or other languages, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
+1 to this - it's a common use case in enterprise and comes up occasionally - there's currently no good implementation and this fills an important gap.
The API looks nice. The need to import PostgresNIO is awkward but understandable until the connection pool stuff is broken out
+1 on incubating this package. Oracle is still a widely spread database in enterprise context and having support for it in the ecosystem is important. My only concern during the pitch was the usage of the unvetted Crypto from CryptoSwift but you replaces this with swift-crypto and hand rolled the PKBDF2 implementation on top of the safe APIs exposed by Crypto which is a good temporary solution.
