small nit in NSKeyedArchiver.swift


(Luke Howard) #1

Posting to mailing list as I’m not able to test this right now, but I suspect this patch should be applied –

diff --git a/Foundation/NSKeyedArchiver.swift b/Foundation/NSKeyedArchiver.swift
index d070a15..fdcedae 100644
--- a/Foundation/NSKeyedArchiver.swift
+++ b/Foundation/NSKeyedArchiver.swift
@@ -193,7 +193,7 @@ public class NSKeyedArchiver : NSCoder {
             }
         } else {
             success = CFPropertyListWrite(plist, self._stream as! CFWriteStream,
- kCFPropertyListOpenStepFormat, 0, nil) > 0
+ kCFPropertyListXMLFormat_v1_0, 0, nil) > 0
         }
         
         return success

as the Openstep format is not supported by CF for writing.

···

--
www.lukehoward.com
soundcloud.com/lukehoward


(Tony Parker) #2

This looks correct to me. Can you file JIRA or put up a PR?

Thanks!
- Tony

···

On Jul 19, 2016, at 11:16 PM, Luke Howard via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Posting to mailing list as I’m not able to test this right now, but I suspect this patch should be applied –

diff --git a/Foundation/NSKeyedArchiver.swift b/Foundation/NSKeyedArchiver.swift
index d070a15..fdcedae 100644
--- a/Foundation/NSKeyedArchiver.swift
+++ b/Foundation/NSKeyedArchiver.swift
@@ -193,7 +193,7 @@ public class NSKeyedArchiver : NSCoder {
             }
         } else {
             success = CFPropertyListWrite(plist, self._stream as! CFWriteStream,
- kCFPropertyListOpenStepFormat, 0, nil) > 0
+ kCFPropertyListXMLFormat_v1_0, 0, nil) > 0
         }
         
         return success

as the Openstep format is not supported by CF for writing.

--
www.lukehoward.com <http://www.lukehoward.com/>
soundcloud.com/lukehoward
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev