The second review of SE-0268 — Refine
didSet Semantics begins now and runs through December 9th, 2019.
This is a follow-up to the previous review discussion. The review was discussed with the core team, and the team believes the proposal should be accepted with a specific amendment to address concerns in the prior review: that in cases where an implicit
oldValue parameter is used, causing the value to be fetched, a warning should be generated asking the user to add the parameter explicitly.
You can find a diff from the prior proposal here.
Reviews are an important part of the Swift evolution process. All review feedback should be either on this forum thread or, if you would like to keep your feedback private, directly to the review manager (via email or direct message in the Swift forums).
What goes into a review of a proposal?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift.
When reviewing a proposal, here are some questions to consider:
What is your evaluation of the proposal?
Is the problem being addressed significant enough to warrant a change to Swift?
Does this proposal fit well with the feel and direction of Swift?
If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?