SE-0200: "Raw" mode string literals


(Jon Shier) #121
  • What is your evaluation of the proposal?

-1

  • Is the problem being addressed significant enough to warrant a change to Swift?

It would be nice to not have to escape regexes, but I think a more holistic proposal regarding string literals in Swift would be better. One that can address the shortcomings of the current multiline literals, introduces raw literals, and makes them work together well, as well as with the current simple string design. Until then, all we’re doing is adding more and more complexity to string literals in Swift.

  • Does this proposal fit well with the feel and direction of Swift?

Although the current direction seems making string literals more complex in addition to more powerful, I’d like to see something that unifies all of the representations together.

  • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

I’m not sure, since I’ve never needed it in the other languages I’ve used. Perhaps because they have distinct raw characters?

  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read the proposals, read this thread.


(Adrian Kashivskyy) #122

What is your evaluation of the proposal?

-1. I agree with previous comments that we need to have first-class (typed) support for regular expressions, that // would be the right direction and that r"" will be a very confusing and incoherent syntax for “raw strings”.

Is the problem being addressed significant enough to warrant a change to Swift?

For strings which are not regular expression patterns – no, in my opinion, it’s not. For regular expressions – yes, but again, it should be considered as a separate problem.

Does this proposal fit well with the feel and direction of Swift?

No. The r"" syntax is very inconsistent with the feel and direction of Swift.

If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Yes, I did. And I think it’s not a good syntax.

How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read the proposal and some comments in this thread.


(John Holdsworth) #123

OK… so nobody likes r”a string” as a syntax judging by the number of -1’s coming through.

I’m surprised there wasn’t more take-up on @Tino’s excellent suggestion yesterday:

 “\qa string with \\’s”

 “””\q
    a string with \\’s
    “””

There is an Xcode toolchain implementing it available here. I’ve taken it a step further and there are two modes: \Q which processes absolutely no escapes and \q which processes no escapes but still allows interpolation which while it might sound complex is probably what you really want.

By way of a summary of the thread so far, the toolchain supports:

print(r"SE-200" )
print(r"""
      SE-200
      """ )

print(#raw("SE-200"))
print(#raw(X"SE-200"X))
print(#raw(<"SE-200">))

print(#rawStringLiteral("""
    SE-200
    """))

print("\qSE-\(200)")
print("\QSE-200")

print("""\q
    SE-\(200)
    """)
print("""\Q
    SE-200
    """)

(^) #124

I really don’t like having the modifiers be inside the quotation marks. it looks like the \q is part of the string contents instead of an attribute of the literal. i don’t get the hate towards r" i used it in python and never had a problem with it…


(Karim Nassar) #125

I do think it’s a little amusing that the Commonly Rejected Changes page actually references this use case as a preferred fit for single quoted strings…


(John Holdsworth) #126

I’d rather see this succeed as a use for ‘’: Prepitch: Character integer literals


(Brent Royal-Gordon) #127

Clearly I need to pay closer attention to evolution if I missed this coming!

I definitely like the feature. I think the r"contents" syntax is fine; the \"contents" syntax is an intriguing alternative (I read it as “backslash everything in this string”), and the #raw("contents") syntax is probably fine too. I don’t like the longer alternatives to #raw; we must remember that identifiers like #imageLiteral aren’t actually intended to ever be seen by a user, while this syntax would be written by hand.

A few people have complained that they don’t think #raw totally explains the construct, but I don’t really buy that argument. Literal syntax is part of the language grammar; it’s something you should learn and eventually remember. #raw is searchable without being obstructively verbose. The backslash and leading-identifier syntaxes are harder to search, but they’re at least visually distinctive enough to know that you’re seeing something a little unusual.

I think the alternate delimiter question is severable and should be considered separately, but for my part, I would support single quotes as an alternative delimiter. Swift inherits many things from C, but its string handling more closely resembles scripting languages (especially Perl 6), which usually treat ' as an alternate delimiter. Besides, if there’s one thing about C I wouldn’t emulate, it’s C’s treatment of strings.

We could also consider additional options for string delimiters (I think that at one point, I suggested that any odd number of " or ' characters should be treated as a valid delimiter, and the single-line/multi-line behavior of a string should depend on whether the opening delimiter is followed by a newline or not), but I don’t think we need to decide that now.


(Adrian Zubarev) #128

If it’s not too late I want to pitch a different approach. Everyone here is talking about another verbose styled #rawString or a way to reuse the good old " and ' characters as delimiters for the raw string. A lot of you guys already write a different type of string (visually speaking) in this forum by using the markdown way with back-ticks. The only issue with my pitch is that the single back-ticks are already taken in Swift for something like

case `default`

so we cannot create a perfect symmetrical raw string literal to the existing " and """ versions, or can we? (Someone please clarify if this still could be made unambiguous.)

At least the multi-line rawstring literal would be possible, and most of us are already used to this:

let rawString = ```
write whatever you want in here
``` 

Ideally the other literal would look like this (but I’m not sure if it’s possible due to the fact from before):

let rawString = `write whatever you want in here`

(Dave DeLong) #129

An intriguing suggestion. How would this handle wanting to put backticks inside the raw string?


(Adrian Zubarev) #130

Well that’s the thing a purely raw string isn’t possible with this approach and I would advocate against completely swallowing the backslash in the multi-line string literal because someone, like myself, has linter rules where exceeding the 80 character line width is an error. Therefore I need the trailing backslash to wrap a string literal. Even in the raw string literal it would be useful.

That said I’m against this aggressive change:

The \ character would loose it role as an escaping introducer altogether.

Instead I would prefer to weaken it and call the whole thing a semi-raw string.


@davedelong: To answer your qustion, I’d go with the same rule we currently have with the multi-line """ string literal if that’s possible.


At least this is how I would imagine it. If there is a better solution using back-ticks then go for it. ;)


(Jean-Daniel) #131

The same way you add double quote in a r"" string. You can’t.


(Dave DeLong) #132

In my opinion, it’s a worthwhile goal to make sure that any raw string approach allows for a custom delimiter.

Maybe it would be something like:

let raw = ```q
this is my raw string with ``` in it
q```

Putting a letter after the opening triple-backticks could be a way to specify the delimiter. (it doesn’t have to be q; that was just an example)


(Chéyo Jiménez) #133

This is interesting. In that case why not include full support for code highlighting. https://help.github.com/articles/creating-and-highlighting-code-blocks/

I haven’t check the latest version of swift but I remember that swift doc comments accept code block. http://nshipster.com/swift-documentation/

I am +1, As long as we can still support inline tests using the markdown block comments like rust does. https://doc.rust-lang.org/book/first-edition/documentation.html

#raw(`this should still allow ` inside here `)

(Davide De Franceschi) #134

It seems like, ultimately, any kind of delimiter character chosen would not be completely failproof. There is one solution that could allow any character and be fine with it… if the actual string was in a different file that is referenced altogether. This would be more or less #fileLiteral though… What are the use cases that make us want a diverse-enough range of strings that no character can be considered safe, but still not large or separated enough that it warrants a separate file?


(Adrian Zubarev) #135

Well currently there is an issue that would speak against it.

Other than that, I don’t see any other reasons against that approach and I think it’s worth thinking about it.


Edit: What if you wanted the string to be file private to not expose it to the whole module?


(John Holdsworth) #136

Thread wrap up

Tomorrow is the end of the review period so I’d like to try to summarise what I have taken from the thread.

I’ve published an updated version of the proposal for discussion here.

Summarising the story so far, this proposal puts forward a syntax for raw string literals which are strings where \ is passed through to the literal and has no special escaping powers. The suggested syntax is now #raw(“a string with a \”) rather than r”a string with a \” as in the original proposal merged into swift-evolution master at the beginning of this process.

This version of the proposal includes “customs delimiters lite” as originally put forward by @hooman at the beginning of the thread and later echoed by @Erica_Sadun.

Removing the “closing would be reversed” so your favourite emoji works, this would be a valid raw string:

print(#raw(🤡"SE-200"🤡))

In addition, the new version of the proposal includes what you could call “interpolating raw strings” which ignore escapes except for the sequence \(…) which can be used to interpolate. I propose the following syntax with double bracketing of the literal to turn this variant on:

print(#raw(("SE-\("200")")))

Revisiting the code which prompted me to start this process I realised it doesn’t take long before you find yourself needing this feature and the sequence \( is sufficiently rare outside Swift that this shouldn’t be a problem.

You can combine raw literals, custom delimiter syntax and interpolation with multi-line string literals

print(#raw((🤡"""
    SE-\(200)
    """🤡)))

Multiline raw literals would follow the same indentation removal rules as before.

That about covers it unless there is something I’ve missed. There is a Xcode toolchain with an implementation available here

I’m now firmly of the opinion that #raw(“a literal”) is about is good as we’re going to get. With any raw literal there is absolutely no way to escape the delimiter, so all single character delimiters (whichever quote you use) are simply not useful in the general case. This excludes r”a string”, \”a string”, “\qa string”, 'a string' from contention. You get many more options if you move to #raw(“a string”) which has, at a minimum, a closing delimiter of “) and you can now extend that using custom delimiter sequences.

To give the core team something to go on, Id like to call a straw poll on this new version of the proposal. Please respond what you would like the outcome to be:

+1: Accepted with revisions - New version of the proposal looks good.
-1: Reject - I don’t see the need for the feature

Apologies for the slightly chaotic progression of the review but I really feel we have explored the space quite thoroughly now and been able to put in front of the Core Team enough information for them to make a decision.


(Tino) #137

It’s not the most lightweight choice, but all compact solutions (like single quotes) would fail for strings that contain that specific character, so I think some verbosity can’t be avoided. Additionally, it would be straightforward to introduce variations with different rules.
In isolation, it seems like the best solution, and I guess we’ll have to accept the uncertainty of how a yet to be defined regex-literal will interfere with this.

Could you update the example so that it illustrates the explanation?

#raw({[?</"how will this be closed?

(John Holdsworth) #138

I think that would be #raw({[?</“a string”}]?>/) in the current implementation which isn’t ideal.
Difficult to see an alternative if you want good emoji support.


(Martin Waitz) #139

Well I don‘t think emojis are the most important use case for string delimiters. But even when someone wants to use these, we just have to teach the compiler to treat the emoji as a single character and not reverse the unicode scalars.


(John Holdsworth) #140

I’m saying the characters of the delimiter should not be reversed. I’d rather see:

#raw(DELIM”a string”DELIM)

than

#raw(DELIM”a string”MILED)

This also allows emojis to work which are notoriously difficult to segment…