RFC: Adding google/brotli dependency to Windows toolchain

Platform Windows
1

Hi,

While working on Add brotli support to FoundationNetworking by zhenchaoli · Pull Request #83441 · swiftlang/swift · GitHub we realized that we need to add google/brotli as a dependency to the Windows toolchain. So I want to make this post to gather people’s opinions.

The change itself is adding brotli compression support on Windows for Swift Networking, which is a HTTP compression format used extensively today. On Windows platform, Swift Networking is using libcurl under the hood, which already has good support for google/brotli integration.

I want to gather people’s thoughts before merging the change, since this involves adding a dependency for Windows platform.

Thanks.

2

I think that there is an important consideration that you are leaving out here: this is bringing parity between macOS and Windows. This is a crucial point about the motivation. Another important point is that brotli is under a permissive license (MIT).

Given those points, I am in favour of adding the dependency (there shouldn't be any concerns about the licensing and it eases shared platform code bases).

3

Thank you. Yes these are good points.