[Review] SE-0122: Use colons for subscript declarations


(Jon Hull) #1

* What is your evaluation of the proposal?

I would be in favor if we make the change to square brackets that everyone is talking about. Otherwise I am indifferent.

* Is the problem being addressed significant enough to warrant a change to Swift?

I do feel that the current setter behavior is confusing.

* Does this proposal fit well with the feel and direction of Swift?

As people have said, it doesn’t really fit with either function or property syntax, so we should consider the square bracket syntax.

* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

N/A

* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Quick read of the proposal and discussion

Thanks,
Jon

···

Hello Swift community,

The review of "SE-0122: Use colons for subscript declarations " begins now and runs through July 24. The proposal is available here:

  https://github.com/apple/swift-evolution/blob/master/proposals/0122-use-colons-for-subscript-type-declarations.md

Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-evolution mailing list at

  https://lists.swift.org/mailman/listinfo/swift-evolution

or, if you would like to keep your feedback private, directly to the review manager.

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:

  * What is your evaluation of the proposal?
  * Is the problem being addressed significant enough to warrant a change to Swift?
  * Does this proposal fit well with the feel and direction of Swift?
  * If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
  * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

More information about the Swift evolution process is available at

  https://github.com/apple/swift-evolution/blob/master/process.md

Thank you,

-Chris Lattner
Review Manager