It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.
On Jun 28, 2016, at 8:04 PM, Dave Abrahams via swift-evolution <swift-evolution@swift.org> wrote:
Hi,
It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.
return withUnsafeMutablePointers { (v, e) in return body(v) }
should be
return withUnsafeMutablePointers { (h, e) in return body(h) }
-- E
···
On Jun 28, 2016, at 8:04 PM, Dave Abrahams via swift-evolution <swift-evolution@swift.org> wrote:
Hi,
It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.
Let me know what corrections you want. Once you do so, I'll put it in as a pull request. Who do you want as the author
or should I put in "Administrative", "Core Team", or something similar?
-- E
···
On Jun 28, 2016, at 8:04 PM, Dave Abrahams via swift-evolution <swift-evolution@swift.org> wrote:
Hi,
It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.
return withUnsafeMutablePointers { (v, e) in return body(v) }
should be
return withUnsafeMutablePointers { (h, e) in return body(h) }
Looks good.
···
on Tue Jun 28 2016, Erica Sadun <erica-AT-ericasadun.com> wrote:
-- E
On Jun 28, 2016, at 8:04 PM, Dave Abrahams via swift-evolution <swift-evolution@swift.org> wrote:
Hi,
It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.
Let me know what corrections you want. Once you do so, I'll put it in
as a pull request.
I think the only thing needed is a reference to the patch
and removal of the notes about what needs auditing (since the patch
already takes care of it).
Who do you want as the author
or should I put in "Administrative", "Core Team", or something similar?
I'd like you to be the author, please!
···
on Tue Jun 28 2016, Erica Sadun <erica-AT-ericasadun.com> wrote:
-- E
On Jun 28, 2016, at 8:04 PM, Dave Abrahams via swift-evolution <swift-evolution@swift.org> wrote:
Hi,
It occurred to us a couple weeks ago that the name `Value` was
a terrible name for the first parameter to `ManagedBuffer` et al, so I
prepared this patch that renames it to `Header`.