Hello all.
Per "A new Member contributor role that can trigger CI" which was announced by @ahoppen 1.5 years ago, I'd like to request access to have permission to run CI in swiftlang repositories.
Swiftlang / Apple org PRs
Link to MahdiBM PR's in swiftlang / apple org repositories.
Top contributions from the first page that GitHub shows:
These are all merged:
- swift-nio: [perf] Manually implement
lastIndex(where:)inByteBufferView - swift-nio: Introduce
NIODecodedAsyncSequencefor easy decoding of async sequences- Related PR: swift-nio: Implement
AsyncSequence/splitLines()
- Related PR: swift-nio: Implement
- swift: [SILOptimizer] Specialize closures with a mark_dependence on a capture
- swift-nio: [perf] Do stack allocs instead of heap allocs for small fixed-size allocations
- swift-package-manager: Exclude scratch directory from Time Machine backups
- vscode-swift: Parse remarks as well, just like notes, warnings and errors
Pretty much approved:
- swift: [Optimizer] Improve stack-protection optimizations
- Approved, pending CI going green.
- swift-foundation: Make Base64 ~3 times encoding faster
- Approved by Tony Parker, Fabian privately mentioned he likes the PR, will likely be merged after Fabian's " [Base64] Use Span for Input and Output when Encoding" is merged and conflicts are resolved.
Recently opened, Not approved, Worst case they can be rejected by maintainers:
- swift: [Optimization] Teach LLVM that
range.lowerBound<=range.upperBound - swift: Add
@_addressableForDependenciesto "Underscored Attributes Reference"
As per Requirements for IP address and port APIs - #32 by MahdiBM and the Networking Workgroup meetings, It's almost certain that I'll be contributing a ton to the upcoming swiftlang/swift-networking-types repository, as lots of code will have to be carefully copied over from my own swift-endpoint to the official repo.
Generally speaking I'm also not planning on slowing down so you'll see more PRs coming up from me when I bump into some issue.
Swiftlang / Apple org Issues
Link to MahdiBM Issues's in swiftlang / apple org repositories.
I've filed lots of issues. I don't think they help with qualifications of having higher access, so only some brief mentions:
- swift: [6.4 regression]
StringtoSpanconversion got 3.4x slower due to a non-eliminated strong_release- Pending triage.
- swift: 35% of performance going to
#available(..., *)(__isPlatformVersionAtLeast)- Resolved so don't worry.
- swift: Don't impose a performance penalty when using
MutableSpan- Resolved so don't worry.
Other Organizations
I've been working closely on Vapor alongside @gwynne @0xTim @ptoffy and recently @fpseverino, for years.
Most notably, I'm the maintainer and code-owner of Vapor's automation bot, Penny Bot.
- Deployed on Vapor org's AWS account, the infrastructure is documented in the terraform sub-module.
More details
- Handles Vapor's automations across GitHub and Discord.
- If you've seen Penny anywhere do anything, that feature was almost certainly implemented by me.
Officially speaking, I'm in the "Maintainers" team of Vapor org.
Frankly I don't know the extent of permissions I've been granted in Vapor org (It's far beyond just the "Maintainers" team), but suffices to say I'm trusted with ability to force-merge PRs In the Vapor org (example: vapor/postgres-nio/pull/618):
A couple times I've had to (successfully) force-push into main (protected) branch of Penny Bot as well (I know force-push is not good but Penny is not a library or such and I've only used it sparingly to clean up history).
The Request
All these being said I'd like to have access to run CI as to not have to bother maintainers for each CI run.
Why?
As everybody with some contributions have experienced, it can get very cumbersome and require lots of back and forth when the CI is failing for any reason, including when it's not even related to the PR (for example last month the Windows CI was broken and that was a bit awkward to say the least to have to nudge the maintainer so much (Link))
Furthermore, I'd like to also ask for Commit permission if possible.
While I'm personally almost certain this will prove very useful, specially for the work on the upcoming swift-networking-types repository, I understand if this is too much for now, and I don't expect it.
As the final note, there is a third concern about "ok what if we trust you, but don't trust you not getting hacked", to which I'd like to say pretty much all my accounts are behind 3 Yubikeys.
Furthermore, I've long enabled Vigilant Mode on GitHub and every single commit of mine has been signed via a Yubikey, for years.
Details
While I'm doing my best, I can't do much about the joke that GitHub's 2FA support is.
So far I've only noticed a few websites such as AWS and Cloudflare properly support hardware keys. That is, requiring one of configured keys to login, with no bypass option.