Public Thread Local Storage API in Swift

miku1958 · 2023-12-25T07:02:27.417Z

Can the TLS API used by Observation be made public? It seems like it could be used in a lot of ways in multithreading.

apple/swift/blob/main/stdlib/public/Observation/Sources/Observation/ThreadLocal.swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2022 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
//
//===----------------------------------------------------------------------===//

@_silgen_name("_swift_observation_tls_get")
func _tlsGet() -> UnsafeMutableRawPointer?

@_silgen_name("_swift_observation_tls_set")
func _tlsSet(_ value: UnsafeMutableRawPointer?)

@available(SwiftStdlib 5.9, *)
struct _ThreadLocal {
  static var value: UnsafeMutableRawPointer? {

This file has been truncated. show original

jrose · 2023-12-25T08:17:35.290Z

Foundation already has a general API for thread-local storage, though it requires going through objects:

Apple Developer Documentation

threadDictionary | Apple Developer Documentation

The thread object's dictionary.

I think a full Swift thread-local API would use generics to preserve types that go in and out of the dictionary (I can imagine one where the keys are themselves types which conform to a protocol), but for now this is both easier and safer than the thing in Observation.

ktoso · 2023-12-25T08:26:11.914Z

If you're looking for an API right now™, you could technically just use the TaskLocal APIs because they set a thread local if there's no Task available: TaskLocal | Apple Developer Documentation

miku1958 · 2023-12-25T08:27:45.664Z

ktoso:

TaskLocal APIs

That is what I am looking for, thanks!

jrose · 2023-12-25T08:29:39.492Z

Oh? The documentation says it will use the default value:

A lookup made from the context of a synchronous function, that is not called from an asynchronous function (!), will immediately return the task-local’s default value.

Is that incorrect?

ktoso · 2023-12-25T08:34:44.618Z

That's misleading wording... Thanks for noticing, I'll send in a revamp of the docs.

Here's a test showcasing them working without any Task involved: swift/test/Concurrency/Runtime/async_task_locals_synchronous_bind.swift at main · apple/swift · GitHub

ktoso · 2023-12-25T09:44:53.762Z

Gave the rewording a shot here: [docs] TaskLocal APIs from non-Task code by ktoso · Pull Request #70622 · apple/swift · GitHub