[Proposal] SSM-0002: Rename `swift-metrics-extras` to `swift-system-metrics` to better reflect its purpose

Server Development
,
1

Hi all,

The proposal [SSM-0002] Rename swift-metrics-extras to better reflect its purpose for swift-metrics-extras is now up and In Review. This is another breaking change targeted for the 1.0.0.

The review period will run until Dec 11th - please feel free to post your feedback either as a reply to this thread, or on the pull request.

Thanks!

9 Likes
2

I’m supportive of the rename but this change will be more disruptive than the proposal explains I think…

while GitHub does setup redirects package identity is based on URLs if I remember correctly… so in theory mixing swift-metrics-extras and the new name would cause trouble if I remember this right?

I think we still should do this change, and at the same time call the new thing “1.0”, therefore basically deprecating the 0.x versions.

Am I misremembering how the package identity works @dschaefer2?

2 Likes
3

A big +1, let’s fix the name before the 1.0.

I’m not sure either, but I’d be surprised if this became a problem in practice, since this package is usually depended-on directly by applications, not libraries. So the application owner would just switch to the 1.0 and rename in the process.

2 Likes
4

Out of curiosity was this package always intended to be for system metrics and just had `extras` in the name? Or idea was to have different extras in it?

Anyway a good proposal where naming makes it all clear straight away.

1 Like
5

In the earliest days of many server packages ages ago we had a number of -extras repos which intended to make it easier to “contribute random helpers”. In practice those were problematic since versioning a “random bag of stuff” is a challenge so we’ve systematically moved to remove such packages.

If this package contained more different topics for example I think we would have “split it up”, but thankfully it has just one thing, so we can rename it instead.

4 Likes
6

+1 to renaming it - especially focused as is it, that makes a huge amount of sense to me

3 Likes
7

Thank you for the feedback. As far as I see there is no objections, the proposal is accepted and is now Ready for Implementation.

The plan is to release the 1.0.0 with the new name.

4 Likes