Hi!
Cheers,
You can start with the Starter Bugs on JIRA:
opened 11:42PM - 09 Sep 16 UTC
closed 06:52PM - 21 Dec 16 UTC
bug
parser
compiler
good first issue
diagnostics QoI
| | |
|------------------|-----------------|…
|Previous ID | SR-2605 |
|Radar | None |
|Original Reporter | @jckarter |
|Type | Bug |
|Status | Closed |
|Resolution | Done |
<details>
<summary>Additional Detail from JIRA</summary>
| | |
|------------------|-----------------|
|Votes | 0 |
|Component/s | Compiler |
|Labels | Bug, DiagnosticsQoI, Parser, StarterBug |
|Assignee | @modocache |
|Priority | Medium |
md5: 4700a3a0330dc628a2226b9d21b6eb4b
</details>
**Issue Description:**
If you're refactoring a `guard` into an `if`, it's easy to accidentally end up with invalid code like this in the transition:
``` java
if condition else {
}
```
The parser rightly complains about the `else`, but has poor recovery afterward, interpreting the following brace as a closure, which may in turn lead to other unhelpful errors after:
``` java
/Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:32: error: expected '{' after 'if' condition
if source === _nilSentinel else {
^
/Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:37: error: braced block of statements is an unused closure
if source === _nilSentinel else {
^
```
It might be friendlier to recognize this pattern and instead recover as if the `else` wasn't there, or as if there were an empty block before it.
···
On Sep 10, 2016, at 1:22 PM, Leonid Kogan via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:
Hi!
Cheers,
_______________________________________________https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
gribozavr
September 10, 2016, 9:41pm
3
Thanks Leonid, we'd appreciate your help!
Here's a list filtered down to just the open issues:
opened 11:42PM - 09 Sep 16 UTC
closed 06:52PM - 21 Dec 16 UTC
bug
parser
compiler
good first issue
diagnostics QoI
| | |
|------------------|-----------------|…
|Previous ID | SR-2605 |
|Radar | None |
|Original Reporter | @jckarter |
|Type | Bug |
|Status | Closed |
|Resolution | Done |
<details>
<summary>Additional Detail from JIRA</summary>
| | |
|------------------|-----------------|
|Votes | 0 |
|Component/s | Compiler |
|Labels | Bug, DiagnosticsQoI, Parser, StarterBug |
|Assignee | @modocache |
|Priority | Medium |
md5: 4700a3a0330dc628a2226b9d21b6eb4b
</details>
**Issue Description:**
If you're refactoring a `guard` into an `if`, it's easy to accidentally end up with invalid code like this in the transition:
``` java
if condition else {
}
```
The parser rightly complains about the `else`, but has poor recovery afterward, interpreting the following brace as a closure, which may in turn lead to other unhelpful errors after:
``` java
/Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:32: error: expected '{' after 'if' condition
if source === _nilSentinel else {
^
/Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:37: error: braced block of statements is an unused closure
if source === _nilSentinel else {
^
```
It might be friendlier to recognize this pattern and instead recover as if the `else` wasn't there, or as if there were an empty block before it.
Dmitri
···
On Sat, Sep 10, 2016 at 2:29 PM, Michael Ilseman via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:
You can start with the Starter Bugs on JIRA:
[SR-2605] Cascading failures trying to parse `if <expr> else` · Issue #45210 · apple/swift · GitHub
On Sep 10, 2016, at 1:22 PM, Leonid Kogan via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:
Hi!
Cheers,
_______________________________________________https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
_______________________________________________https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
--