Looking to contribute

Leonid_Kogan · 2016-09-10T20:22:01.000Z

Hi!
I’m looking to contribute to the overall success of this amazing project.
30 years of experience in C, C++, etc…
Can take any small, well defined task, to prove my ability to help out.
Would appreciate any attention to my “offer” :)

Cheers,
LK

Michael_Ilseman · 2016-09-10T21:29:38.000Z

You can start with the Starter Bugs on JIRA:

github.com/apple/swift

[SR-2605] Cascading failures trying to parse `if <expr> else`

opened 11:42PM - 09 Sep 16 UTC

closed 06:52PM - 21 Dec 16 UTC

jckarter

bug parser compiler good first issue diagnostics QoI

| | | |------------------|-----------------|… |Previous ID | SR-2605 | |Radar | None | |Original Reporter | @jckarter | |Type | Bug | |Status | Closed | |Resolution | Done | <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Bug, DiagnosticsQoI, Parser, StarterBug | |Assignee | @modocache | |Priority | Medium | md5: 4700a3a0330dc628a2226b9d21b6eb4b </details> **Issue Description:** If you're refactoring a `guard` into an `if`, it's easy to accidentally end up with invalid code like this in the transition: ``` java if condition else { } ``` The parser rightly complains about the `else`, but has poor recovery afterward, interpreting the following brace as a closure, which may in turn lead to other unhelpful errors after: ``` java /Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:32: error: expected '{' after 'if' condition if source === _nilSentinel else { ^ /Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:37: error: braced block of statements is an unused closure if source === _nilSentinel else { ^ ``` It might be friendlier to recognize this pattern and instead recover as if the `else` wasn't there, or as if there were an empty block before it.

···

On Sep 10, 2016, at 1:22 PM, Leonid Kogan via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Hi!
I’m looking to contribute to the overall success of this amazing project.
30 years of experience in C, C++, etc…
Can take any small, well defined task, to prove my ability to help out.
Would appreciate any attention to my “offer” :)

Cheers,
LK

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

gribozavr · 2016-09-10T21:41:32.000Z

Thanks Leonid, we'd appreciate your help!

Here's a list filtered down to just the open issues:

github.com/apple/swift

[SR-2605] Cascading failures trying to parse `if <expr> else`

opened 11:42PM - 09 Sep 16 UTC

closed 06:52PM - 21 Dec 16 UTC

jckarter

bug parser compiler good first issue diagnostics QoI

| | | |------------------|-----------------|… |Previous ID | SR-2605 | |Radar | None | |Original Reporter | @jckarter | |Type | Bug | |Status | Closed | |Resolution | Done | <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Bug, DiagnosticsQoI, Parser, StarterBug | |Assignee | @modocache | |Priority | Medium | md5: 4700a3a0330dc628a2226b9d21b6eb4b </details> **Issue Description:** If you're refactoring a `guard` into an `if`, it's easy to accidentally end up with invalid code like this in the transition: ``` java if condition else { } ``` The parser rightly complains about the `else`, but has poor recovery afterward, interpreting the following brace as a closure, which may in turn lead to other unhelpful errors after: ``` java /Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:32: error: expected '{' after 'if' condition if source === _nilSentinel else { ^ /Users/jgroff/src/s/swift/stdlib/public/core/Optional.swift:517:37: error: braced block of statements is an unused closure if source === _nilSentinel else { ^ ``` It might be friendlier to recognize this pattern and instead recover as if the `else` wasn't there, or as if there were an empty block before it.

Dmitri

···

On Sat, Sep 10, 2016 at 2:29 PM, Michael Ilseman via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

You can start with the Starter Bugs on JIRA:

[SR-2605] Cascading failures trying to parse `if <expr> else` · Issue #45210 · apple/swift · GitHub

On Sep 10, 2016, at 1:22 PM, Leonid Kogan via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

Hi!
I’m looking to contribute to the overall success of this amazing project.
30 years of experience in C, C++, etc…
Can take any small, well defined task, to prove my ability to help out.
Would appreciate any attention to my “offer” :)

Cheers,
LK

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/