Looking for Feedback on Generic List Implementation

Using Swift
,
1

I've written a simple list in SwiftUI that accepts a generic data type.

The goal was to make a reusable list that could accept any data type and notify an observer when an item in that list was selected.

I struggled with it for a while and have my doubts so I'm keen to get feedback on my implementation.

Any and all feedback / opinions is appreciated.

struct ContentView: View {
    var body: some View {
        VStack {
            BottomSheetView<Test>(options: [Test(name: "hi", type: 7)], selectedOptionsCompletion: {value in})
            BottomSheetView<Test2>(options: [Test2(name: "hi again", type: "7")], selectedOptionsCompletion: {value in})
        }
        .padding()
    }
}

struct BottomSheetView<T: ListItem>: View  {
    var options: [T]
    var selectedOptionsCompletion: ((T.DataType) -> Void)?
    var body: some View {
        VStack(alignment: .leading, spacing: 5) {
            ForEach(options) {item in
                Text(item.name).onTapGesture {
                    let _ = print(type(of: item.type))
                    selectedOptionsCompletion!(item.type)
                }
            }
        }
        .presentationDetents([.medium, .fraction(0.15)])
        .presentationDragIndicator(.hidden)
        .padding()
    }
}

protocol ListItem: Identifiable {
    var id: UUID {get}
    var name: String { get set}
    associatedtype DataType
    var type: DataType { get set}
}
struct Test: ListItem {
    var id: UUID = UUID()
    var name: String
    var type: Int
    init(name: String, type: Int) {
        self.name = name
        self.type = type
    }
}
struct Test2: ListItem {
    var id: UUID = UUID()
    var name: String
    var type: String
    init(name: String, type: String) {
        self.name = name
        self.type = type
    }
}
2

I haven't read the use-case code, I just scrolled down to the protocol itself, but this stuck out to me. Technically, you could satisfy Identifiable with another id of a different type. I assume what you meant by this is protocol ListItem: Identifiable where ID == UUID.

1 Like