Help Needed: SR-1023 - Driver Design Question


(Ryan Lovelett) #1

I've hit a road block in my resolution of SR-1023 [1].

I have a "working" patch in so far as I can now apply my patches to
master and resume compiling. I think my patch for the CMake changes is
largely acceptable (based on feedback of the associated PR [2]).

However, my patch for the driver has not been submitted for review yet
due to the immature nature of the patch. Basically what I did to the
driver is always send some flags to the linker; you can see the actual
patch in the comments of SR-1023 [3].

Ideally these flags should only be sent to the driver if the linker
supports the flags. Does anyone have a suggestion on how such a
conditional should be built?

[1] https://bugs.swift.org/browse/SR-1023
[2] https://github.com/apple/swift/pull/2012
[3]
https://bugs.swift.org/browse/SR-1023?focusedCommentId=13462&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13462