I can see lots of hardcoded symbol strings for name mangling e.g.
i in llib/Demangling/Demangler.cpp, lib/Demangling/Remangler.cpp and so on. there isn’t a header file contains constant value for the symbols, there is a list of mangled name symbols in docs/ABI/Mangling.rst though.
So here is my question.
- Is it better to replace with
static const charconstants?
- Is there any concern like performance issues about string comparison to mangle/demangle?
Because the change might be a big one, I would like to make sure that it’s a right thing to do before diving into more details.