Getting started with lib/Syntax

Yurii_Samsoniuk · 2017-12-06T23:24:16.000Z

I have some spare time and I want to do something for Swift. I’m interested
in lib/Syntax. What can a beginner do? What’s a not too complicated problem
I can solve?

Cheers,
Yura

faical · 2017-12-09T20:55:16.000Z

I’m also interested in this. Anything I can do to help so Swift devs can
focus on more important problems?

Thanks,
Faiçal

···

On Thu, 7 Dec 2017 at 00:24, Yurii Samsoniuk via swift-dev < swift-dev@swift.org> wrote:

I have some spare time and I want to do something for Swift. I’m
interested in lib/Syntax. What can a beginner do? What’s a not too
complicated problem I can solve?

Cheers,
Yura
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Xi_Ge · 2017-12-11T20:26:26.000Z

Hi Yurii and Faiçal,
Currently, we are in the process of extending Swift parser to generate libSyntax entities. A newly specialized libSyntax node will enable detailed client-side analysis/transformation on that node.
Are you interested in helping with this (mostly compiler/parser side change)? If so, please take a look at these two Jira tasks for more details:

github.com/apple/swift

[SR-6571] Specialize ClassDeclSyntax in libSyntax Parsing

opened 07:42PM - 11 Dec 17 UTC

nkcsgexi

compiler task

| | | |------------------|-----------------|… |Previous ID | SR-6571 | |Radar | None | |Original Reporter | @nkcsgexi | |Type | Task | |Status | In Progress | |Resolution | | <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler, Source Tooling | |Labels | Task | |Assignee | ftchirou (JIRA) | |Priority | Medium | md5: 3d9c5dcc06c021c023b1dbb17038a3b7 </details> **Issue Description:** Currently, libSyntax parsing doesn't specialize class declarations, meaning all class declarations are manifested as UnkownDecl. Since libSyntax clients will very likely interested in specialized analysis on classes. We need to teach the parser to specialize them. To demo what we have now: ``` java $cat ~/Desktop/test.swift class C{} func foo() {} $../build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift-syntax-test -input-source-filename ~/Desktop/test.swift -parse-gen -print-node-kind -print-trivial-node-kind <SourceFile><DeclList><TopLevelCodeDecl><StmtList><DeclarationStmt><UnknownDecl>class C{<DeclList></DeclList>}</UnknownDecl></DeclarationStmt><DeclarationStmt><FunctionDecl> func foo<FunctionSignature>(<FunctionParameterList></FunctionParameterList>) </FunctionSignature><CodeBlock>{<StmtList></StmtList>}</CodeBlock></FunctionDecl></DeclarationStmt></StmtList></TopLevelCodeDecl></DeclList> </SourceFile> ``` See that function decl is specialized however class decl is not. The desirable feature will be having class specialized as well. One can follow the patch we specialized struct declaration from: <https://github.com/apple/swift/commit/c4604d700e4d65c0f76df9785d32e338eac54ab8>

github.com/apple/swift

[SR-6572] Specialize ExtensionDeclSyntax in libSyntax Parsing

opened 07:46PM - 11 Dec 17 UTC

closed 04:49PM - 28 Dec 17 UTC

nkcsgexi

parser compiler task † libswiftSyntax extension declarations

| | | |------------------|-----------------|… |Previous ID | SR-6572 | |Radar | None | |Original Reporter | @nkcsgexi | |Type | Task | |Status | Resolved | |Resolution | Done | <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Source Tooling | |Labels | Task | |Assignee | sigito (JIRA) | |Priority | Medium | md5: 0c91fdc7ba3ed9ea78b10c4bea2ed8fd </details> **Issue Description:** Currently, libSyntax parsing doesn't specialize extension declarations, meaning all extension declarations are manifested as UnkownDecl. Since libSyntax clients will very likely interested in specialized analysis on extensions. We need to teach the parser to specialize them. To demo what we have now: ``` java $cat ~/Desktop/test.swift extension C{} func foo() {} $../build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift-syntax-test -input-source-filename ~/Desktop/test.swift -parse-gen -print-node-kind -print-trivial-node-kind <SourceFile><DeclList><TopLevelCodeDecl><StmtList><DeclarationStmt><UnknownDecl>extension <SimpleTypeIdentifier>C</SimpleTypeIdentifier>{<DeclList></DeclList>}</UnknownDecl></DeclarationStmt><DeclarationStmt><FunctionDecl> func foo<FunctionSignature>(<FunctionParameterList></FunctionParameterList>) </FunctionSignature><CodeBlock>{<StmtList></StmtList>}</CodeBlock></FunctionDecl></DeclarationStmt></StmtList></TopLevelCodeDecl></DeclList> </SourceFile> ``` See that the function decl is specialized however the extension decl is not. The desirable feature will be having extension decls specialized as well. One can follow the patch we specialized struct declaration from: <https://github.com/apple/swift/commit/c4604d700e4d65c0f76df9785d32e338eac54ab8>

Please let us know if you're interested in implementing one of them.

cheers
Xi

···

On Dec 9, 2017, at 12:55 PM, Faiçal Tchirou via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

I’m also interested in this. Anything I can do to help so Swift devs can focus on more important problems?

Thanks,
Faiçal
On Thu, 7 Dec 2017 at 00:24, Yurii Samsoniuk via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
I have some spare time and I want to do something for Swift. I’m interested in lib/Syntax. What can a beginner do? What’s a not too complicated problem I can solve?

Cheers,
Yura
_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev
_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

faical · 2017-12-11T20:45:26.000Z

Hi Xi,

I would be interested in SR-6571.

Thanks,
Faiçal

···

On Mon, 11 Dec 2017 at 21:26, Xi Ge <xi_ge@apple.com> wrote:

Hi Yurii and Faiçal,
Currently, we are in the process of extending Swift parser to generate
libSyntax entities. A newly specialized libSyntax node will enable detailed
client-side analysis/transformation on that node.
Are you interested in helping with this (mostly compiler/parser side
change)? If so, please take a look at these two Jira tasks for more details:

[SR-6571] Specialize ClassDeclSyntax in libSyntax Parsing · Issue #49121 · apple/swift · GitHub
[SR-6572] Specialize ExtensionDeclSyntax in libSyntax Parsing · Issue #49122 · apple/swift · GitHub

Please let us know if you're interested in implementing one of them.

cheers
Xi

On Dec 9, 2017, at 12:55 PM, Faiçal Tchirou via swift-dev < > swift-dev@swift.org> wrote:

I’m also interested in this. Anything I can do to help so Swift devs can
focus on more important problems?

Thanks,
Faiçal
On Thu, 7 Dec 2017 at 00:24, Yurii Samsoniuk via swift-dev < > swift-dev@swift.org> wrote:

I have some spare time and I want to do something for Swift. I’m
interested in lib/Syntax. What can a beginner do? What’s a not too
complicated problem I can solve?

Cheers,
Yura
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Xi_Ge · 2017-12-11T21:10:30.000Z

Great to hear that! Please feel free to self-assign this task.

Xi

···

On Dec 11, 2017, at 12:45 PM, Faiçal Tchirou <ftchirou@gmail.com> wrote:

Hi Xi,

I would be interested in SR-6571.

Thanks,
Faiçal

On Mon, 11 Dec 2017 at 21:26, Xi Ge <xi_ge@apple.com> wrote:
Hi Yurii and Faiçal,
Currently, we are in the process of extending Swift parser to generate libSyntax entities. A newly specialized libSyntax node will enable detailed client-side analysis/transformation on that node.
Are you interested in helping with this (mostly compiler/parser side change)? If so, please take a look at these two Jira tasks for more details:

[SR-6571] Specialize ClassDeclSyntax in libSyntax Parsing · Issue #49121 · apple/swift · GitHub
[SR-6572] Specialize ExtensionDeclSyntax in libSyntax Parsing · Issue #49122 · apple/swift · GitHub

Please let us know if you're interested in implementing one of them.

cheers
Xi

On Dec 9, 2017, at 12:55 PM, Faiçal Tchirou via swift-dev <swift-dev@swift.org> wrote:

I’m also interested in this. Anything I can do to help so Swift devs can focus on more important problems?

Thanks,
Faiçal

On Thu, 7 Dec 2017 at 00:24, Yurii Samsoniuk via swift-dev <swift-dev@swift.org> wrote:
I have some spare time and I want to do something for Swift. I’m interested in lib/Syntax. What can a beginner do? What’s a not too complicated problem I can solve?

Cheers,
Yura
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Yurii_Samsoniuk · 2017-12-12T17:01:25.000Z

Hi Xi,

Thanks for your reply. I'll grab another bug then.

Cheers,
Yura

···

пн, 11 груд. 2017 о 22:10 Xi Ge <xi_ge@apple.com> пише:

Great to hear that! Please feel free to self-assign this task.

Xi

On Dec 11, 2017, at 12:45 PM, Faiçal Tchirou <ftchirou@gmail.com> wrote:

Hi Xi,

I would be interested in SR-6571.

Thanks,
Faiçal
On Mon, 11 Dec 2017 at 21:26, Xi Ge <xi_ge@apple.com> wrote:

Hi Yurii and Faiçal,
Currently, we are in the process of extending Swift parser to generate
libSyntax entities. A newly specialized libSyntax node will enable detailed
client-side analysis/transformation on that node.
Are you interested in helping with this (mostly compiler/parser side
change)? If so, please take a look at these two Jira tasks for more details:

[SR-6571] Specialize ClassDeclSyntax in libSyntax Parsing · Issue #49121 · apple/swift · GitHub
[SR-6572] Specialize ExtensionDeclSyntax in libSyntax Parsing · Issue #49122 · apple/swift · GitHub

Please let us know if you're interested in implementing one of them.

cheers
Xi

On Dec 9, 2017, at 12:55 PM, Faiçal Tchirou via swift-dev < >> swift-dev@swift.org> wrote:

I’m also interested in this. Anything I can do to help so Swift devs can
focus on more important problems?

Thanks,
Faiçal
On Thu, 7 Dec 2017 at 00:24, Yurii Samsoniuk via swift-dev < >> swift-dev@swift.org> wrote:

I have some spare time and I want to do something for Swift. I’m
interested in lib/Syntax. What can a beginner do? What’s a not too
complicated problem I can solve?

Cheers,
Yura
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

xfbs · 2018-02-12T23:30:25.371Z

Hey Xi,

I'm pretty sure this isn't the right place to ask but, where and how do I apply for the GSoC swift-format tool implementation? I'm super interested in that, I've had a lot of good experiences with clang-format but never got the change to implement a proper formatting tool apart from a little markdown formatter I built on top of someone else's parser. :)

Cheers, Patrick

saagarjha · 2018-02-12T23:37:25.720Z

From the Project Ideas page:

Check out the Development forum to connect with potential mentors.

So I'd say you're in the right place!