Failed to build OS X toolchain package broken due to commit b08610b


(Mishal Shah) #1

Hi,

Can you please look at this failure, it might be related to this commit:
https://github.com/apple/swift/commit/b08610bc3e4acfc2842349e4e661a38b93d4dd27

Error:

The Swift LLDB build does not support build variant RelWithDebInfo
Please select one of the following variants: Debug, Release

Please try build it with:

swift/utils/build-script --preset=buildbot_osx_package

Thanks,
Mishal Shah


(Dmitri Gribenko) #2

+Todd

···

On Thu, Dec 3, 2015 at 8:46 PM, Mishal Shah <shahmishal@gmail.com> wrote:

Hi,

Can you please look at this failure, it might be related to this commit:
https://github.com/apple/swift/commit/b08610bc3e4acfc2842349e4e661a38b93d4dd27

Error:

The Swift LLDB build does not support build variant RelWithDebInfo
Please select one of the following variants: Debug, Release

Please try build it with:

swift/utils/build-script --preset=buildbot_osx_package

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Todd Fiala) #3

I’ll have a look.

-Todd

···

On Dec 3, 2015, at 8:48 PM, Dmitri Gribenko <gribozavr@gmail.com> wrote:

On Thu, Dec 3, 2015 at 8:46 PM, Mishal Shah <shahmishal@gmail.com <mailto:shahmishal@gmail.com>> wrote:
Hi,

Can you please look at this failure, it might be related to this commit: https://github.com/apple/swift/commit/b08610bc3e4acfc2842349e4e661a38b93d4dd27

Error:
The Swift LLDB build does not support build variant RelWithDebInfo
Please select one of the following variants: Debug, Release

Please try build it with:
swift/utils/build-script --preset=buildbot_osx_package

+Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>>*/


(Todd Fiala) #4

I’m seeing this:

swift/utils/build-script --preset=buildbot_osx_package
Traceback (most recent call last):
  File "swift/utils/build-script", line 767, in <module>
    sys.exit(main())
  File "swift/utils/build-script", line 761, in main
    return main_preset()
  File "swift/utils/build-script", line 77, in main_preset
    args.preset_substitutions, args.preset_file_names, args.preset)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py", line 169, in get_preset_options
    _get_preset_options_impl(config, substitutions, preset_name)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py", line 137, in _get_preset_options_impl
    for o, a in config.items(section_name):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 655, in items
    for option in options]
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 691, in _interpolate
    self._interpolate_some(option, L, rawval, section, vars, 1)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py", line 723, in _interpolate_some
    option, section, rest, var)
ConfigParser.InterpolationMissingOptionError: Bad value substitution:
        section: [preset: buildbot_osx_package]
        option : installable-package
        key : installable_package
        rawval :

Is that what you’re seeing?

Am I maybe missing some kind of preset package file?

···

On Dec 3, 2015, at 10:22 PM, Todd Fiala <tfiala@apple.com> wrote:

I’ll have a look.

-Todd

On Dec 3, 2015, at 8:48 PM, Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>> wrote:

On Thu, Dec 3, 2015 at 8:46 PM, Mishal Shah <shahmishal@gmail.com <mailto:shahmishal@gmail.com>> wrote:
Hi,

Can you please look at this failure, it might be related to this commit: https://github.com/apple/swift/commit/b08610bc3e4acfc2842349e4e661a38b93d4dd27

Error:
The Swift LLDB build does not support build variant RelWithDebInfo
Please select one of the following variants: Debug, Release

Please try build it with:
swift/utils/build-script --preset=buildbot_osx_package

+Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>>*/

_______________________________________________
swift-lldb-dev mailing list
swift-lldb-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-lldb-dev


(Dmitri Gribenko) #5

You also need to pass the "installable_package" command line parameter (and
some other ones that it will complain about later).

swift/utils/build-script --preset=buildbot_osx_package
installable_package=/tmp/swift.tar.gz

Dmitri

···

On Thu, Dec 3, 2015 at 10:32 PM, Todd Fiala <tfiala@apple.com> wrote:

I’m seeing this:

swift/utils/build-script --preset=buildbot_osx_package
Traceback (most recent call last):
  File "swift/utils/build-script", line 767, in <module>
    sys.exit(main())
  File "swift/utils/build-script", line 761, in main
    return main_preset()
  File "swift/utils/build-script", line 77, in main_preset
    args.preset_substitutions, args.preset_file_names, args.preset)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py",
line 169, in get_preset_options
    _get_preset_options_impl(config, substitutions, preset_name)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py",
line 137, in _get_preset_options_impl
    for o, a in config.items(section_name):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 655, in items
    for option in options]
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 691, in _interpolate
    self._interpolate_some(option, L, rawval, section, vars, 1)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 723, in _interpolate_some
    option, section, rest, var)
ConfigParser.InterpolationMissingOptionError: Bad value substitution:
        section: [preset: buildbot_osx_package]
        option : installable-package
        key : installable_package
        rawval :

Is that what you’re seeing?

Am I maybe missing some kind of preset package file?

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Todd Fiala) #6

I see.

And I think I see the issue. It's trying to do a release-debuginfo build
across the board. LLDB chokes on those. So we'll need to explicitly set
the lldb build variant to something different (either release or debug,
likely release).

Looking at this more now.

···

On Thu, Dec 3, 2015 at 10:36 PM, Dmitri Gribenko <gribozavr@gmail.com> wrote:

On Thu, Dec 3, 2015 at 10:32 PM, Todd Fiala <tfiala@apple.com> wrote:

I’m seeing this:

swift/utils/build-script --preset=buildbot_osx_package
Traceback (most recent call last):
  File "swift/utils/build-script", line 767, in <module>
    sys.exit(main())
  File "swift/utils/build-script", line 761, in main
    return main_preset()
  File "swift/utils/build-script", line 77, in main_preset
    args.preset_substitutions, args.preset_file_names, args.preset)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py",
line 169, in get_preset_options
    _get_preset_options_impl(config, substitutions, preset_name)
  File "/Users/tfiala/work/lldb-github/swift/utils/SwiftBuildSupport.py",
line 137, in _get_preset_options_impl
    for o, a in config.items(section_name):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 655, in items
    for option in options]
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 691, in _interpolate
    self._interpolate_some(option, L, rawval, section, vars, 1)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ConfigParser.py",
line 723, in _interpolate_some
    option, section, rest, var)
ConfigParser.InterpolationMissingOptionError: Bad value substitution:
        section: [preset: buildbot_osx_package]
        option : installable-package
        key : installable_package
        rawval :

Is that what you’re seeing?

Am I maybe missing some kind of preset package file?

You also need to pass the "installable_package" command line parameter
(and some other ones that it will complain about later).

swift/utils/build-script --preset=buildbot_osx_package
installable_package=/tmp/swift.tar.gz

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd


(Dmitri Gribenko) #7

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

···

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

I see.

And I think I see the issue. It's trying to do a release-debuginfo build
across the board. LLDB chokes on those. So we'll need to explicitly set
the lldb build variant to something different (either release or debug,
likely release).

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Todd Fiala) #8

Yep I finally added enough gunk to the command line to reproduce.

I'm looking at how it's getting the Release value now. That's the issue
(I'm not seeing it come in as Release).

···

On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> wrote:

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> wrote:
> I see.
>
> And I think I see the issue. It's trying to do a release-debuginfo build
> across the board. LLDB chokes on those. So we'll need to explicitly set
> the lldb build variant to something different (either release or debug,
> likely release).

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd


(Todd Fiala) #9

Okay I think I see the issue. It is that we can still pass backdoor
combinations of build modes after the '--' in build-script that will
control the final build variant used by lldb.

The logic for this check doesn't belong in build-script, but rather
build-script-impl. build-script-impl is the only place to find the final
build mode after considering both the values passed to build-script, and
other bits that can be passed along to build-script-impl.

I'm going to revert my change and add a proper fix in the morning. I don't
have enough brain power to do it right and test it now.

···

On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Yep I finally added enough gunk to the command line to reproduce.

I'm looking at how it's getting the Release value now. That's the issue
(I'm not seeing it come in as Release).

On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> > wrote:

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> wrote:
> I see.
>
> And I think I see the issue. It's trying to do a release-debuginfo
build
> across the board. LLDB chokes on those. So we'll need to explicitly
set
> the lldb build variant to something different (either release or debug,
> likely release).

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd

--
-Todd


(Todd Fiala) #10

Mishal,

Reverted here:

commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
origin/master, origin/HEAD)
Author: Todd Fiala <tfiala@apple.com>

You should be back in business.

I'll re-introduce this change a more appropriate way in the morning.

-Todd

···

Date: Thu Dec 3 22:57:16 2015

On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Okay I think I see the issue. It is that we can still pass backdoor
combinations of build modes after the '--' in build-script that will
control the final build variant used by lldb.

The logic for this check doesn't belong in build-script, but rather
build-script-impl. build-script-impl is the only place to find the final
build mode after considering both the values passed to build-script, and
other bits that can be passed along to build-script-impl.

I'm going to revert my change and add a proper fix in the morning. I
don't have enough brain power to do it right and test it now.

On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Yep I finally added enough gunk to the command line to reproduce.

I'm looking at how it's getting the Release value now. That's the issue
(I'm not seeing it come in as Release).

On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> >> wrote:

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> >>> wrote:
> I see.
>
> And I think I see the issue. It's trying to do a release-debuginfo
build
> across the board. LLDB chokes on those. So we'll need to explicitly
set
> the lldb build variant to something different (either release or debug,
> likely release).

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd

--
-Todd

--
-Todd


(Dmitri Gribenko) #11

Thanks, Todd!

···

On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Mishal,

Reverted here:

commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
origin/master, origin/HEAD)
Author: Todd Fiala <tfiala@apple.com>
Date: Thu Dec 3 22:57:16 2015

You should be back in business.

I'll re-introduce this change a more appropriate way in the morning.

-Todd

On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Okay I think I see the issue. It is that we can still pass backdoor
combinations of build modes after the '--' in build-script that will control
the final build variant used by lldb.

The logic for this check doesn't belong in build-script, but rather
build-script-impl. build-script-impl is the only place to find the final
build mode after considering both the values passed to build-script, and
other bits that can be passed along to build-script-impl.

I'm going to revert my change and add a proper fix in the morning. I
don't have enough brain power to do it right and test it now.

On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Yep I finally added enough gunk to the command line to reproduce.

I'm looking at how it's getting the Release value now. That's the issue
(I'm not seeing it come in as Release).

On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> >>> wrote:

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> >>>> wrote:
> I see.
>
> And I think I see the issue. It's trying to do a release-debuginfo
> build
> across the board. LLDB chokes on those. So we'll need to explicitly
> set
> the lldb build variant to something different (either release or
> debug,
> likely release).

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd

--
-Todd

--
-Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/


(Todd Fiala) #12

Oops looks like I lost you on the To line, Mishal. See thread.

···

On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Mishal,

Reverted here:

commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
origin/master, origin/HEAD)
Author: Todd Fiala <tfiala@apple.com>
Date: Thu Dec 3 22:57:16 2015

You should be back in business.

I'll re-introduce this change a more appropriate way in the morning.

-Todd

On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Okay I think I see the issue. It is that we can still pass backdoor
combinations of build modes after the '--' in build-script that will
control the final build variant used by lldb.

The logic for this check doesn't belong in build-script, but rather
build-script-impl. build-script-impl is the only place to find the final
build mode after considering both the values passed to build-script, and
other bits that can be passed along to build-script-impl.

I'm going to revert my change and add a proper fix in the morning. I
don't have enough brain power to do it right and test it now.

On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Yep I finally added enough gunk to the command line to reproduce.

I'm looking at how it's getting the Release value now. That's the issue
(I'm not seeing it come in as Release).

On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> >>> wrote:

On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> >>>> wrote:
> I see.
>
> And I think I see the issue. It's trying to do a release-debuginfo
build
> across the board. LLDB chokes on those. So we'll need to explicitly
set
> the lldb build variant to something different (either release or
debug,
> likely release).

The preset is trying to do that (lldb-build-type=Release), but
apparently is getting ignored.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd

--
-Todd

--
-Todd

--
-Todd


(Todd Fiala) #13

Sure thing, sorry for the bother.

···

On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <gribozavr@gmail.com> wrote:

Thanks, Todd!

On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <todd.fiala@gmail.com> wrote:
> Mishal,
>
> Reverted here:
>
> commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Todd Fiala <tfiala@apple.com>
> Date: Thu Dec 3 22:57:16 2015
>
>
> You should be back in business.
>
> I'll re-introduce this change a more appropriate way in the morning.
>
> -Todd
>
>
> On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com> > wrote:
>>
>> Okay I think I see the issue. It is that we can still pass backdoor
>> combinations of build modes after the '--' in build-script that will
control
>> the final build variant used by lldb.
>>
>> The logic for this check doesn't belong in build-script, but rather
>> build-script-impl. build-script-impl is the only place to find the
final
>> build mode after considering both the values passed to build-script, and
>> other bits that can be passed along to build-script-impl.
>>
>> I'm going to revert my change and add a proper fix in the morning. I
>> don't have enough brain power to do it right and test it now.
>>
>> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> > wrote:
>>>
>>> Yep I finally added enough gunk to the command line to reproduce.
>>>
>>> I'm looking at how it's getting the Release value now. That's the
issue
>>> (I'm not seeing it come in as Release).
>>>
>>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com> > >>> wrote:
>>>>
>>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> > >>>> wrote:
>>>> > I see.
>>>> >
>>>> > And I think I see the issue. It's trying to do a release-debuginfo
>>>> > build
>>>> > across the board. LLDB chokes on those. So we'll need to
explicitly
>>>> > set
>>>> > the lldb build variant to something different (either release or
>>>> > debug,
>>>> > likely release).
>>>>
>>>> The preset is trying to do that (lldb-build-type=Release), but
>>>> apparently is getting ignored.
>>>>
>>>> Dmitri
>>>>
>>>> --
>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/
>>>
>>>
>>>
>>>
>>> --
>>> -Todd
>>
>>
>>
>>
>> --
>> -Todd
>
>
>
>
> --
> -Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd


(Mishal Shah) #14

Thanks!

Complete command:

swift/utils/build-script --preset=buildbot_osx_package
install_destdir=/tmp/swift-install
installable_package=/tmp/swift.tar.gz
install_toolchain_dir=/Applications/Xcode.app/Contents/Developer/Toolchains/swift.xctoolchain
install_symroot=/tmp/swift-symroot
symbols_package=/tmp/swift-symbols.tar.gz
darwin_toolchain_bundle_identifier=com.test.x
'darwin_toolchain_display_name=test'
darwin_toolchain_xctoolchain_name=swift darwin_toolchain_version=swift

Mishal Shah

···

On Thu, Dec 3, 2015 at 11:01 PM, Todd Fiala <todd.fiala@gmail.com> wrote:

Sure thing, sorry for the bother.

On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <gribozavr@gmail.com> > wrote:

Thanks, Todd!

On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <todd.fiala@gmail.com> wrote:
> Mishal,
>
> Reverted here:
>
> commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Todd Fiala <tfiala@apple.com>
> Date: Thu Dec 3 22:57:16 2015
>
>
> You should be back in business.
>
> I'll re-introduce this change a more appropriate way in the morning.
>
> -Todd
>
>
> On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com> >> wrote:
>>
>> Okay I think I see the issue. It is that we can still pass backdoor
>> combinations of build modes after the '--' in build-script that will
control
>> the final build variant used by lldb.
>>
>> The logic for this check doesn't belong in build-script, but rather
>> build-script-impl. build-script-impl is the only place to find the
final
>> build mode after considering both the values passed to build-script,
and
>> other bits that can be passed along to build-script-impl.
>>
>> I'm going to revert my change and add a proper fix in the morning. I
>> don't have enough brain power to do it right and test it now.
>>
>> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com> >> wrote:
>>>
>>> Yep I finally added enough gunk to the command line to reproduce.
>>>
>>> I'm looking at how it's getting the Release value now. That's the
issue
>>> (I'm not seeing it come in as Release).
>>>
>>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com >> > >> >>> wrote:
>>>>
>>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com> >> >>>> wrote:
>>>> > I see.
>>>> >
>>>> > And I think I see the issue. It's trying to do a release-debuginfo
>>>> > build
>>>> > across the board. LLDB chokes on those. So we'll need to
explicitly
>>>> > set
>>>> > the lldb build variant to something different (either release or
>>>> > debug,
>>>> > likely release).
>>>>
>>>> The preset is trying to do that (lldb-build-type=Release), but
>>>> apparently is getting ignored.
>>>>
>>>> Dmitri
>>>>
>>>> --
>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/
>>>
>>>
>>>
>>>
>>> --
>>> -Todd
>>
>>
>>
>>
>> --
>> -Todd
>
>
>
>
> --
> -Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com>*/

--
-Todd


(Todd Fiala) #15

Okay cool. I’ll use that later today when I work on the original task in a way that doesn’t break this usage.

-Todd

···

On Dec 4, 2015, at 12:09 AM, Mishal Shah <shahmishal@gmail.com> wrote:

Thanks!

Complete command:

swift/utils/build-script --preset=buildbot_osx_package install_destdir=/tmp/swift-install installable_package=/tmp/swift.tar.gz install_toolchain_dir=/Applications/Xcode.app/Contents/Developer/Toolchains/swift.xctoolchain install_symroot=/tmp/swift-symroot symbols_package=/tmp/swift-symbols.tar.gz darwin_toolchain_bundle_identifier=com.test.x 'darwin_toolchain_display_name=test' darwin_toolchain_xctoolchain_name=swift darwin_toolchain_version=swift

Mishal Shah

On Thu, Dec 3, 2015 at 11:01 PM, Todd Fiala <todd.fiala@gmail.com <mailto:todd.fiala@gmail.com>> wrote:
Sure thing, sorry for the bother.

On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>> wrote:
Thanks, Todd!

On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <todd.fiala@gmail.com <mailto:todd.fiala@gmail.com>> wrote:
> Mishal,
>
> Reverted here:
>
> commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Todd Fiala <tfiala@apple.com <mailto:tfiala@apple.com>>
> Date: Thu Dec 3 22:57:16 2015
>
>
> You should be back in business.
>
> I'll re-introduce this change a more appropriate way in the morning.
>
> -Todd
>
>
> On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <todd.fiala@gmail.com <mailto:todd.fiala@gmail.com>> wrote:
>>
>> Okay I think I see the issue. It is that we can still pass backdoor
>> combinations of build modes after the '--' in build-script that will control
>> the final build variant used by lldb.
>>
>> The logic for this check doesn't belong in build-script, but rather
>> build-script-impl. build-script-impl is the only place to find the final
>> build mode after considering both the values passed to build-script, and
>> other bits that can be passed along to build-script-impl.
>>
>> I'm going to revert my change and add a proper fix in the morning. I
>> don't have enough brain power to do it right and test it now.
>>
>> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <todd.fiala@gmail.com <mailto:todd.fiala@gmail.com>> wrote:
>>>
>>> Yep I finally added enough gunk to the command line to reproduce.
>>>
>>> I'm looking at how it's getting the Release value now. That's the issue
>>> (I'm not seeing it come in as Release).
>>>
>>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>> > >>> wrote:
>>>>
>>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <todd.fiala@gmail.com <mailto:todd.fiala@gmail.com>> > >>>> wrote:
>>>> > I see.
>>>> >
>>>> > And I think I see the issue. It's trying to do a release-debuginfo
>>>> > build
>>>> > across the board. LLDB chokes on those. So we'll need to explicitly
>>>> > set
>>>> > the lldb build variant to something different (either release or
>>>> > debug,
>>>> > likely release).
>>>>
>>>> The preset is trying to do that (lldb-build-type=Release), but
>>>> apparently is getting ignored.
>>>>
>>>> Dmitri
>>>>
>>>> --
>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>>*/
>>>
>>>
>>>
>>>
>>> --
>>> -Todd
>>
>>
>>
>>
>> --
>> -Todd
>
>
>
>
> --
> -Todd

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr@gmail.com <mailto:gribozavr@gmail.com>>*/

--
-Todd