[XCTest] 2016-02-03 snapshot output

Brian_Gesiak · February 5, 2016, 3:17pm

Hello all!

The swift-DEVELOPMENT-SNAPSHOT-2016-02-03-a snapshot of
swift-corelibs-xctest has some wonky output, described here:

github.com/apple/swift-corelibs-xctest

[XCTestMain] Don't XCTPrint arrays of strings

apple:master ← modocache:xctprint-test-failures

opened 04:01AM - 04 Feb 16 UTC

modocache

+2 -2

`XCTPrint()` takes a variadic argument of items to print, mirroring the API of `…print()` itself. Unfortunately, passing this variadic argument directly to `print()` causes an array object to be printed. For example: ``` swift func XCTPrint(items: Any...) { print(items) } XCTPrint("Hello!") // Prints '["Hello!"]\n' ``` As a result of this behavior, swift-corelibs-xctest currently prints out test output such as the following: ``` ["Test Case \'ErrorHandling.test_shouldButDoesNotThrowErrorInAssertion\' failed (0.0 seconds)."] ["Test Case \'ErrorHandling.test_shouldThrowErrorInAssertion\' started."] ``` This is different from the expected output in `Tests/Functional`, which is causing the test suite to fail. Instead of mirroring the `print()` API, have `XCTPrint()` simply take a string object to print. This has the added benefit of being simpler--we can add the variadic arguments and the line separator parameter back if we ever need them. The test suite passes with this change. --- On a related note: 1. Would it be possible to have Apple CI cover this repository as well? I'd love to be able to ask @swift-ci to "please test"! 2. I'm still trying to find time to add these tests to the Swift validation-test suite. I'd love it if someone beat me to it! :wink:

From what I understand, snapshots don't represent a "release", so they're

not expected to be perfect. Still, just a heads up in case we see some
emails about the output from users of the 02-03 snapshot.

As I mention in that pull request, I'd like to incorporate
swift-corelibs-xctest tests into the Swift validation-test suite (
[build_script] Use built XCTest for Linux tests by modocache · Pull Request #46 · apple/swift-corelibs-xctest · GitHub helps in that
regard). That should prevent test failures like this one from going
unnoticed for very long in the future.

- Brian Gesiak