The tests look great and exhaustive to me. I just wish to mention here that we’ve experienced hangs in CI tests while connecting to some external URLs in the past (you can see a few tests commented out in the current TestNSURLSession for that reason). It was then recommended, by Tony, that we have a loopback server to test URLSession. Having said that, I can’t be sure that the httpbin urls, that you use, will cause the same issues
Also, it’d be great if you could file JIRA reports/PRs for the failures you see. Thanks!
Pushkar N Kulkarni,
Simplicity is prerequisite for reliability - Edsger W. Dijkstra
I was looking for a way to contribute, and I ran into a URLSession issue, so I started fleshing out the test module for it:
It doesn’t cover all of the API yet, but it does trap a bunch of issues. But it’s my first time contributing to a large, public project so I’m a bit nervous about ploughing ahead with it… is there any chance someone could take a quick look and let me know if I’m on the right track, or need to fundamentally change or scrap it?
Also, I’m not sure about the etiquette of submitting failing tests (of which there are quite a few )
swift-corelibs-dev mailing list
To: swift-corelibs-dev email@example.com
From: Mike Ferenduros via swift-corelibs-dev
Sent by: firstname.lastname@example.org
Date: 09/17/2016 05:34PM
Subject: [swift-corelibs-dev] URLSession tests
-----email@example.com wrote: -----