Unused parameter in `Ninja.new_builder`

RemiBardon · 2023-07-13T15:03:38.388Z

Hello,

I was trying to understand how utils/build-script's --host-target option was used, and I realized that at some point it is passed to Ninja.new_builder, which does nothing with the value:

github.com

apple/swift/blob/1cf3b64e22bf46f0477454ce894a37626ef048ce/utils/swift_build_support/swift_build_support/build_script_invocation.py#L65-L70


      
          ninja_build = products.Ninja.new_builder(
              args=self.args,
              toolchain=self.toolchain,
              workspace=self.workspace,
              host=StdlibDeploymentTarget.get_target_for_name(
                  self.args.host_target))

github.com

apple/swift/blob/1cf3b64e22bf46f0477454ce894a37626ef048ce/utils/swift_build_support/swift_build_support/products/ninja.py#L37-L39


      
          @classmethod
          def new_builder(cls, args, toolchain, workspace, host):
              return NinjaBuilder(cls, args, toolchain, workspace)

Is it intended? I wonder if it works correctly then (I'm about to try)