SwiftPM Platform conditional target dependancy not resolved for tvOS

AndreyGusev · 2022-04-15T08:59:44.811Z

Hi,

I have some target that conditionally links other tvOS-specific and iOS-specific targets.
When building for iOS all goes well, but when I try to build for tvOS - build fails due to not available APIs for tvOS in iOS-specific-target being built...

     .target(
            name: "SomeTarget",
            dependencies: [
                "Common-Target",

                .target(name: "iOS-specific-target", condition: .when(platforms: [.iOS])),                
                .target(name: "TV-Specific-target", condition: .when(platforms: [.tvOS]))
            ],
        )

What am I doing wrong?

AndreyGusev · 2022-04-15T12:01:07.552Z

Found some bugs:

github.com/apple/swift-package-manager

[SR-15589] Conditional target dependencies not working as expected in Package.swift

opened 04:54PM - 13 Dec 21 UTC

swift-ci

bug

| | | |------------------|-----------------|… |Previous ID | SR-15589 | |Radar | None | |Original Reporter | Cameron (JIRA User) | |Type | Bug | <details> <summary>Environment</summary> macOS 12.0.1, Xcode 13.2 (13C90) macOS 12.3, Xcode 13.3 (13E113) </details> <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 1 | |Component/s | Package Manager | |Labels | Bug | |Assignee | None | |Priority | Medium | md5: 1d817448ccceb0cac34d0ba118636b94 </details> **Issue Description:** I am working on a library for iOS and macOS platforms. When on iOS, I'd like to include a specific, iOS only, dependency. I am using conditional target dependencies to achieve this: ``` java import PackageDescription let package = Package( name: "MyLibrary", products: [ .library(name: "MyLibrary", targets: ["MyLibrary"]) ], dependencies: [ .package(name: "Embrace", url: "https://github.com/embrace-io/embrace-spm", from: "5.7.0") ], targets: [ .target( name: "MyLibrary", dependencies: [ .product(name: "Embrace", package: "Embrace", condition: .when(platforms: [.iOS])) ] ) ] ) ``` However, when I compile on a macOS target, I get the following error which feels incorrect to me: /Users/cbp/Library/Developer/Xcode/DerivedData/MyLibrary-hbfrabjxsrphnbbioeeyckityvdv/SourcePackages/checkouts/embrace-spm/Embrace.xcframework:1:1: While building for macOS, no library for this platform was found in '/Users/cbp/Library/Developer/Xcode/DerivedData/MyLibrary-hbfrabjxsrphnbbioeeyckityvdv/SourcePackages/checkouts/embrace-spm/Embrace.xcframework'. It's true that the Embrace library does not have a macOS version, but I had figured my `condition: .when(platforms: [.iOS])` would work around that.

github.com/apple/swift-package-manager

[SR-15836] Platform Conditionals Don't Apply To Binary Frameworks

opened 03:47AM - 08 Feb 22 UTC

closed 01:33PM - 08 Feb 22 UTC

swift-ci

bug

| | | |------------------|-----------------|… |Previous ID | SR-15836 | |Radar | None | |Original Reporter | brianmichel (JIRA User) | |Type | Bug | |Status | Resolved | |Resolution | Duplicate | Attachment: [Download](https://user-images.githubusercontent.com/2727770/164964453-6b36ba99-5cb9-46a5-b5a2-424f7a672681.gz) <details> <summary>Environment</summary> Xcode Version: 13.2.1 (13C100) macOS Version: 12.2 Beta (21D5025f) Swift Version: swift-driver version: 1.26.21 Apple Swift version 5.5.2 (swiftlang-1300.0.47.5 clang-1300.0.29.30) Swift Tools Version: 5.5 </details> <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Package Manager | |Labels | Bug | |Assignee | None | |Priority | Medium | md5: e6abd67669234948227721b2e8fd18e3 </details> **duplicates**: * [SR-15196](https://bugs.swift.org/browse/SR-15196) Binary target required for compilation despite being a conditional dependency **Issue Description:** When attempting to use a platform conditional with a binary framework the conditional doesn't seem to actually apply. There is also an active thread in the forums calling attention to the issue <https://forums.swift.org/t/adding-platform-specific-dependency-to-multi-platform-swift-package/49645/7> **Steps To Reproduce** 1\. Clone <https://github.com/brianmichel/Marconio/tree/feature/modularize-everything> 2\. Switch scheme to "AppDelegate" 3\. Select any iOS simulator or device from the target device list 4\. Build **Expected Result** I expect the library to build as the Sparkle dependency is marked as conditional to macOS. **Actual Result** The library does not build correctly as it seems that there needs to be an iOS version of the framework. I've also attached the build log from the command line from running the following command, please let me know if there's something else I should be running, but from what I can tell the command line build *is* completing successfully. ``` java swift build --target AppDelegate -v \ -Xswiftc "-sdk" \ -Xswiftc "`xcrun --sdk iphonesimulator --show-sdk-path`" \ -Xswiftc "-target" \ -Xswiftc "x86_64-apple-ios15.0-simulator" ```

And that post:

Possible bug for Conditional Target Dependencies Package Manager

Hello all, I don't know if I'm doing something wrong or if it's a bug regarding SE-0273 I have a project that uses the MSAL framework which is iOS only. I created a wrapper that offers the full functionality on iOS and a limited subset on WatchOS, however I can't get the project building for the Watch because MSAL doesn't build for it. I tried to conditionally depend on MSAL only on iOS, but I still get errors on build saying "While building for watchOS, no library for this platform was found …

With StackOverflow too:

stackoverflow.com

SwiftUI Preview incorrectly tries to build conditional dependency from another platform

ios, xcode, macos, swiftui

asked by msmialko on 08:37AM - 03 Mar 22 UTC

SDGGiesbrecht · 2022-04-15T22:06:38.174Z

So is it a binary dependency in your case? Or do we need to keep debugging?

msmialko · 2022-04-16T19:49:03.292Z

Yo, I'm the guy from the mentioned StackOverflow thread.
Not a binary dependency in my case.
Here's a sample project that demonstrates the issue: GitHub - Moriquendi/bug-conditional-dependency
Run a SwiftUI preview on a macOS target - it won't work.
(Radar: FB9940620)

SDGGiesbrecht · 2022-04-16T20:37:42.234Z

The Xcode project has no tvOS scheme, but I just built Packages/Components for tvOS without any issues (with Xcode 13.3.1):

Screen Shot 2022-04-16 at 14.36.12860×436 72.4 KB

msmialko · 2022-04-17T12:52:11.952Z

My sample project demonstrates the issue for macOS + iOS, but I'm sure it's the same issue that Andrey has with tvOS.

To clarify - the app / package does build ok for me too. The build only fails when you try to run SwiftUI Previews.

Steps to reproduce:

Select "PreviewTests" scheme, target macOS
Open ContentView
Try running SwiftUI Preview.

I'm attaching a screenshot that shows the issue. You can see it fails because it cannot find UIKit when building iOS-only dependency.

Screenshot 2022-04-17 at 14.46.172220×548 101 KB

Screenshot 2022-04-17 at 14.50.182880×834 378 KB

SDGGiesbrecht · 2022-04-17T17:45:52.997Z

If the build is fine and only Xcode previews fails, then you are not doing anything wrong and the fault is with Xcode. Xcode is closed source, so there is nothing I can do to help. https://feedbackassistant.apple.com

AndreyGusev · 2022-04-18T08:10:22.990Z

In my case I'm running a pure Xcode build for tvOS target and getting compilation error due to non-compatible API usage occur in iOS target.

I maid an example and strange, but got error only once (may be not...), but I found that my production app has a slightly different structure: error occurs when I add second level iOS-only dependency to the the one added conditionally. Reproduces stable.

Screenshot 2022-04-18 at 10.42.031476×230 49.7 KB

Screenshot 2022-04-18 at 10.42.332890×938 294 KB

Here is my example project:

GitHub

GitHub - GusevAndrey/SPM-Dependency-Example: Example project for discussion

Example project for discussion. Contribute to GusevAndrey/SPM-Dependency-Example development by creating an account on GitHub.

As I said: the issue is only applicable for tvOS build (the very same structure for iOS build run without any error).

And as I see, if declare second-level dependency conditionally linked, then compilation succeeds. So we have a workaround...)

Screenshot 2022-04-18 at 10.43.391824×354 42.3 KB

SDGGiesbrecht · 2022-04-18T23:03:43.858Z

It does incorrectly attempt to build the tvOS stuff for iOS too, it is just less noticeable since that build succeeds. If you place something nonsensical inside #if !os(whichever), you can quickly prove that the problem affects pretty much every platform.

This is definitely a bug, but is unfortunately also of the Feedback Assistant kind. (Include a link to this thread instead of repeating yourself.)

I believe most of us have not noticed this because we test our packages at the package level. Since there is no such thing as a conditional target, attempting to build the entire package for tvOS would rightly fail, because it would involve building iOS-specific-target as one of the final products anyway, even though it would not be used in turn by any of the other products. Because that is the case, most of us are accustomed to surrounding files in #if os(iOS) anyway so that all targets build for all platforms anything in the package supports. The result is that our conditional dependencies are only ever across package boundaries (which definitely works). I mention it because either using #if or splitting the conditional dependencies into separate packages might be more resilient workarounds, depending on how your real project is actually arranged. But duplicating the condition at each level of the dependency tree as you have done is definitely the least invasive option for any project where it is sufficient.

AndreyGusev · 2022-04-19T08:27:01.210Z

Feedback reported: FB9987670

bimawa · 2024-07-02T12:13:29.056Z

Guys, did we encounter any solution to its issue in 2024 years?