Swift logo is stretched


(Adrian Zubarev) #1

@Nicole_Jacque Sorry I couldn’t find the thread where it was previously mentioned but the Swift logo was never fixed. When you view a specific thread you’ll get a rounded square logo while you’ll see a stretched logo elsewhere on the forum.

56

45


Site logo is stretched in dark theme
#2

I don’t have this on my Mac or iPhone. Could it be a browser bug? Which one are you using?


(Lukas Stabe 🙃) #3

For me this happens on Firefox and Safari. It doesn’t happen on Chrome. On iOS the logo is always stretched, since the title bar always shows the logo including the “Swift” string, never the post title.


(Tim Buchheim) #4

I can duplicate it in Safari on the Mac when using the dark theme. It does not occur with the default (light) theme.


#5

Yes it appears to be a bug in the dark theme. Could reproduce it only there.


(Peter Nicholls) #6

It seems to be on dark theme, and only when the full banner is shown, not the logo only banner (on scrolling)


(Nicole Jacque) #7

I don't think I was able to reproduce this, but I'll try again.


(Adrian Zubarev) #8

It‘s even worse now. The font is now fat too. Logo is still streched.


(Lance Parker) #9

I'm seeing it too if that helps


(Ben Rimmington) #10

The original images aren't stretched, and are both 576 x 180 pixels:

The stylesheet for the dark theme is using background-size: 150px 40px, but it should be using background-size: 128px 40px to keep the original aspect ratio.

// Theme: Dark
// Target: common scss
// Last Edited: 2018-07-03 19:43:29 UTC

.logo-big {
    display: block;
    -moz-box-sizing: border-box;
    box-sizing: border-box;
    background: url(https://discourse-cdn-sjc1.com/swift/uploads/default/original/2X/3/318de24e67a74728a2f4a686e86fea1f127341f5.png) no-repeat;
    width: 150px; 
    height: 40px; 
    padding-left: 150px; 
    background-size: 150px 40px;
}

The other more subtle issue is that the image without text (which is shown after scrolling down to more recent posts within a topic) is 590 x 585 pixels, and has more empty space around it than the other images. Ideally, this image would be 180 x 180 pixels, by cropping the black or white text from one of the other images. A smaller image might also help in Discord and Slack.


(Adrian Zubarev) #11

This is still not fixed, yet it got even worse. @forum_admins what happend?


(Nicole Jacque) #12

Eeeew. Ok, I'm investigating.


(Adrian Zubarev) #13

Now we only need the logo with white text for the dark discourse theme and it's perfect.

image


(Nicole Jacque) #14

Ok please try refreshing (I actually had to quit my browser and relaunch) but I think I have this resolved. Can someone else confirm that it looks correct for them as well?


(Adrian Zubarev) #15

It‘s white now but the font, size and position is off now.

image image


(Nicole Jacque) #16

Aha. Ok, try one more time. I actually had to not only refresh but close the browser to get things to refresh, but now the logos fonts/size should match.


(Adrian Zubarev) #17

Its perfect now thank you.

image