Swift-driver's Options.swift unexpected diff

I'm adding an option to the driver that was recently added to the frontend - -print-diagnostic-groups.
makeOptions generated a diff with many changes unrelated to the option I'm working on.
What's the guideline in this case? Should I selectively commit changes related to my option only or everything?

No, I'd leave them in. People often forget to synchronize the options, so you're just catching the driver up with the compiler. If you want your PR to be focused on your changes, you could open one first that just synchronized the options changes that were missing before.

2 Likes