[Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #116


(Jordan Rose) #1

This bot has three separate issues:

- A flaky TSan test (that I thought Kuba disabled, but apparently not)
- A Foundation overlay test that Philippe knows about but hasn't gotten around to yet
- A SILGen failure that looks related to Michael's work on SIL ownership

Michael, can you look into the last one if it's not fixed yet? This is SILGen/opaque_values_silgen.swift, specifically with a resilience-enabled build.

···

On Feb 20, 2017, at 05:18, no-reply@swift.org wrote:

New issue found!

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#116]

Build URL: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/
Project: oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build: Mon, 20 Feb 2017 03:47:00 -0800
Build duration: 1 hr 31 min
Identified problems:

Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#-1884046137c38edd5a-00f9-40a2-abac-1db59f7a90ca>
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1358470745ee1a197b-acac-4b17-83cf-a53b95139a76>
Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1563699420fca400bf-2f4a-462e-b517-e058d770b2d7>
Changes

Commit 70054ba09e83fceb684570902d513e8f0375d952 by hughbellars:
Fix build, edit, build loop on Windows

edit: cmake/modules/SwiftSource.cmake

Commit c6b32aea2c6166513fdd14dfbd79bba5d05a4eff by mgottesman:
[silgen] Add APIs for creating managed buffers and managed rvalues in a

edit: lib/SILGen/SILGenFunction.h
edit: lib/SILGen/SILGenDecl.cpp

Commit aa9efae56288e41a3686a340e4ec8cda84657a2b by jans.pavlovs:
Update map example code

edit: stdlib/public/core/Sequence.swift

Commit bdb4195de8c5f33c25d5d192bc69ca6fa1d7efb3 by mgottesman:
[silgen] ManagedValue::{formalEvaluationBorrow,formalAccessBorrow}()

edit: lib/SILGen/SILGenLValue.cpp
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/ManagedValue.h

Commit 0ae6c2523882be544bb808b0d5a1f20df02e51c1 by mgottesman:
[silgen] Make SILGenBuilder::createCopyValue a drop in replacement for

edit: lib/SILGen/SILGenBuilder.h
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp

Commit 6b05692d31a24fb1d1f19695e778412ea6775ab8 by mgottesman:
[silgen] Remove incorrect assumptions in

edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/ManagedValue.h

Commit 5717eeba673a3ad6be689d057ab4868fde2a1580 by mgottesman:
[silgen] Create a ManagedValue::formalAccessCopy(SILGenFunction &,

edit: lib/SILGen/ManagedValue.h
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit 9a964034960c2ec5cae78336813b63093f8bfe2a by mgottesman:
[silgen] Refactor prepareArchetypeCallee to use a builder class instead

edit: lib/SILGen/SILGenApply.cpp

Commit 53b777cf9c1cf1891c6134c2b67ea3e58e620394 by mgottesman:
[silgen] Add an assert that formalAccessCopy is only called in a

edit: lib/SILGen/ManagedValue.cpp

Commit 825765a0479379e2d7f842452370860954506d66 by mgottesman:
[silgen] Change createFormalAccessCopyAddr to take take/init parameters.

edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit 5920daa373ce9e6ad9b1c63b2976b7f3491fd0f3 by mgottesman:
[silgen] Refactor getAddressForInPlaceInitialization onto SGFContext().

edit: lib/SILGen/SILGenExpr.cpp
edit: lib/SILGen/SILGenFunction.h

Commit dd5120e9f0baeb1b0f16d8b867e0488aa99acc78 by mgottesman:
[silgen] Create a closure API called bufferForExprResult based on

edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuiltin.cpp
edit: lib/SILGen/SILGenLValue.cpp
edit: lib/SILGen/SILGenApply.cpp
edit: lib/SILGen/SILGenConvert.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit d4a5fe58beee33996e8cab2cace68b60d9ca780c by rudkx:
Attempt to bind the result of unwrapping optionals if we're asked to

edit: test/Constraints/closures.swift
edit: lib/Sema/CSSolver.cpp

Commit 1e17d86836d2f8851d462d7397c638872b9581f3 by mgottesman:
[silgen] Change one instance of switch_enum{_addr} that were using

edit: test/SILGen/implicitly_unwrapped_optional.swift
edit: test/SILGen/optional.swift
edit: lib/SILGen/SILGenConvert.cpp
edit: test/SILGen/objc_bridging.swift
edit: test/SILGen/vtable_thunks.swift

Commit a13289835e76fe5716fa780cbf6fa5722f044b4c by kyrtzidis:
[index] For extensions, relate the symbol reference that gets extended

edit: include/swift/Index/IndexSymbol.h
edit: test/Index/kinds.swift
edit: lib/Index/Index.cpp
edit: test/Index/roles.swift

Commit 850e67434925022d48d565c4731f86c10116317d by mgottesman:
[silgen] Change SILGenBuiltin emission of retain/release/autorelease to

edit: lib/SILGen/SILGenBuiltin.cpp
edit: test/SILGen/builtins.swift

Commit 3464a9399d21ceb6196f65664cc119462b1533dd by hughbellars:
Port SwiftLangSupport::resolvePathSymlinks to Windows

edit: tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp

Commit 3d5f979dae6c3cfd0d9878770b15a3675b0bf22c by mgottesman:
[silgen] Perform a borrow when the native inputs require a guaranteed

edit: test/SILGen/foreign_errors.swift
edit: test/SILGen/objc_set_bridging.swift
edit: test/SILGen/objc_blocks_bridging.swift
edit: test/SILGen/objc_thunks.swift
edit: test/SILGen/guaranteed_self.swift
edit: test/SILGen/objc_bridging.swift
edit: test/SILGen/objc_bridging_any.swift
edit: test/SILGen/objc_extensions.swift
edit: test/SILGen/objc_dictionary_bridging.swift
edit: test/SILGen/objc_properties.swift
edit: test/ClangImporter/optional.swift
edit: lib/SILGen/SILGenBridging.cpp
edit: test/SILGen/objc_metatypes.swift

Commit 4b1d99fcc31342cd1daa1ed33875850de5435a5b by kyrtzidis:
[index] Relate extension members with the extension symbol.

edit: test/Index/roles.swift
edit: lib/Index/Index.cpp

Commit 4f23d61da03d6c9ab56a6216e98583a8c611b5d6 by hughbellars:
Import print_function wherever we use print() in python code

edit: utils/coverage/coverage-touch-tests
edit: utils/bug_reducer/bug_reducer/opt_bug_reducer.py
edit: utils/rth
edit: utils/scale-test
edit: utils/bug_reducer/bug_reducer/func_bug_reducer.py
edit: utils/resolve-crashes.py
edit: utils/backtrace-check
edit: utils/swift_build_support/swift_build_support/diagnostics.py
edit: utils/bug_reducer/bug_reducer/swift_tools.py
edit: utils/bug_reducer/bug_reducer/random_bug_finder.py
edit: benchmark/scripts/compare_perf_tests.py
edit: benchmark/utils/convertToJSON.py
edit: utils/bug_reducer/bug_reducer/list_reducer.py
edit: benchmark/scripts/generate_harness/generate_harness.py
edit: benchmark/scripts/perf_test_driver/perf_test_driver.py

Commit a5e7514197b7613b2626c5ee1fb43b6e02ec38b6 by hughbellars:
Prefer the print function to the print statment in python code

edit: utils/scale-test
edit: utils/coverage/coverage-touch-tests

Commit fe16cf869d65cd20fca7ce5666350b07e838bf91 by spestov:
Sema: Move some code around for better organization

edit: lib/Sema/TypeCheckProtocol.cpp
edit: lib/Sema/TypeCheckGeneric.cpp

Commit be50b2a624839deaf8184a5196cd7ef894673b3b by mgottesman:
[silgen] Add new ownership APIs for enum extraction to SILGenBuilder.

edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit b319a3aa322dd22b4a8a19b77edf71be0acd38d8 by spestov:
AST: Clean up some more duplication using the new GenericContext

edit: include/swift/AST/LazyResolver.h
edit: lib/AST/ASTContext.cpp
edit: lib/AST/Decl.cpp
edit: include/swift/Serialization/ModuleFile.h
edit: include/swift/AST/ASTContext.h
edit: lib/Serialization/Deserialization.cpp

Commit 880803aaba001d77bcaa28b8ce8b36149f0e96ad by spestov:
AST: Initial plumbing for generic subscripts

edit: lib/Serialization/Deserialization.cpp
edit: include/swift/AST/Decl.h
edit: lib/ClangImporter/ImportDecl.cpp
edit: lib/Parse/ParseDecl.cpp
edit: lib/Sema/TypeCheckDecl.cpp
edit: lib/AST/DeclContext.cpp

Commit cc54361b2a2832885adaea38fb5bcaf6e363a2a8 by spestov:
Serialization: Add support for generic subscripts

edit: lib/Serialization/Deserialization.cpp
edit: lib/Serialization/Serialization.cpp
edit: include/swift/Serialization/ModuleFormat.h

Commit 26a266b15eb00c3f450c296adbd3d0eda1d2baa9 by mgottesman:
[silgen] Cleanup emitPreconditionOptionalHasValue and its uses so that

edit: lib/SILGen/SILGenBuilder.h
edit: lib/SILGen/SILGenFunction.h
edit: lib/SILGen/SILGenConvert.cpp
edit: test/SILGen/objc_witnesses.swift
edit: test/SILGen/vtable_thunks.swift
edit: test/SILGen/objc_bridging.swift
edit: lib/SILGen/SILGenLValue.cpp
edit: test/SILGen/witnesses.swift
edit: test/SILGen/expressions.swift
edit: lib/SILGen/SILGenBuilder.cpp
edit: test/SILGen/objc_ownership_conventions.swift

Commit 1098e61ae1216b70d0508257b119b7126d568a15 by hughbellars:
Fix debug info flags passed to MSVC/clang-cl

edit: cmake/modules/AddSwift.cmake

Commit 0da22a2e53249e5cf4e859d997635b72a5a012e0 by hughbellars:
Fixup Windows specific compiler flags passed to MSVC/Clang-cl

edit: cmake/modules/AddSwift.cmake

Commit 9f9da4b6473e792ebbe465522a4b4b98d7aedc38 by hughbellars:
[CMake] Simplify consecutive identical if statements

edit: cmake/modules/AddSwift.cmake

Commit b60945fbd88a30686a3ad6530ad6139eb78ec73a by hughbellars:
[CMake] Use correct compiler flag for unoptimized MSVC/clang-cl builds

edit: cmake/modules/AddSwift.cmake

Commit 84de5392547dd8043c216acf137e5547c7c68d1b by practicalswift:
[swiftc (53 vs. 5456)] Add crasher in swift::ASTVisitor

add: validation-test/compiler_crashers/28697-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift

Commit 61b3b820f3947cafe041acc4cd1b54223a1fdf35 by practicalswift:
[swiftc (54 vs. 5456)] Add crasher in

add: validation-test/compiler_crashers/28698-isactuallycanonicalornull-forming-a-cantype-out-of-a-non-canonical-type.swift


(Michael Gottesman) #2

Thanks!

Michael

···

On Feb 20, 2017, at 9:55 AM, Jordan Rose <jordan_rose@apple.com> wrote:

This bot has three separate issues:

- A flaky TSan test (that I thought Kuba disabled, but apparently not)
- A Foundation overlay test that Philippe knows about but hasn't gotten around to yet
- A SILGen failure that looks related to Michael's work on SIL ownership

Michael, can you look into the last one if it's not fixed yet? This is SILGen/opaque_values_silgen.swift, specifically with a resilience-enabled build.

On Feb 20, 2017, at 05:18, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

New issue found!

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#116]

Build URL: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/
Project: oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build: Mon, 20 Feb 2017 03:47:00 -0800
Build duration: 1 hr 31 min
Identified problems:

Assertion failure: This build failed because of an assertion failure. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#-1884046137c38edd5a-00f9-40a2-abac-1db59f7a90ca>
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1358470745ee1a197b-acac-4b17-83cf-a53b95139a76>
Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/116/consoleFull#1563699420fca400bf-2f4a-462e-b517-e058d770b2d7>
Changes

Commit 70054ba09e83fceb684570902d513e8f0375d952 by hughbellars:
Fix build, edit, build loop on Windows

edit: cmake/modules/SwiftSource.cmake

Commit c6b32aea2c6166513fdd14dfbd79bba5d05a4eff by mgottesman:
[silgen] Add APIs for creating managed buffers and managed rvalues in a

edit: lib/SILGen/SILGenFunction.h
edit: lib/SILGen/SILGenDecl.cpp

Commit aa9efae56288e41a3686a340e4ec8cda84657a2b by jans.pavlovs:
Update map example code

edit: stdlib/public/core/Sequence.swift

Commit bdb4195de8c5f33c25d5d192bc69ca6fa1d7efb3 by mgottesman:
[silgen] ManagedValue::{formalEvaluationBorrow,formalAccessBorrow}()

edit: lib/SILGen/SILGenLValue.cpp
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/ManagedValue.h

Commit 0ae6c2523882be544bb808b0d5a1f20df02e51c1 by mgottesman:
[silgen] Make SILGenBuilder::createCopyValue a drop in replacement for

edit: lib/SILGen/SILGenBuilder.h
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp

Commit 6b05692d31a24fb1d1f19695e778412ea6775ab8 by mgottesman:
[silgen] Remove incorrect assumptions in

edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/ManagedValue.h

Commit 5717eeba673a3ad6be689d057ab4868fde2a1580 by mgottesman:
[silgen] Create a ManagedValue::formalAccessCopy(SILGenFunction &,

edit: lib/SILGen/ManagedValue.h
edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit 9a964034960c2ec5cae78336813b63093f8bfe2a by mgottesman:
[silgen] Refactor prepareArchetypeCallee to use a builder class instead

edit: lib/SILGen/SILGenApply.cpp

Commit 53b777cf9c1cf1891c6134c2b67ea3e58e620394 by mgottesman:
[silgen] Add an assert that formalAccessCopy is only called in a

edit: lib/SILGen/ManagedValue.cpp

Commit 825765a0479379e2d7f842452370860954506d66 by mgottesman:
[silgen] Change createFormalAccessCopyAddr to take take/init parameters.

edit: lib/SILGen/ManagedValue.cpp
edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit 5920daa373ce9e6ad9b1c63b2976b7f3491fd0f3 by mgottesman:
[silgen] Refactor getAddressForInPlaceInitialization onto SGFContext().

edit: lib/SILGen/SILGenExpr.cpp
edit: lib/SILGen/SILGenFunction.h

Commit dd5120e9f0baeb1b0f16d8b867e0488aa99acc78 by mgottesman:
[silgen] Create a closure API called bufferForExprResult based on

edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuiltin.cpp
edit: lib/SILGen/SILGenLValue.cpp
edit: lib/SILGen/SILGenApply.cpp
edit: lib/SILGen/SILGenConvert.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit d4a5fe58beee33996e8cab2cace68b60d9ca780c by rudkx:
Attempt to bind the result of unwrapping optionals if we're asked to

edit: test/Constraints/closures.swift
edit: lib/Sema/CSSolver.cpp

Commit 1e17d86836d2f8851d462d7397c638872b9581f3 by mgottesman:
[silgen] Change one instance of switch_enum{_addr} that were using

edit: test/SILGen/implicitly_unwrapped_optional.swift
edit: test/SILGen/optional.swift
edit: lib/SILGen/SILGenConvert.cpp
edit: test/SILGen/objc_bridging.swift
edit: test/SILGen/vtable_thunks.swift

Commit a13289835e76fe5716fa780cbf6fa5722f044b4c by kyrtzidis:
[index] For extensions, relate the symbol reference that gets extended

edit: include/swift/Index/IndexSymbol.h
edit: test/Index/kinds.swift
edit: lib/Index/Index.cpp
edit: test/Index/roles.swift

Commit 850e67434925022d48d565c4731f86c10116317d by mgottesman:
[silgen] Change SILGenBuiltin emission of retain/release/autorelease to

edit: lib/SILGen/SILGenBuiltin.cpp
edit: test/SILGen/builtins.swift

Commit 3464a9399d21ceb6196f65664cc119462b1533dd by hughbellars:
Port SwiftLangSupport::resolvePathSymlinks to Windows

edit: tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp

Commit 3d5f979dae6c3cfd0d9878770b15a3675b0bf22c by mgottesman:
[silgen] Perform a borrow when the native inputs require a guaranteed

edit: test/SILGen/foreign_errors.swift
edit: test/SILGen/objc_set_bridging.swift
edit: test/SILGen/objc_blocks_bridging.swift
edit: test/SILGen/objc_thunks.swift
edit: test/SILGen/guaranteed_self.swift
edit: test/SILGen/objc_bridging.swift
edit: test/SILGen/objc_bridging_any.swift
edit: test/SILGen/objc_extensions.swift
edit: test/SILGen/objc_dictionary_bridging.swift
edit: test/SILGen/objc_properties.swift
edit: test/ClangImporter/optional.swift
edit: lib/SILGen/SILGenBridging.cpp
edit: test/SILGen/objc_metatypes.swift

Commit 4b1d99fcc31342cd1daa1ed33875850de5435a5b by kyrtzidis:
[index] Relate extension members with the extension symbol.

edit: test/Index/roles.swift
edit: lib/Index/Index.cpp

Commit 4f23d61da03d6c9ab56a6216e98583a8c611b5d6 by hughbellars:
Import print_function wherever we use print() in python code

edit: utils/coverage/coverage-touch-tests
edit: utils/bug_reducer/bug_reducer/opt_bug_reducer.py
edit: utils/rth
edit: utils/scale-test
edit: utils/bug_reducer/bug_reducer/func_bug_reducer.py
edit: utils/resolve-crashes.py
edit: utils/backtrace-check
edit: utils/swift_build_support/swift_build_support/diagnostics.py
edit: utils/bug_reducer/bug_reducer/swift_tools.py
edit: utils/bug_reducer/bug_reducer/random_bug_finder.py
edit: benchmark/scripts/compare_perf_tests.py
edit: benchmark/utils/convertToJSON.py
edit: utils/bug_reducer/bug_reducer/list_reducer.py
edit: benchmark/scripts/generate_harness/generate_harness.py
edit: benchmark/scripts/perf_test_driver/perf_test_driver.py

Commit a5e7514197b7613b2626c5ee1fb43b6e02ec38b6 by hughbellars:
Prefer the print function to the print statment in python code

edit: utils/scale-test
edit: utils/coverage/coverage-touch-tests

Commit fe16cf869d65cd20fca7ce5666350b07e838bf91 by spestov:
Sema: Move some code around for better organization

edit: lib/Sema/TypeCheckProtocol.cpp
edit: lib/Sema/TypeCheckGeneric.cpp

Commit be50b2a624839deaf8184a5196cd7ef894673b3b by mgottesman:
[silgen] Add new ownership APIs for enum extraction to SILGenBuilder.

edit: lib/SILGen/SILGenBuilder.cpp
edit: lib/SILGen/SILGenBuilder.h

Commit b319a3aa322dd22b4a8a19b77edf71be0acd38d8 by spestov:
AST: Clean up some more duplication using the new GenericContext

edit: include/swift/AST/LazyResolver.h
edit: lib/AST/ASTContext.cpp
edit: lib/AST/Decl.cpp
edit: include/swift/Serialization/ModuleFile.h
edit: include/swift/AST/ASTContext.h
edit: lib/Serialization/Deserialization.cpp

Commit 880803aaba001d77bcaa28b8ce8b36149f0e96ad by spestov:
AST: Initial plumbing for generic subscripts

edit: lib/Serialization/Deserialization.cpp
edit: include/swift/AST/Decl.h
edit: lib/ClangImporter/ImportDecl.cpp
edit: lib/Parse/ParseDecl.cpp
edit: lib/Sema/TypeCheckDecl.cpp
edit: lib/AST/DeclContext.cpp

Commit cc54361b2a2832885adaea38fb5bcaf6e363a2a8 by spestov:
Serialization: Add support for generic subscripts

edit: lib/Serialization/Deserialization.cpp
edit: lib/Serialization/Serialization.cpp
edit: include/swift/Serialization/ModuleFormat.h

Commit 26a266b15eb00c3f450c296adbd3d0eda1d2baa9 by mgottesman:
[silgen] Cleanup emitPreconditionOptionalHasValue and its uses so that

edit: lib/SILGen/SILGenBuilder.h
edit: lib/SILGen/SILGenFunction.h
edit: lib/SILGen/SILGenConvert.cpp
edit: test/SILGen/objc_witnesses.swift
edit: test/SILGen/vtable_thunks.swift
edit: test/SILGen/objc_bridging.swift
edit: lib/SILGen/SILGenLValue.cpp
edit: test/SILGen/witnesses.swift
edit: test/SILGen/expressions.swift
edit: lib/SILGen/SILGenBuilder.cpp
edit: test/SILGen/objc_ownership_conventions.swift

Commit 1098e61ae1216b70d0508257b119b7126d568a15 by hughbellars:
Fix debug info flags passed to MSVC/clang-cl

edit: cmake/modules/AddSwift.cmake

Commit 0da22a2e53249e5cf4e859d997635b72a5a012e0 by hughbellars:
Fixup Windows specific compiler flags passed to MSVC/Clang-cl

edit: cmake/modules/AddSwift.cmake

Commit 9f9da4b6473e792ebbe465522a4b4b98d7aedc38 by hughbellars:
[CMake] Simplify consecutive identical if statements

edit: cmake/modules/AddSwift.cmake

Commit b60945fbd88a30686a3ad6530ad6139eb78ec73a by hughbellars:
[CMake] Use correct compiler flag for unoptimized MSVC/clang-cl builds

edit: cmake/modules/AddSwift.cmake

Commit 84de5392547dd8043c216acf137e5547c7c68d1b by practicalswift:
[swiftc (53 vs. 5456)] Add crasher in swift::ASTVisitor

add: validation-test/compiler_crashers/28697-anonymous-namespace-findcapturedvars-checktype-swift-type-swift-sourceloc.swift

Commit 61b3b820f3947cafe041acc4cd1b54223a1fdf35 by practicalswift:
[swiftc (54 vs. 5456)] Add crasher in

add: validation-test/compiler_crashers/28698-isactuallycanonicalornull-forming-a-cantype-out-of-a-non-canonical-type.swift