[Swift CI] Build Still Failing: 0. OSS - LLDB Incremental - OS X (master) #416

+Bob the build czar
+Joe the committer

This test: [TestSwiftFoundationTypeNotification.py FAILED]

Looks like it started failing at this build:
https://ci.swift.org/job/oss-lldb-incremental-osx/415/

Clang changes:
clang-refactor-test: dispose of the TU
Add virtual destructor to DeclPredicateNode to avoid a leak in subclass
[refactor] dispose of the previous replacement string when merging

Swift changes:
[dead-function-elimination] Do not consider transparent functions as
IRGen: Treat class layout for classes from other modules a bit more
Code size: destroy_addr outline
mark enum's outlined retain/releases as no inline

-Andy

···

On Nov 18, 2017, at 1:41 AM, no-reply@swift.org wrote:

New issue found!

[FAILURE] oss-lldb-incremental-osx [#416]

Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/416/
Project: oss-lldb-incremental-osx
Date of build: Sat, 18 Nov 2017 02:40:19 -0600
Build duration: 1 hr 0 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-lldb-incremental-osx/416/consoleFull#879569241ba62d58e-7248-467b-91e0-c7508d5cf947>
Changes

Commit 48baa3f472a6bd7b3f0e1f425e736cfb2663316d by dgregor:
[stdlib] Move Array and Optional == and != into static methods.

edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/Optional.swift

Commit c4e87f0861448ad36bac64a26558fb97fa018c42 by nhawes:
[Refactoring] Fix local rename missing occurrences in string

edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename-ranges.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename.swift
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename/foo_arity1.expected
edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift
edit: test/SourceKit/Refactoring/syntactic-rename/foo.in.json
edit: test/SourceKit/Refactoring/find-rename-ranges/foo_arity1.expected

Commit 9f1cd0bf6bf25a30f895afac41c2e6315be88016 by dgregor:
[Stdlib] Move _OptionalNilComparisonType operators into an extension on

edit: test/stdlib/TestNSNumberBridging.swift
edit: test/expr/unary/keypath/salvage-with-other-type-errors.swift
edit: validation-test/stdlib/ValidationNSNumberBridging.swift
edit: stdlib/public/core/Optional.swift

Commit c85880899d90bc018dc8f17f2ee35cdb7aa6840c by atrick:
implement SE 184: add allocation methods to Unsafe buffer pointers, drop

edit: test/stdlib/Builtins.swift
edit: test/Sanitizers/asan.swift
edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
edit: stdlib/public/core/UnsafePointer.swift.gyb
edit: stdlib/public/SDK/Foundation/NSSet.swift
edit: stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
edit: stdlib/public/core/StringCore.swift
edit: validation-test/stdlib/ArrayNew.swift.gyb
edit: stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift
edit: test/stdlib/KeyPathImplementation.swift
edit: stdlib/public/core/Misc.swift
edit: stdlib/public/core/SwiftNativeNSArray.swift
edit: stdlib/public/core/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/UnsafeRawBufferPointer.swift
edit: validation-test/stdlib/HashingAvalanche.swift
edit: test/Generics/slice_test.swift
edit: stdlib/public/SDK/Foundation/Data.swift
edit: test/stdlib/NSStringAPI.swift
edit: test/stdlib/UnsafeRawPointer.swift
edit: validation-test/stdlib/Prototypes/PersistentVector.swift.gyb
edit: test/stdlib/StringAPI.swift
edit: validation-test/stdlib/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/ManagedBuffer.swift
edit: stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/PthreadBarriers.swift
edit: stdlib/public/core/ThreadLocalStorage.swift
edit: test/IRGen/generic_types.swift
edit: stdlib/public/core/UnsafeBitMap.swift
edit: test/stdlib/Reflection.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift
edit: stdlib/public/core/UnsafeRawPointer.swift.gyb
edit: stdlib/public/core/KeyPath.swift
edit: validation-test/stdlib/UnsafeBitMap.swift
edit: stdlib/private/StdlibCollectionUnittest/CheckSequenceInstance.swift.gyb
edit: stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift
edit: validation-test/stdlib/CoreAudio.swift
edit: stdlib/public/core/ManagedBuffer.swift
edit: test/stdlib/UnsafePointer.swift.gyb
edit: validation-test/stdlib/Lazy.swift.gyb
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/Prototypes/CollectionTransformers.swift
edit: stdlib/public/SDK/Foundation/NSDictionary.swift

I’ll take a look at the test right now. Sorry about that: was AFK / did not check my email during the break.

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

···

On Nov 18, 2017, at 2:44 PM, Andrew Trick <atrick@apple.com> wrote:

+Bob the build czar
+Joe the committer

This test: [TestSwiftFoundationTypeNotification.py FAILED]

Looks like it started failing at this build:
https://ci.swift.org/job/oss-lldb-incremental-osx/415/

Clang changes:
clang-refactor-test: dispose of the TU
Add virtual destructor to DeclPredicateNode to avoid a leak in subclass
[refactor] dispose of the previous replacement string when merging

Swift changes:
[dead-function-elimination] Do not consider transparent functions as
IRGen: Treat class layout for classes from other modules a bit more
Code size: destroy_addr outline
mark enum's outlined retain/releases as no inline

-Andy

On Nov 18, 2017, at 1:41 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

New issue found!

[FAILURE] oss-lldb-incremental-osx [#416]

Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/416/
Project: oss-lldb-incremental-osx
Date of build: Sat, 18 Nov 2017 02:40:19 -0600
Build duration: 1 hr 0 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-lldb-incremental-osx/416/consoleFull#879569241ba62d58e-7248-467b-91e0-c7508d5cf947>
Changes

Commit 48baa3f472a6bd7b3f0e1f425e736cfb2663316d by dgregor:
[stdlib] Move Array and Optional == and != into static methods.

edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/Optional.swift

Commit c4e87f0861448ad36bac64a26558fb97fa018c42 by nhawes:
[Refactoring] Fix local rename missing occurrences in string

edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename-ranges.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename.swift
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename/foo_arity1.expected
edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift
edit: test/SourceKit/Refactoring/syntactic-rename/foo.in.json
edit: test/SourceKit/Refactoring/find-rename-ranges/foo_arity1.expected

Commit 9f1cd0bf6bf25a30f895afac41c2e6315be88016 by dgregor:
[Stdlib] Move _OptionalNilComparisonType operators into an extension on

edit: test/stdlib/TestNSNumberBridging.swift
edit: test/expr/unary/keypath/salvage-with-other-type-errors.swift
edit: validation-test/stdlib/ValidationNSNumberBridging.swift
edit: stdlib/public/core/Optional.swift

Commit c85880899d90bc018dc8f17f2ee35cdb7aa6840c by atrick:
implement SE 184: add allocation methods to Unsafe buffer pointers, drop

edit: test/stdlib/Builtins.swift
edit: test/Sanitizers/asan.swift
edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
edit: stdlib/public/core/UnsafePointer.swift.gyb
edit: stdlib/public/SDK/Foundation/NSSet.swift
edit: stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
edit: stdlib/public/core/StringCore.swift
edit: validation-test/stdlib/ArrayNew.swift.gyb
edit: stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift
edit: test/stdlib/KeyPathImplementation.swift
edit: stdlib/public/core/Misc.swift
edit: stdlib/public/core/SwiftNativeNSArray.swift
edit: stdlib/public/core/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/UnsafeRawBufferPointer.swift
edit: validation-test/stdlib/HashingAvalanche.swift
edit: test/Generics/slice_test.swift
edit: stdlib/public/SDK/Foundation/Data.swift
edit: test/stdlib/NSStringAPI.swift
edit: test/stdlib/UnsafeRawPointer.swift
edit: validation-test/stdlib/Prototypes/PersistentVector.swift.gyb
edit: test/stdlib/StringAPI.swift
edit: validation-test/stdlib/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/ManagedBuffer.swift
edit: stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/PthreadBarriers.swift
edit: stdlib/public/core/ThreadLocalStorage.swift
edit: test/IRGen/generic_types.swift
edit: stdlib/public/core/UnsafeBitMap.swift
edit: test/stdlib/Reflection.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift
edit: stdlib/public/core/UnsafeRawPointer.swift.gyb
edit: stdlib/public/core/KeyPath.swift
edit: validation-test/stdlib/UnsafeBitMap.swift
edit: stdlib/private/StdlibCollectionUnittest/CheckSequenceInstance.swift.gyb
edit: stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift
edit: validation-test/stdlib/CoreAudio.swift
edit: stdlib/public/core/ManagedBuffer.swift
edit: test/stdlib/UnsafePointer.swift.gyb
edit: validation-test/stdlib/Lazy.swift.gyb
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/Prototypes/CollectionTransformers.swift
edit: stdlib/public/SDK/Foundation/NSDictionary.swift

Ah I see there’s another email thread / Bob already created a radar. <rdar://problem/35650693 <rdar://problem/35650693>> Swift CI: lldb assertion failed: 'frame variable notification' returns expected result

Sorry, catching up on my emails, Are there any LLDB changes involved in there? At first glance, I don’t see why my changes would do this..

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

···

On Nov 27, 2017, at 9:53 AM, Joe Shajrawi <shajrawi@apple.com> wrote:

I’ll take a look at the test right now. Sorry about that: was AFK / did not check my email during the break.

Regards,
—Joe |  | :e-mail: shajrawi@apple.com <mailto:shajrawi@apple.com> | :iphone:(+1) 408-930-5203

On Nov 18, 2017, at 2:44 PM, Andrew Trick <atrick@apple.com <mailto:atrick@apple.com>> wrote:

+Bob the build czar
+Joe the committer

This test: [TestSwiftFoundationTypeNotification.py FAILED]

Looks like it started failing at this build:
https://ci.swift.org/job/oss-lldb-incremental-osx/415/

Clang changes:
clang-refactor-test: dispose of the TU
Add virtual destructor to DeclPredicateNode to avoid a leak in subclass
[refactor] dispose of the previous replacement string when merging

Swift changes:
[dead-function-elimination] Do not consider transparent functions as
IRGen: Treat class layout for classes from other modules a bit more
Code size: destroy_addr outline
mark enum's outlined retain/releases as no inline

-Andy

On Nov 18, 2017, at 1:41 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

New issue found!

[FAILURE] oss-lldb-incremental-osx [#416]

Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/416/
Project: oss-lldb-incremental-osx
Date of build: Sat, 18 Nov 2017 02:40:19 -0600
Build duration: 1 hr 0 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-lldb-incremental-osx/416/consoleFull#879569241ba62d58e-7248-467b-91e0-c7508d5cf947>
Changes

Commit 48baa3f472a6bd7b3f0e1f425e736cfb2663316d by dgregor:
[stdlib] Move Array and Optional == and != into static methods.

edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/Optional.swift

Commit c4e87f0861448ad36bac64a26558fb97fa018c42 by nhawes:
[Refactoring] Fix local rename missing occurrences in string

edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename-ranges.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename.swift
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift.expected
edit: test/SourceKit/Refactoring/syntactic-rename/foo_arity1.expected
edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift
edit: test/SourceKit/Refactoring/syntactic-rename/foo.in.json
edit: test/SourceKit/Refactoring/find-rename-ranges/foo_arity1.expected

Commit 9f1cd0bf6bf25a30f895afac41c2e6315be88016 by dgregor:
[Stdlib] Move _OptionalNilComparisonType operators into an extension on

edit: test/stdlib/TestNSNumberBridging.swift
edit: test/expr/unary/keypath/salvage-with-other-type-errors.swift
edit: validation-test/stdlib/ValidationNSNumberBridging.swift
edit: stdlib/public/core/Optional.swift

Commit c85880899d90bc018dc8f17f2ee35cdb7aa6840c by atrick:
implement SE 184: add allocation methods to Unsafe buffer pointers, drop

edit: test/stdlib/Builtins.swift
edit: test/Sanitizers/asan.swift
edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
edit: stdlib/public/core/UnsafePointer.swift.gyb
edit: stdlib/public/SDK/Foundation/NSSet.swift
edit: stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
edit: stdlib/public/core/StringCore.swift
edit: validation-test/stdlib/ArrayNew.swift.gyb
edit: stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift
edit: test/stdlib/KeyPathImplementation.swift
edit: stdlib/public/core/Misc.swift
edit: stdlib/public/core/SwiftNativeNSArray.swift
edit: stdlib/public/core/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/UnsafeRawBufferPointer.swift
edit: validation-test/stdlib/HashingAvalanche.swift
edit: test/Generics/slice_test.swift
edit: stdlib/public/SDK/Foundation/Data.swift
edit: test/stdlib/NSStringAPI.swift
edit: test/stdlib/UnsafeRawPointer.swift
edit: validation-test/stdlib/Prototypes/PersistentVector.swift.gyb
edit: test/stdlib/StringAPI.swift
edit: validation-test/stdlib/UnsafeBufferPointer.swift.gyb
edit: test/stdlib/ManagedBuffer.swift
edit: stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/PthreadBarriers.swift
edit: stdlib/public/core/ThreadLocalStorage.swift
edit: test/IRGen/generic_types.swift
edit: stdlib/public/core/UnsafeBitMap.swift
edit: test/stdlib/Reflection.swift
edit: stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift
edit: stdlib/public/core/UnsafeRawPointer.swift.gyb
edit: stdlib/public/core/KeyPath.swift
edit: validation-test/stdlib/UnsafeBitMap.swift
edit: stdlib/private/StdlibCollectionUnittest/CheckSequenceInstance.swift.gyb
edit: stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift
edit: validation-test/stdlib/CoreAudio.swift
edit: stdlib/public/core/ManagedBuffer.swift
edit: test/stdlib/UnsafePointer.swift.gyb
edit: validation-test/stdlib/Lazy.swift.gyb
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/Prototypes/CollectionTransformers.swift
edit: stdlib/public/SDK/Foundation/NSDictionary.swift

This test is checking that we can make a swift "Notification" - i.e. an NSNotification - and print it correctly. It should be:

(Notification) notification = {
  (Notification.Name) name = "MyNotification"
  (Any?) object = nil
  ([AnyHashable : Any]?) userInfo = 0 key/value pairs
}

But instead we think userInfo has 4454970632 key/value pairs, and then printing all of them makes the test results go south. So somehow we're failing to dig the userInfo field out of the Notification correctly and getting junk for it.

We haven't changed anything in the stable github branch of lldb related to this recently.

Jim

···

On Nov 27, 2017, at 10:12 AM, Joe Shajrawi via swift-lldb-dev <swift-lldb-dev@swift.org> wrote:

Ah I see there’s another email thread / Bob already created a radar. <rdar://problem/35650693> Swift CI: lldb assertion failed: 'frame variable notification' returns expected result

Sorry, catching up on my emails, Are there any LLDB changes involved in there? At first glance, I don’t see why my changes would do this..

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

On Nov 27, 2017, at 9:53 AM, Joe Shajrawi <shajrawi@apple.com> wrote:

I’ll take a look at the test right now. Sorry about that: was AFK / did not check my email during the break.

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

On Nov 18, 2017, at 2:44 PM, Andrew Trick <atrick@apple.com> wrote:

+Bob the build czar
+Joe the committer

This test: [TestSwiftFoundationTypeNotification.py FAILED]

Looks like it started failing at this build:
https://ci.swift.org/job/oss-lldb-incremental-osx/415/

Clang changes:
clang-refactor-test: dispose of the TU
Add virtual destructor to DeclPredicateNode to avoid a leak in subclass
[refactor] dispose of the previous replacement string when merging

Swift changes:
[dead-function-elimination] Do not consider transparent functions as
IRGen: Treat class layout for classes from other modules a bit more
Code size: destroy_addr outline
mark enum's outlined retain/releases as no inline

-Andy

On Nov 18, 2017, at 1:41 AM, no-reply@swift.org wrote:

New issue found!

[FAILURE] oss-lldb-incremental-osx [#416]

Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/416/
Project: oss-lldb-incremental-osx
Date of build: Sat, 18 Nov 2017 02:40:19 -0600
Build duration: 1 hr 0 min
Identified problems:

  • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
    • Indication 1

Changes

  • Commit 48baa3f472a6bd7b3f0e1f425e736cfb2663316d by dgregor:
[stdlib] Move Array and Optional == and != into static methods.

    • edit: stdlib/public/core/Arrays.swift.gyb
    • edit: stdlib/public/core/Optional.swift

  • Commit c4e87f0861448ad36bac64a26558fb97fa018c42 by nhawes:
[Refactoring] Fix local rename missing occurrences in string

    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename-ranges.swift.expected
    • edit: test/SourceKit/Refactoring/syntactic-rename.swift
    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift.expected
    • edit: test/SourceKit/Refactoring/syntactic-rename/foo_arity1.expected
    • edit: lib/IDE/SwiftSourceDocInfo.cpp
    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift
    • edit: test/SourceKit/Refactoring/syntactic-rename/foo.in.json
    • edit: test/SourceKit/Refactoring/find-rename-ranges/foo_arity1.expected

  • Commit 9f1cd0bf6bf25a30f895afac41c2e6315be88016 by dgregor:
[Stdlib] Move _OptionalNilComparisonType operators into an extension on

    • edit: test/stdlib/TestNSNumberBridging.swift
    • edit: test/expr/unary/keypath/salvage-with-other-type-errors.swift
    • edit: validation-test/stdlib/ValidationNSNumberBridging.swift
    • edit: stdlib/public/core/Optional.swift

  • Commit c85880899d90bc018dc8f17f2ee35cdb7aa6840c by atrick:
implement SE 184: add allocation methods to Unsafe buffer pointers, drop

    • edit: test/stdlib/Builtins.swift
    • edit: test/Sanitizers/asan.swift
    • edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
    • edit: stdlib/public/core/UnsafePointer.swift.gyb
    • edit: stdlib/public/SDK/Foundation/NSSet.swift
    • edit: stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
    • edit: stdlib/public/core/StringCore.swift
    • edit: validation-test/stdlib/ArrayNew.swift.gyb
    • edit: stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift
    • edit: test/stdlib/KeyPathImplementation.swift
    • edit: stdlib/public/core/Misc.swift
    • edit: stdlib/public/core/SwiftNativeNSArray.swift
    • edit: stdlib/public/core/UnsafeBufferPointer.swift.gyb
    • edit: test/stdlib/UnsafeRawBufferPointer.swift
    • edit: validation-test/stdlib/HashingAvalanche.swift
    • edit: test/Generics/slice_test.swift
    • edit: stdlib/public/SDK/Foundation/Data.swift
    • edit: test/stdlib/NSStringAPI.swift
    • edit: test/stdlib/UnsafeRawPointer.swift
    • edit: validation-test/stdlib/Prototypes/PersistentVector.swift.gyb
    • edit: test/stdlib/StringAPI.swift
    • edit: validation-test/stdlib/UnsafeBufferPointer.swift.gyb
    • edit: test/stdlib/ManagedBuffer.swift
    • edit: stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift
    • edit: stdlib/private/SwiftPrivatePthreadExtras/PthreadBarriers.swift
    • edit: stdlib/public/core/ThreadLocalStorage.swift
    • edit: test/IRGen/generic_types.swift
    • edit: stdlib/public/core/UnsafeBitMap.swift
    • edit: test/stdlib/Reflection.swift
    • edit: stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift
    • edit: stdlib/public/core/UnsafeRawPointer.swift.gyb
    • edit: stdlib/public/core/KeyPath.swift
    • edit: validation-test/stdlib/UnsafeBitMap.swift
    • edit: stdlib/private/StdlibCollectionUnittest/CheckSequenceInstance.swift.gyb
    • edit: stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift
    • edit: validation-test/stdlib/CoreAudio.swift
    • edit: stdlib/public/core/ManagedBuffer.swift
    • edit: test/stdlib/UnsafePointer.swift.gyb
    • edit: validation-test/stdlib/Lazy.swift.gyb
    • edit: stdlib/public/core/HashedCollections.swift.gyb
    • edit: test/Prototypes/CollectionTransformers.swift
    • edit: stdlib/public/SDK/Foundation/NSDictionary.swift

_______________________________________________
swift-lldb-dev mailing list
swift-lldb-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-lldb-dev

Actually, we aren't making the notification, it is made in the code of the process we're debugging. We're just trying to print it.

Jim

···

On Nov 27, 2017, at 2:57 PM, Jim Ingham <jingham@apple.com> wrote:

This test is checking that we can make a swift "Notification" - i.e. an NSNotification - and print it correctly. It should be:

(Notification) notification = {
(Notification.Name) name = "MyNotification"
(Any?) object = nil
([AnyHashable : Any]?) userInfo = 0 key/value pairs
}

But instead we think userInfo has 4454970632 key/value pairs, and then printing all of them makes the test results go south. So somehow we're failing to dig the userInfo field out of the Notification correctly and getting junk for it.

We haven't changed anything in the stable github branch of lldb related to this recently.

Jim

On Nov 27, 2017, at 10:12 AM, Joe Shajrawi via swift-lldb-dev <swift-lldb-dev@swift.org> wrote:

Ah I see there’s another email thread / Bob already created a radar. <rdar://problem/35650693> Swift CI: lldb assertion failed: 'frame variable notification' returns expected result

Sorry, catching up on my emails, Are there any LLDB changes involved in there? At first glance, I don’t see why my changes would do this..

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

On Nov 27, 2017, at 9:53 AM, Joe Shajrawi <shajrawi@apple.com> wrote:

I’ll take a look at the test right now. Sorry about that: was AFK / did not check my email during the break.

Regards,
—Joe |  | :e-mail: shajrawi@apple.com | :iphone:(+1) 408-930-5203

On Nov 18, 2017, at 2:44 PM, Andrew Trick <atrick@apple.com> wrote:

+Bob the build czar
+Joe the committer

This test: [TestSwiftFoundationTypeNotification.py FAILED]

Looks like it started failing at this build:
https://ci.swift.org/job/oss-lldb-incremental-osx/415/

Clang changes:
clang-refactor-test: dispose of the TU
Add virtual destructor to DeclPredicateNode to avoid a leak in subclass
[refactor] dispose of the previous replacement string when merging

Swift changes:
[dead-function-elimination] Do not consider transparent functions as
IRGen: Treat class layout for classes from other modules a bit more
Code size: destroy_addr outline
mark enum's outlined retain/releases as no inline

-Andy

On Nov 18, 2017, at 1:41 AM, no-reply@swift.org wrote:

New issue found!

[FAILURE] oss-lldb-incremental-osx [#416]

Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/416/
Project: oss-lldb-incremental-osx
Date of build: Sat, 18 Nov 2017 02:40:19 -0600
Build duration: 1 hr 0 min
Identified problems:

  • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
    • Indication 1

Changes

  • Commit 48baa3f472a6bd7b3f0e1f425e736cfb2663316d by dgregor:
[stdlib] Move Array and Optional == and != into static methods.

    • edit: stdlib/public/core/Arrays.swift.gyb
    • edit: stdlib/public/core/Optional.swift

  • Commit c4e87f0861448ad36bac64a26558fb97fa018c42 by nhawes:
[Refactoring] Fix local rename missing occurrences in string

    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename-ranges.swift.expected
    • edit: test/SourceKit/Refactoring/syntactic-rename.swift
    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift.expected
    • edit: test/SourceKit/Refactoring/syntactic-rename/foo_arity1.expected
    • edit: lib/IDE/SwiftSourceDocInfo.cpp
    • edit: test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift
    • edit: test/SourceKit/Refactoring/syntactic-rename/foo.in.json
    • edit: test/SourceKit/Refactoring/find-rename-ranges/foo_arity1.expected

  • Commit 9f1cd0bf6bf25a30f895afac41c2e6315be88016 by dgregor:
[Stdlib] Move _OptionalNilComparisonType operators into an extension on

    • edit: test/stdlib/TestNSNumberBridging.swift
    • edit: test/expr/unary/keypath/salvage-with-other-type-errors.swift
    • edit: validation-test/stdlib/ValidationNSNumberBridging.swift
    • edit: stdlib/public/core/Optional.swift

  • Commit c85880899d90bc018dc8f17f2ee35cdb7aa6840c by atrick:
implement SE 184: add allocation methods to Unsafe buffer pointers, drop

    • edit: test/stdlib/Builtins.swift
    • edit: test/Sanitizers/asan.swift
    • edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
    • edit: stdlib/public/core/UnsafePointer.swift.gyb
    • edit: stdlib/public/SDK/Foundation/NSSet.swift
    • edit: stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
    • edit: stdlib/public/core/StringCore.swift
    • edit: validation-test/stdlib/ArrayNew.swift.gyb
    • edit: stdlib/private/StdlibUnittest/OpaqueIdentityFunctions.swift
    • edit: test/stdlib/KeyPathImplementation.swift
    • edit: stdlib/public/core/Misc.swift
    • edit: stdlib/public/core/SwiftNativeNSArray.swift
    • edit: stdlib/public/core/UnsafeBufferPointer.swift.gyb
    • edit: test/stdlib/UnsafeRawBufferPointer.swift
    • edit: validation-test/stdlib/HashingAvalanche.swift
    • edit: test/Generics/slice_test.swift
    • edit: stdlib/public/SDK/Foundation/Data.swift
    • edit: test/stdlib/NSStringAPI.swift
    • edit: test/stdlib/UnsafeRawPointer.swift
    • edit: validation-test/stdlib/Prototypes/PersistentVector.swift.gyb
    • edit: test/stdlib/StringAPI.swift
    • edit: validation-test/stdlib/UnsafeBufferPointer.swift.gyb
    • edit: test/stdlib/ManagedBuffer.swift
    • edit: stdlib/private/SwiftPrivate/ShardedAtomicCounter.swift
    • edit: stdlib/private/SwiftPrivatePthreadExtras/PthreadBarriers.swift
    • edit: stdlib/public/core/ThreadLocalStorage.swift
    • edit: test/IRGen/generic_types.swift
    • edit: stdlib/public/core/UnsafeBitMap.swift
    • edit: test/stdlib/Reflection.swift
    • edit: stdlib/private/SwiftPrivatePthreadExtras/SwiftPrivatePthreadExtras.swift
    • edit: stdlib/public/core/UnsafeRawPointer.swift.gyb
    • edit: stdlib/public/core/KeyPath.swift
    • edit: validation-test/stdlib/UnsafeBitMap.swift
    • edit: stdlib/private/StdlibCollectionUnittest/CheckSequenceInstance.swift.gyb
    • edit: stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift
    • edit: validation-test/stdlib/CoreAudio.swift
    • edit: stdlib/public/core/ManagedBuffer.swift
    • edit: test/stdlib/UnsafePointer.swift.gyb
    • edit: validation-test/stdlib/Lazy.swift.gyb
    • edit: stdlib/public/core/HashedCollections.swift.gyb
    • edit: test/Prototypes/CollectionTransformers.swift
    • edit: stdlib/public/SDK/Foundation/NSDictionary.swift

_______________________________________________
swift-lldb-dev mailing list
swift-lldb-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-lldb-dev