[Swift CI] Build Failure: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #184


(no-reply@swift.org) #1

Report

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#184]

Build URL:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/184/
Project:
oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build:
Sat, 29 Apr 2017 05:08:20 -0700
Build duration:
2 hr 4 min

Identified problems:

  • Unexpected pass: This build failed because a test marked as XFAIL unexpectedly passes. This could mean that the cause for the XFAIL is fixed, but it warrants investigation in any case.
  • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:

Changes

  • Commit b7b9245faa00301801be0c23b5eeb1fe91653763 by Ted Kremenek:
    Bump Swift version to 4.0

    • edit: CMakeLists.txt
  • Commit dcc43ec602e40e82b4aef2b054a91babf1340aa3 by Ted Kremenek:
    Adjust to return compatibility version in Swift 3 mode.

    • edit: lib/Basic/Version.cpp
  • Commit 7c664d1835dd4b6b7eda759469b9c77938c1cbf7 by Ted Kremenek:
    Bump default version in build script.

    • edit: utils/build-script
  • Commit 6106868eb1f632a2bd3cf0575b4a42703da5fad6 by Ted Kremenek:
    Force -swift-version 3 for Standard Library and overlays.

    • edit: cmake/modules/SwiftSource.cmake
  • Commit d36b0b6b1fcf7b1f844f4f802f0a440d9c30381d by Ted Kremenek:
    Compile all standard library as Swift 3 mode.

    • edit: cmake/modules/SwiftSource.cmake
  • Commit 3fb6e714110ac0b17f785a724650af8b303f937c by Ted Kremenek:
    Force the benchmark suite to build with -swift-version 3.

    • edit: benchmark/cmake/modules/AddSwiftBenchmarkSuite.cmake
  • Commit 81b00d46ab9e5f4a699e561b1c3635b2aa99c14f by Ted Kremenek:
    These tests explicitly need -swift-version 3.

    • edit: test/stdlib/NSStringAPI.swift
    • edit: test/IDE/complete_crashes.swift
    • edit: test/IDE/complete_func_reference.swift
    • edit: test/IDE/range_info_basics.swift
    • edit: test/attr/attr_objc_clang.swift
    • edit: test/IDE/merge_local_types.swift
    • edit: test/IDE/print_usrs.swift
    • edit: test/attr/attr_dynamic_infer.swift
    • edit: test/IDE/complete_stdlib_optional.swift
    • edit: test/IDE/local_types.swift
    • edit: test/IDE/complete_dynamic_lookup.swift
  • Commit 243f6145521b2ae097b4a8a7c067e27df235a412 by Ted Kremenek:
    Update test to reflect new default is -swift-version 4.

    • edit: test/Driver/swift-version-default.swift
  • Commit 4aa0f46fbbd88738b55e5e9dc0b05a84b432e772 by Ted Kremenek:
    Underlying Swift 3 version is now ‘3.2’

    • edit: test/Serialization/Recovery/crash-recovery.swift
  • Commit 01e09036e19b8bc20da919f4a3a28a5b4ae63796 by Ted Kremenek:
    baseAddress is optional.

    • edit: test/stdlib/TestUUID.swift
  • Commit ad5eab98db5c39ba705256cbbc6c1cf679897026 by Ted Kremenek:
    Force specific tests from validation suit to -swift-version 3.

    • edit: validation-test/Serialization/rdar29694978.swift
    • edit: validation-test/IDE/crashers_2/0010-reference-to-self-in-extension-init.swift
    • edit: validation-test/IDE/crashers_2/0011-complete-protocol-with-initializer.swift
  • Commit cecf00d1f187ed7d1730aa8330659af5aea2cc77 by Itai Ferber:
    Integrate *Codable protocols and associated types

    • edit: stdlib/public/core/GroupInfo.json
    • add: stdlib/public/core/Codable.swift
    • edit: stdlib/public/core/CMakeLists.txt
  • Commit e2318392beed3196260b4f7bc0a8afd561820409 by Itai Ferber:
    Add CodingKey and *codable derived conformance

    • add: test/decl/protocol/special/coding/enum_coding_key_no_raw_type.swift
    • add: lib/Sema/DerivedConformanceCodable.cpp
    • add: test/decl/protocol/special/coding/Inputs/enum_coding_key_multi1.swift
    • add: test/decl/protocol/special/coding/enum_coding_key_empty.swift
    • add: test/decl/protocol/special/coding/enum_coding_key_extension.swift
    • edit: include/swift/AST/KnownProtocols.def
    • edit: lib/Sema/DerivedConformances.cpp
    • add: test/decl/protocol/special/coding/class_codable_computed_vars.swift
    • edit: lib/Sema/TypeCheckProtocol.cpp
    • edit: include/swift/AST/Decl.h
    • edit: include/swift/AST/KnownStdlibTypes.def
    • add: test/decl/protocol/special/coding/Inputs/struct_codable_simple_multi1.swift
    • add: test/decl/protocol/special/coding/enum_coding_key.swift
    • add: test/decl/protocol/special/coding/struct_codable_computed_vars.swift
    • add: test/decl/protocol/special/coding/enum_coding_key_string_raw_type.swift
    • add: lib/Sema/DerivedConformanceCodingKey.cpp
    • add: test/decl/protocol/special/coding/enum_coding_key_int_raw_type.swift
    • add: test/decl/protocol/special/coding/enum_coding_key_extension_multi.swift
    • add: test/decl/protocol/special/coding/Inputs/enum_coding_key_multi2.swift
    • add: test/decl/protocol/special/coding/Inputs/struct_codable_simple_multi2.swift
    • edit: include/swift/AST/KnownIdentifiers.def
    • edit: lib/Sema/TypeChecker.h
    • add: test/decl/protocol/special/coding/Inputs/enum_coding_key_extension_multi2.swift
    • add: test/decl/protocol/special/coding/class_codable_simple.swift
    • edit: lib/Sema/CMakeLists.txt
    • add: test/decl/protocol/special/coding/Inputs/class_codable_simple_multi2.swift
    • add: test/decl/protocol/special/coding/enum_coding_key_partial_implementation.swift
    • add: test/decl/protocol/special/coding/struct_codable_simple_extension.swift
    • add: test/decl/protocol/special/coding/class_codable_simple_extension.swift
    • add: test/decl/protocol/special/coding/class_codable_simple_multi.swift
    • edit: lib/IRGen/GenMeta.cpp
    • add: test/decl/protocol/special/coding/class_codable_inheritance.swift
    • add: test/decl/protocol/special/coding/struct_codable_simple.swift
    • add: test/decl/protocol/special/coding/Inputs/enum_coding_key_extension_multi3.swift
    • add: test/decl/protocol/special/coding/struct_codable_simple_multi.swift
    • add: test/decl/protocol/special/coding/Inputs/class_codable_simple_multi1.swift
    • edit: include/swift/AST/DiagnosticsSema.def
    • edit: lib/Sema/DerivedConformances.h
    • add: test/decl/protocol/special/coding/Inputs/enum_coding_key_extension_multi1.swift
    • edit: lib/AST/Decl.cpp
    • add: test/decl/protocol/special/coding/enum_coding_key_multi.swift
    • edit: lib/Sema/TypeCheckType.cpp
  • Commit 22185d237fd9a426b63876d82a6efdc8ba200c15 by Itai Ferber:
    CodingKey/*Codable tests don’t need ObjC interop

    • edit: test/decl/protocol/special/coding/struct_codable_simple.swift
    • edit: test/decl/protocol/special/coding/class_codable_computed_vars.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_no_raw_type.swift
    • edit: test/decl/protocol/special/coding/Inputs/enum_coding_key_extension_multi2.swift
    • edit: test/decl/protocol/special/coding/struct_codable_simple_extension.swift
    • edit: test/decl/protocol/special/coding/class_codable_inheritance.swift
    • edit: test/decl/protocol/special/coding/class_codable_simple.swift
    • edit: test/decl/protocol/special/coding/class_codable_simple_extension.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_partial_implementation.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_extension.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_string_raw_type.swift
    • edit: test/decl/protocol/special/coding/Inputs/enum_coding_key_multi1.swift
    • edit: test/decl/protocol/special/coding/struct_codable_computed_vars.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_int_raw_type.swift
    • edit: test/decl/protocol/special/coding/Inputs/class_codable_simple_multi1.swift
    • edit: test/decl/protocol/special/coding/Inputs/struct_codable_simple_multi1.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key.swift
    • edit: test/decl/protocol/special/coding/enum_coding_key_empty.swift
  • Commit b8d135afac8ae18863d5b8424a981791f109563b by Ted Kremenek:
    Enhance swift-ide-test to accept -swift-version multiple times.

    • edit: tools/swift-ide-test/swift-ide-test.cpp
  • Commit be5d87a8c6d9c40f990ccabe812a45237994130a by Ted Kremenek:
    Add “-swift-version X” to %target-swift-ide-test substitution.

    • edit: test/lit.cfg
  • Commit 8eed9ac58e4605ef55b2e5a8ee277cf705937bb3 by Ted Kremenek:
    Remove hard passing -swift-version X for some tests.

    • edit: test/IDE/complete_dynamic_lookup.swift
    • edit: test/IDE/complete_stdlib_optional.swift
    • edit: test/IDE/range_info_basics.swift
    • edit: test/IDE/complete_crashes.swift
    • edit: test/attr/attr_dynamic_infer.swift
    • edit: test/IDE/complete_func_reference.swift
    • edit: test/attr/attr_objc_clang.swift
    • edit: test/IDE/print_usrs.swift
  • Commit e2328885c17475decc5dd19f5274f648feffd8a0 by Nate Cook:
    [stdlib] Dictionary/Set enhancements

    • edit: stdlib/public/core/HashedCollections.swift.gyb
    • add: validation-test/stdlib/HashedCollectionFilter3.swift
    • edit: validation-test/stdlib/Dictionary.swift
    • add: validation-test/stdlib/HashedCollectionFilter4.swift
    • edit: validation-test/stdlib/Set.swift
    • edit: test/api-digester/source-stability.swift.expected
  • Commit c515b53fccd5548dab89c517ccc9371518d0ffc6 by Itai Ferber:
    Remove unnecessary enum case check

    • edit: lib/AST/Decl.cpp
  • Commit 53d82b19238e49141d735be3a7b6d3887bd9fe65 by Itai Ferber:
    Rename sequence type to avoid ambiguity

    • edit: stdlib/public/core/Codable.swift
  • Commit 3e6eb8f20a0368275d17a6196b6bfd0ad6c2ecdb by Itai Ferber:
    Derive encoding an empty container by default

    • edit: lib/Sema/DerivedConformanceCodable.cpp
  • Commit bdfa92703d81a9895b8c80d8c09bb0f2c988f9ba by Itai Ferber:
    Fix crash in AST printing

    • edit: lib/AST/ASTPrinter.cpp
  • Commit 4c2320724e4a48a0f4df0e2b38a9014629f5adfb by Itai Ferber:
    Fix init(from:) required condition

    • edit: lib/Sema/DerivedConformanceCodable.cpp
  • Commit cc2dc794356dae67cc07778db95f5b0cf477e103 by Erik Eckstein:
    fix typo in comment

    • edit: lib/SILOptimizer/Analysis/ArraySemantic.cpp
  • Commit 62be182cacb7fef24c66b1a0d8069767041f7ee5 by Erik Eckstein:
    benchmarks: add a comment and use more meaningful numbers

    • edit: benchmark/single-source/SortLargeExistentials.swift
  • Commit 1cfce451470968a95ca5068c869545858c4c6349 by Dave Abrahams:
    [stdlib] UnicodeDecoders: generalization preparing for UTF16

    • edit: test/Prototypes/UnicodeDecoders.swift
  • Commit 781082b23760fa8fe4b2a6a1bef201f26d0c0df8 by Doug Gregor:
    Re-enabled Lazy test.

    • edit: validation-test/stdlib/Lazy.swift.gyb
  • Commit 8ad6aa4e0dbe6ce82df4876806f230ff5e5fbd37 by Nathan Hawes:
    [migrator] Add pass for API type changes

    • add: test/Migrator/Inputs/cities.swift
    • add: test/Migrator/wrap_optional.swift.expected
    • edit: lib/Migrator/Migrator.cpp
    • edit: lib/Migrator/SyntacticMigratorPass.cpp
    • edit: include/swift/Index/Index.h
    • edit: lib/Migrator/EditorAdapter.cpp
    • edit: include/swift/Migrator/EditorAdapter.h
    • edit: lib/Index/Index.cpp
    • edit: include/swift/IDE/APIDigesterData.h
    • add: test/Migrator/wrap_optional.swift
    • edit: test/Migrator/API.json
  • Commit 9ebc4caa411c184b20f8e095407cf91f9f5fcd99 by Doug Gregor:
    [Type checker] Warn about unavailable witnesses used to satisfy a

    • edit: include/swift/AST/DiagnosticsSema.def
    • edit: test/decl/protocol/req/unavailable.swift
    • edit: lib/Sema/TypeCheckProtocol.cpp
  • Commit 42c59554a0e980ab83f52eda41140c4b2c465834 by Robert Widmann:
    Introduce the Space Engine

    • edit: include/swift/AST/ASTPrinter.h
    • edit: lib/AST/ASTPrinter.cpp
    • edit: include/swift/AST/DiagnosticsSema.h
    • edit: include/swift/AST/DiagnosticsSema.def
    • edit: lib/SILOptimizer/Mandatory/DataflowDiagnostics.cpp
    • edit: lib/Sema/TypeCheckStmt.cpp
  • Commit 39494b2ba2057c4750f057afca46bb8e2da06c91 by Robert Widmann:
    Rearrange test code for exhaustiveness

    • edit: test/Parse/switch_incomplete.swift
    • edit: test/Index/expressions.swift
    • edit: test/stmt/switch_stmt2.swift
    • edit: test/ClangImporter/enum-new.swift
    • edit: test/SILGen/sil_locations.swift
    • edit: test/SourceKit/CursorInfo/cursor_info_expressions.swift
    • edit: test/FixCode/fixits-switch.swift
    • edit: test/FixCode/fixits-empty-switch.swift.result
    • edit: test/Parse/invalid.swift
    • edit: test/ClangImporter/ctypes_parse.swift
    • edit: test/Sema/availability_versions.swift
    • edit: test/ClangImporter/enum.swift
    • edit: test/ClangImporter/swift2_warnings.swift
    • edit: lib/Sema/CMakeLists.txt
    • edit: test/stmt/statements.swift
    • edit: test/stmt/switch_stmt1.swift
    • delete: test/SILOptimizer/switch.swift
    • edit: test/SILOptimizer/unreachable_code.swift
    • edit: lib/Sema/TypeChecker.h
    • edit: lib/Sema/TypeCheckStmt.cpp
    • edit: test/expr/unary/selector/selector.swift
    • edit: test/Parse/switch.swift
    • add: lib/Sema/TypeCheckSwitchStmt.cpp
    • edit: test/ClangImporter/enum-error.swift
    • edit: test/FixCode/fixits-empty-switch.swift
    • edit: test/Parse/matching_patterns.swift
    • edit: test/Constraints/patterns.swift
    • add: test/Sema/exhaustive_switch.swift
    • edit: test/ClangImporter/enum-dataflow.swift
    • edit: include/swift/AST/DiagnosticsSema.def
    • edit: test/NameBinding/reference-dependencies.swift
    • edit: validation-test/Driver/Dependencies/rdar25405605.swift
    • edit: test/FixCode/fixits-switch.swift.result
    • edit: test/SILGen/switch.swift
  • Commit ae591c0538525bf2b536b9588157836c031c70b9 by Ted Kremenek:
    Remove hard-coding of -swift-version 3 in some validation tests.

    • edit: validation-test/Serialization/rdar29694978.swift
    • edit: validation-test/IDE/crashers_2/0010-reference-to-self-in-extension-init.swift
    • edit: validation-test/IDE/crashers_2/0011-complete-protocol-with-initializer.swift
  • Commit 157133db50f3fd73377689e5852a6654b21a6c1e by Ted Kremenek:
    Pass -swift-version X for %target-swift-frontend

    • edit: test/lit.cfg
  • Commit 4ff254de972cfe2bd7c42b9d00f154526799bd00 by Nathan Hawes:
    Move canDeclProvideDefaultImplementationFor() from libIDE into libIndex

    • edit: lib/Index/Index.cpp
    • edit: lib/Migrator/SyntacticMigratorPass.cpp
    • add: include/swift/Index/Utils.h
    • edit: include/swift/Index/Index.h
    • edit: include/swift/Sema/IDETypeChecking.h
    • edit: lib/IDE/IDETypeChecking.cpp
  • Commit 1dfab989315f2ac7c949dbc9b501159130bcb834 by Robert Widmann:
    Look through parens to the semantic pattern below

    • edit: lib/Sema/TypeCheckSwitchStmt.cpp
  • Commit 48eb9373b964b887b38bf20e962086b2017dde61 by Ted Kremenek:
    Revert “Pass -swift-version X for %target-swift-frontend”

    • edit: test/lit.cfg
  • Commit 42ea9384a023aa47d15d71a88e2c9fe0f2b74e07 by Ted Kremenek:
    Include config.swift_test_options in config.target_swift_frontend for

    • edit: test/lit.cfg
  • Commit 4d12647e34c23efd90a5e444b043f69bc90fe114 by github:
    Revert "Add reproducibility tests for -emit-module, -emit-sib,

    • delete: test/reproducible-builds/swiftc-emit-module.swift
    • delete: test/reproducible-builds/swiftc-emit-sil.swift
    • delete: test/reproducible-builds/swiftc-emit-sib.swift
    • delete: test/reproducible-builds/swiftc-emit-sibgen.swift
    • delete: test/reproducible-builds/swiftc-emit-tbd.swift
  • Commit 54d71fb3ca440739814bbe436c10e1eebee448da by Arnold Schwaighofer:
    DebugInfo: Disable test

    • edit: test/DebugInfo/ErrorVar.swift
  • Commit 66ed615d78e01111101212a6683cb15f9473f4a9 by Arnold Schwaighofer:
    Disable test/Misc/tbi.swift

    • edit: test/Misc/tbi.swift
  • Commit a85aedebd49d8af41c4b0847a0a54918c3b89b1a by Devin Coughlin:
    [Exclusivity] Add test for per-thread dynamic enforcement.

    • edit: test/Interpreter/enforce_exclusive_access.swift
  • Commit b7ba524607ca382d8d7364b493b8f8eac0815f7d by Erik Eckstein:
    Add a test case for non-ascii module names.

    • add: test/stdlib/UnicodeMetadata.swift
  • Commit 1731250dac84189815294a9a79286f1606d524ef by Roman Levenstein:
    [sil-open-archetypes-tracker] Add type dependent operands to more

    • edit: include/swift/SIL/SILInstruction.h
    • edit: include/swift/SIL/SILBuilder.h
    • edit: test/Interpreter/subclass_existentials.swift
    • edit: lib/SIL/SILInstructions.cpp
  • Commit 373ec73181cac4042d1144f961d776c0ab9ac3b3 by Adrian Prantl:
    Fix XFAILed testcase by re-arranging CHECK lines.

    • edit: test/DebugInfo/ErrorVar.swift
  • Commit 0aaceb60d3fba64560bd3698a8bfd0b3d06a64ce by Dave Abrahams:
    [stdlib] UnicodeDecoders: handle UTF16

    • edit: test/Prototypes/UnicodeDecoders.swift
  • Commit e1e67844a845f4be8c9061de862800eb3713aa4f by Itai Ferber:
    Split RawRep extensions for Encodable + Decodable

    • edit: stdlib/public/core/Codable.swift
  • Commit a9b6181ebd38246fb304f8a193dc7e8f269f8674 by github:
    [Serialization] Drop support for serializing LValueType. (#9080)

    • edit: lib/Serialization/Deserialization.cpp
    • edit: lib/Serialization/Serialization.cpp
    • edit: include/swift/Serialization/ModuleFormat.h
    • edit: include/swift/Serialization/DeclTypeRecordNodes.def
  • Commit 946b776e371717f89ba5b4225efcbec5eb07d1b0 by github:
    [stdlib] One-sided ranges and RangeExpression (#8710)

    • edit: stdlib/public/core/Substring.swift.gyb
    • edit: test/Generics/slice_test.swift
    • edit: test/stdlib/RangeDiagnostics.swift
    • edit: test/decl/func/operator.swift
    • edit: test/IDE/complete_enum_elements.swift
    • edit: test/stdlib/RangeTraps.swift
    • edit: stdlib/public/core/Policy.swift
    • edit: stdlib/public/core/StringRangeReplaceableCollection.swift.gyb
    • edit: stdlib/public/core/Range.swift.gyb
    • edit: test/IDE/print_type_interface.swift
    • edit: stdlib/public/core/RangeReplaceableCollection.swift.gyb
    • edit: test/Constraints/diagnostics.swift
  • Commit 3130c3cbd7f779aa3b7b22b2d307bff6dd09bfdc by Slava Pestov:
    AST: Remove an overload of GenericSignature::getSubstitutions()

    • edit: lib/SILOptimizer/Utils/Generics.cpp
    • edit: lib/SILGen/SILGenConstructor.cpp
    • edit: lib/Sema/TypeCheckType.cpp
    • edit: lib/SIL/TypeLowering.cpp
    • edit: lib/AST/GenericEnvironment.cpp
    • edit: include/swift/AST/GenericSignature.h
    • edit: lib/Sema/CSApply.cpp
    • edit: lib/AST/GenericSignature.cpp
  • Commit 221df61a6e08c7649fc8aaff1bb07e01139ba304 by Slava Pestov:
    SILOptimizer: Clean up SubstitutionMap usage in devirtualizer

    • edit: lib/SILOptimizer/Utils/Devirtualize.cpp
  • Commit 433c192bf159caa6935b3e28633ab7affc93a475 by Itai Ferber:
    Temporarily fix failing SourceKit test

    • edit: test/SourceKit/DocSupport/doc_clang_module.swift.response
  • Commit ecae403c240f71b120543bbc0154bda6cf4ad8dd by Vedant Kumar:
    [Coverage] Emit a profiler increment in ObjC destructors

    • add: test/SILGen/coverage_deinit.swift
    • edit: lib/SILGen/SILGenDestructor.cpp
  • Commit b5292f04f8cb464ef08693cef7c3288513e0c5dc by Graydon Hoare:
    Add an assortment of new “always-on” metrics.

    • edit: lib/Serialization/Deserialization.cpp
    • edit: lib/AST/GenericSignatureBuilder.cpp
    • edit: lib/Basic/Statistic.cpp
    • edit: lib/AST/Decl.cpp
    • edit: lib/FrontendTool/FrontendTool.cpp
    • edit: include/swift/AST/ASTContext.h
    • edit: lib/Sema/TypeCheckDecl.cpp
    • edit: lib/Sema/TypeCheckType.cpp
    • edit: lib/AST/DeclContext.cpp
    • edit: lib/ClangImporter/ImportDecl.cpp
    • edit: include/swift/Basic/Statistic.h
    • edit: lib/Sema/TypeCheckStmt.cpp
    • edit: lib/Sema/ConstraintSystem.cpp
  • Commit 46a3058da27ce9484563aca5d7db0a6fb5e14e8d by Norio Nomura:
    [Preset] include sourcekit-inproc in default install on Linux

    • edit: utils/build-presets.ini
  • Commit a93bddf019b0a3f99fcc8fef7bf5a9f2a7bc767b by Norio Nomura:
    Set rpath to libsourcekitdInProc.so on Linux

    • edit: tools/SourceKit/CMakeLists.txt
  • Commit a07b1d6c504f5c905c4483b388f60da308900436 by Vedant Kumar:
    [Coverage] Require objc_interop for an ObjC destructor test

    • edit: test/SILGen/coverage_deinit.swift
  • Commit 76dc4210c4371efb29ff932f09bea4cf49f3cec1 by Nathan Hawes:
    Change %swift -> %target-swift-frontend

    • edit: test/Migrator/wrap_optional.swift
    • edit: test/Migrator/wrap_optional.swift.expected
  • Commit 93435d17d6ccdc163b893f933c9703a147b6ec68 by Doug Gregor:
    [Substitution Map] Handle substitutions of generic parameters made

    • edit: lib/AST/SubstitutionMap.cpp
    • edit: lib/AST/ASTContext.cpp
    • add: validation-test/compiler_crashers_2_fixed/0092-se-0154.swift
  • Commit 6ef76a92f4550c8f801991f3e61a81473ba68473 by Doug Gregor:
    [AST] Use flat array storage for SubstitutionMap’s replacement types.

    • edit: include/swift/AST/SubstitutionMap.h
    • edit: lib/AST/SubstitutionMap.cpp
  • Commit ae49b6939b34e65afce170c4835e48f4226b80b1 by Erik Eckstein:
    Mangling: fix mangling of functions with a single empty tuple argument

    • edit: test/SILGen/arguments_as_tuple_overloads.swift
    • edit: lib/AST/ASTMangler.cpp
    • edit: test/Demangle/Inputs/manglings.txt
  • Commit 9c80b23953fd5bf30a401a14f32e8a438c6de995 by Greg Parker:
    [stdlib] Make StdlibUnittest nullability-agnostic for ObjC runtime

    • edit: stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb
    • edit: stdlib/private/StdlibUnittestFoundationExtras/StdlibUnittestFoundationExtras.swift
  • Commit bf52ff032aeef60b438cb89ce86cd73d4c1c6488 by David Farler:
    [Migrator] Conservative and Minimal @objc inference workflows

    • edit: include/swift/Migrator/FixitFilter.h
    • edit: include/swift/Option/Options.td
    • edit: test/Migrator/wrap_optional.swift.expected
    • edit: test/Migrator/member.swift
    • edit: test/Migrator/rename-init.swift
    • add: test/Migrator/conservative_objc_inference.swift
    • edit: lib/Migrator/Migrator.cpp
    • edit: test/Migrator/null_migration.swift
    • edit: lib/Driver/ToolChains.cpp
    • add: test/Migrator/Inputs/conservative_objc_inference.swift
    • edit: lib/Frontend/CompilerInvocation.cpp
    • add: test/Migrator/minimal_objc_inference.swift
    • edit: test/Migrator/rename-init.swift.expected
    • add: test/Driver/driver_migration.swift
    • add: test/Migrator/Inputs/minimal_objc_inference.swift
    • delete: test/Migrator/objc_inference.swift
    • edit: test/Migrator/property.swift
    • edit: test/Migrator/rename.swift.expected
    • edit: test/Migrator/wrap_optional.swift
    • edit: include/swift/Migrator/MigratorOptions.h
    • edit: test/Migrator/property.swift.expected
    • edit: test/Migrator/rename.swift
    • edit: test/Migrator/member.swift.expected
  • Commit f469fb73db40f7ba5e2a4953f9ba768e825998b7 by Andrew Trick:
    [Exclusivity] Allow AccessEnforcementSelection to run before DI.

    • edit: lib/SILOptimizer/Mandatory/AccessEnforcementSelection.cpp
  • Commit 8187aae1b87369c4ce0cbb8a021365bc6f07eef9 by Andrew Trick:
    [Exclusivity] Handle copy_addr+destroy_addr folding with end_access

    • edit: lib/SIL/SILBuilder.cpp
    • edit: test/SILOptimizer/allocbox_to_stack_ownership.sil
  • Commit 2336a8786651897c22ae56852a83f45c3e7efbfd by Andrew Trick:
    [Exclusivity] Enable access markers for the entire -Onone pipeline.

    • edit: include/swift/AST/DiagnosticsFrontend.def
    • edit: lib/Frontend/CompilerInvocation.cpp
    • edit: test/SILOptimizer/access_marker_mandatory.swift
    • edit: lib/SILOptimizer/Mandatory/AccessEnforcementSelection.cpp
    • edit: lib/SILOptimizer/PassManager/PassPipeline.cpp
    • edit: test/SILOptimizer/access_marker_elim.sil
    • edit: test/SILOptimizer/access_enforcement_selection.swift
    • edit: lib/SILOptimizer/Transforms/AllocBoxToStack.cpp
    • edit: lib/SILOptimizer/Mandatory/AccessMarkerElimination.cpp
  • Commit 45967ceb4f37294c24dfbc35e1980e3604706243 by Andrew Trick:
    [Exclusivity] Update tests for access markers.

    • edit: test/SILGen/addressors.swift
    • edit: test/SILOptimizer/access_marker_mandatory.swift
    • edit: test/SILOptimizer/definite_init_failable_initializers.swift
    • edit: test/Interpreter/enforce_exclusive_access.swift
    • edit: test/SILGen/unmanaged.swift
  • Commit 8ecc3e31cf73c67ba1bc3edbdc50025f1069451f by Andrew Trick:
    [Exclusivity] access enforcement SIL tests.

    • add: test/SILOptimizer/access_enforcement_selection.sil
  • Commit 35c426e4dbd284c919b27386878c7b48f354bd3d by Tim Northover:
    Fix warning in release builds

    • edit: lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  • Commit 5a11f4256087e97452eb210532c7df1657c18cd5 by Akira Hatanaka:
    [ObjCARC] Do not move a release between a call and a

    • edit: lib/Transforms/ObjCARC/ObjCARC.h
    • edit: lib/Transforms/ObjCARC/PtrState.cpp
    • edit: test/Transforms/ObjCARC/rv.ll
  • Commit 2f15ddb3c69ac66853a56c4e141ed4f9e04bd081 by Alex Lorenz:
    [ObjC] Disallow vector parameters and return values in Objective-C

    • add: test/SemaObjC/x86-method-vector-values.m
    • edit: lib/AST/DeclBase.cpp
    • edit: lib/Sema/SemaDeclObjC.cpp
    • edit: include/clang/Basic/DiagnosticSemaKinds.td
    • edit: include/clang/AST/DeclBase.h
  • Commit 814aaf1fb028495762929c38d10dfbdf57e79509 by Alex Lorenz:
    [index] Handle vector types in USR generator

    • edit: lib/Index/USRGeneration.cpp
    • edit: test/Index/usrs.cpp
  • Commit 130b09a88423985fb3aec82b27eb0fe264a1427b by Alex Lorenz:
    [Sema] Avoid an invalid redefinition error that was presented for of a

    • edit: include/clang/Sema/Sema.h
    • edit: test/SemaCXX/typo-correction.cpp
    • edit: lib/Sema/SemaDecl.cpp
  • Commit 9f57e4c0a5a888a223b3a626ec62c07c8e4eb218 by Alex Lorenz:
    Use the -Wunknown-warning-option group for the “unknown warning group”

    • edit: include/clang/Basic/DiagnosticLexKinds.td
    • edit: test/Preprocessor/pragma_diagnostic.c
  • Commit b5fdfa69ff5ecd97133375bec639fe74ed6b1bab by Bruno Cardoso Lopes:
    [Modules] Refactor logic for incomplete umbrella warnings. NFC

    • edit: lib/Lex/PPLexerChange.cpp
    • edit: include/clang/Lex/Preprocessor.h
  • Commit fccae479494d640737bb823be7e71e1e0f0699e8 by Bruno Cardoso Lopes:
    [Modules] Improve diagnostics for incomplete umbrella

    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/PrivateHeaders/Baz.h
    • add: test/Modules/incomplete-umbrella.m
    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/Headers/Bar.h
    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/Modules/module.private.modulemap
    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/Headers/FooPublic.h
    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/PrivateHeaders/Foo.h
    • add: test/Modules/Inputs/incomplete-umbrella/Foo.framework/Modules/module.modulemap
    • edit: lib/Lex/PPLexerChange.cpp
  • Commit 9dce21c5d4a8c6045b9ef21a948af5f2fb031ad0 by Bruno Cardoso Lopes:
    [ASTImporter] Move structural equivalence context to its own file. NFCI

    • add: include/clang/AST/ASTStructuralEquivalence.h
    • add: lib/AST/ASTStructuralEquivalence.cpp
    • edit: lib/AST/CMakeLists.txt
    • edit: lib/AST/ASTImporter.cpp
  • Commit f258c834253f21918aaedbb256d6795556c70224 by Akira Hatanaka:
    [CodeGen][ObjC] Don’t retain captured Objective-C pointers at block

    • edit: lib/CodeGen/CGBlocks.cpp
    • edit: test/CodeGenObjC/arc-blocks.m
    • edit: lib/CodeGen/CodeGenFunction.h
    • edit: lib/CodeGen/CGObjC.cpp
    • edit: test/CodeGenObjC/arc-foreach.m
  • Commit f6823351e17b694253e01936733c64b2495d8c21 by Akira Hatanaka:
    Revert f258c834253f21918aaedbb256d6795556c70224.

    • edit: lib/CodeGen/CodeGenFunction.h
    • edit: test/CodeGenObjC/arc-blocks.m
    • edit: lib/CodeGen/CGObjC.cpp
    • edit: lib/CodeGen/CGBlocks.cpp
    • edit: test/CodeGenObjC/arc-foreach.m
  • Commit b21a7266b78524fc78a10ab425555eb08e6afc4b by Akira Hatanaka:
    [CodeGen][ObjC] Use the type of the captured field of the enclosing

    • edit: lib/CodeGen/CGBlocks.cpp
    • edit: test/CodeGenObjCXX/lambda-expressions.mm
  • Commit 0e16e32c24143b25f98db2bbe5f60dc783531be5 by Akira Hatanaka:
    [CodeGen][ObjC] Don’t retain captured Objective-C pointers at block

    • edit: test/CodeGenObjC/arc-foreach.m
    • edit: test/CodeGenObjC/arc-blocks.m
    • edit: lib/CodeGen/CGObjC.cpp
    • edit: lib/CodeGen/CGBlocks.cpp
    • edit: lib/CodeGen/CodeGenFunction.h
  • Commit 57d825545cb7374b717dccf1e46e84f81fc6e75e by Duncan P. N. Exon Smith:
    [Objective-C] C++ Classes with __weak Members non-POD Types when using

    • add: test/CodeGenObjCXX/objc-weak.mm
    • edit: lib/AST/DeclCXX.cpp
    • edit: lib/Sema/SemaDeclCXX.cpp
  • Commit 673953053623c495944c66f64ea9cfcd81dc2d56 by Duncan P. N. Exon Smith:
    [Objective-C] Fix __weak type traits with -fobjc-weak

    • edit: lib/Sema/SemaExprCXX.cpp
    • edit: lib/AST/Type.cpp
    • add: test/SemaObjCXX/objc-weak-type-traits.mm
  • Commit f9a340d710c9e37cfec223336c4f55d958de8395 by Duncan P. N. Exon Smith:
    [Objective-C] Fix “repeated use of weak” warning with -fobjc-weak

    • edit: lib/Sema/SemaExpr.cpp
    • edit: lib/Sema/SemaPseudoObject.cpp
    • edit: test/SemaObjC/arc-repeated-weak.mm
    • edit: include/clang/AST/Type.h
    • edit: lib/Sema/SemaExprObjC.cpp
    • edit: lib/Sema/SemaDecl.cpp
    • edit: lib/AST/Type.cpp
    • edit: lib/Sema/SemaExprMember.cpp
  • Commit 777d7942b3806324e3feddc3be0ceb4df78a80cb by Duncan P. N. Exon Smith:
    [Objective-C] Fix “weak-unavailable” warning with -fobjc-weak

    • edit: test/SemaObjC/arc-unavailable-for-weakref.m
    • edit: test/SemaObjCXX/arc-unavailable-for-weakref.mm
    • edit: include/clang/Sema/Sema.h
    • edit: include/clang/Basic/LangOptions.h
    • edit: lib/Sema/SemaExpr.cpp
    • edit: lib/Sema/SemaExprObjC.cpp
    • edit: lib/Sema/SemaCast.cpp
    • edit: lib/Sema/SemaExprCXX.cpp
    • edit: lib/Sema/SemaPseudoObject.cpp
  • Commit 7ae4454eeee45738d7dc9121ee2c85c524692830 by Duncan P. N. Exon Smith:
    [Objective-C] Miscellaneous -fobjc-weak Fixes

    • edit: lib/Sema/SemaDecl.cpp
    • edit: lib/Sema/SemaCast.cpp
    • edit: lib/Sema/SemaInit.cpp
    • edit: lib/Sema/SemaDeclCXX.cpp
    • add: test/SemaObjCXX/objc-weak.mm

(Mark Lacey) #2

Ben / Robert, I bisected the failures here and it looks like they are due to these two changes:

Robert, The XFAILed FP test that is now passing (and thus…failing) is due to:

commit 42c59554a0e980ab83f52eda41140c4b2c465834
Author: Robert Widmann <devteam.codafi@gmail.com>

···

Date: Tue Apr 4 14:49:41 2017 -0400

    Introduce the Space Engine

Ben, the range failure appears to be due to:

commit 946b776e371717f89ba5b4225efcbec5eb07d1b0
Author: Ben Cohen <airspeedswift@users.noreply.github.com>
Date: Fri Apr 28 12:59:04 2017 -0700

    [stdlib] One-sided ranges and RangeExpression (#8710)

Mark

On Apr 30, 2017, at 5:27 AM, no-reply@swift.org wrote:

New issue found!

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#185]

Build URL: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/
Project: oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build: Sun, 30 Apr 2017 03:47:00 -0700
Build duration: 1 hr 40 min
Identified problems:

Unexpected pass: This build failed because a test marked as XFAIL unexpectedly passes. This could mean that the cause for the XFAIL is fixed, but it warrants investigation in any case.
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#1511526070b011c97a-0462-424c-ac47-5640e6148d79>
Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#-2067387497fca400bf-2f4a-462e-b517-e058d770b2d7>
Changes

Commit 62279325193350328f9a4d27fa292195f5db4d26 by github:
[stdlib] Custom Reverse[RandomAccess]Collection.Iterator

edit: stdlib/public/core/Reverse.swift

Commit 3c5b393e0c07c222950e626e5c4553358e22365d by Mark Lacey:
[Constraint solver] Rework how we select the next disjunction to visit.

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift

Commit 2ce58c1eb315ad3083c30fed2fa7cbde305092ea by Itai Ferber:
Add JSON and property list encoders and decoders

add: stdlib/public/SDK/Foundation/Codable.swift
edit: stdlib/public/SDK/Foundation/CMakeLists.txt
edit: stdlib/public/SDK/Foundation/NSError.swift
add: stdlib/public/SDK/Foundation/PlistEncoder.swift
add: stdlib/public/SDK/Foundation/JSONEncoder.swift

Commit f7cd0a6343969889ed84bcbd44cd15262c9349b0 by Itai Ferber:
Add Codable conformance to Array

edit: stdlib/public/core/Codable.swift

Commit 44682f7a721ce80706c88a8b7d316f2f4f94c49b by Itai Ferber:
Ensure all Dates can always round-trip by default

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c6f8834d2679646981f46903b3125383352d46c5 by Itai Ferber:
Remove unnecessary CodingKey implementation

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c5fc1e3f78c3cf0fc94ff9f0e9276266adce8014 by Itai Ferber:
Use encode(contentsOf:) instead of a loop

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit d177bdf748c5e86f06e12852317a7b73b51b5248 by Itai Ferber:
Add preliminary {JSON,Plist}Encoder tests

add: test/stdlib/TestJSONEncoder.swift
add: test/stdlib/TestPlistEncoder.swift

Commit 328ebe856776fe63df524eb6d4fcf6199cbaa785 by github:
Revert "[stdlib] Dictionary/Set enhancements"

edit: validation-test/stdlib/Set.swift
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/api-digester/source-stability.swift.expected
edit: validation-test/stdlib/Dictionary.swift
delete: validation-test/stdlib/HashedCollectionFilter3.swift
delete: validation-test/stdlib/HashedCollectionFilter4.swift

Commit 1de530e229ab5736980f2e9162c2fe7dc97fe82c by github:
Revert "Improve disjunction selection"

edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
delete: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift

Commit 1163ea7c7a7c0caa744450ce8c4f3fe06724c184 by github:
[stdlib] swapAt method (#9119)

edit: stdlib/public/core/CollectionAlgorithms.swift.gyb
edit: stdlib/public/core/SequenceAlgorithms.swift.gyb
edit: stdlib/public/core/Reverse.swift
edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/MutableCollection.swift
edit: stdlib/public/core/Sort.swift.gyb
edit: stdlib/public/core/ContiguousArrayBuffer.swift
edit: stdlib/public/core/StringCharacterView.swift

Commit 7778fc2fb359ff92b956fa6f146ecbd55a935129 by Itai Ferber:
Fix encoding container linker errors

edit: stdlib/public/core/Codable.swift

Commit 68525ce45042bf7316a507bf2fb6975e1be2333e by Bob Wilson:
swift-stdlib-tool is not a shell script and can be stripped

edit: utils/build-script-impl

Commit bcdf09d166a7b6c32f642d67d40a03b50a96884b by Mark Lacey:
[stdlib] Disambiguate a subscript operation.

edit: stdlib/public/core/Substring.swift.gyb

Commit 253d0080efdbe8b4788cea48ab5782a6bf3949ce by Robert Widmann:
Improve diagnostic for attempted initialization of non-nominal types

edit: include/swift/AST/DiagnosticsSema.def
edit: lib/Sema/CSDiag.cpp
add: test/decl/init/nonnominal_init.swift

Commit ecfa406fc580df48260c6ad606bfd11c10f6ad4c by Mark Lacey:
Re-instate "Improve disjunction selection"

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
edit: validation-test/stdlib/Set.swift

Commit 40c89048ba68d4aa182a0420b7910596b0427b19 by Argyrios Kyrtzidis:
[index] Make sure that we index implicit constructors

edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/Index/Inputs/cross_language.m
edit: tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp
edit: lib/AST/SourceEntityWalker.cpp
edit: test/SourceKit/Indexing/index_is_test_candidate_objc.swift.response
edit: test/SourceKit/Indexing/rdar_21602898.swift.response
edit: lib/Index/Index.cpp
edit: test/SourceKit/Indexing/Inputs/test_module.index.response
edit: test/Index/index_module.swift
edit: lib/Migrator/SyntacticMigratorPass.cpp
edit: test/IDE/reconstruct_type_from_mangled_name.swift
edit: test/Index/cross_language.swift
edit: test/SourceKit/DocSupport/doc_source_file.swift.response
edit: test/SourceKit/Indexing/Inputs/cycle-depend/A.response
edit: test/SourceKit/Indexing/sr_3815.swift.response
edit: test/Index/kinds.swift
edit: test/SourceKit/Indexing/index_forbid_typecheck.swift.response

Commit b48377bb142edde165a8734aa54f3c8d36cecab3 by Argyrios Kyrtzidis:
[test] Update linux test:

edit: test/SourceKit/Indexing/index_is_test_candidate.swift.response

Commit 9e38a8efea6771f94643b900b1f3d2f0cadca56e by Mark Lacey:
Do not hard-code a result type that the type checker will fill in.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp

Commit de10c41915bb53713fc9cea8496e0b5fe0d669aa by Mark Lacey:
Fix another case where the type checker will set the correct types.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp


(Arnold Schwaighofer) #3

Thank you Mark!

https://github.com/apple/swift/pull/9139

<rdar://problem/31909976>

···

On Apr 30, 2017, at 2:55 PM, Mark Lacey <mark.lacey@apple.com> wrote:

Ben / Robert, I bisected the failures here and it looks like they are due to these two changes:

Robert, The XFAILed FP test that is now passing (and thus…failing) is due to:

commit 42c59554a0e980ab83f52eda41140c4b2c465834
Author: Robert Widmann <devteam.codafi@gmail.com <mailto:devteam.codafi@gmail.com>>
Date: Tue Apr 4 14:49:41 2017 -0400

    Introduce the Space Engine

Ben, the range failure appears to be due to:

commit 946b776e371717f89ba5b4225efcbec5eb07d1b0
Author: Ben Cohen <airspeedswift@users.noreply.github.com <mailto:airspeedswift@users.noreply.github.com>>
Date: Fri Apr 28 12:59:04 2017 -0700

    [stdlib] One-sided ranges and RangeExpression (#8710)

Mark

On Apr 30, 2017, at 5:27 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

New issue found!

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#185]

Build URL: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/
Project: oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build: Sun, 30 Apr 2017 03:47:00 -0700
Build duration: 1 hr 40 min
Identified problems:

Unexpected pass: This build failed because a test marked as XFAIL unexpectedly passes. This could mean that the cause for the XFAIL is fixed, but it warrants investigation in any case.
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#1511526070b011c97a-0462-424c-ac47-5640e6148d79>
Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#-2067387497fca400bf-2f4a-462e-b517-e058d770b2d7>
Changes

Commit 62279325193350328f9a4d27fa292195f5db4d26 by github:
[stdlib] Custom Reverse[RandomAccess]Collection.Iterator

edit: stdlib/public/core/Reverse.swift

Commit 3c5b393e0c07c222950e626e5c4553358e22365d by Mark Lacey:
[Constraint solver] Rework how we select the next disjunction to visit.

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift

Commit 2ce58c1eb315ad3083c30fed2fa7cbde305092ea by Itai Ferber:
Add JSON and property list encoders and decoders

add: stdlib/public/SDK/Foundation/Codable.swift
edit: stdlib/public/SDK/Foundation/CMakeLists.txt
edit: stdlib/public/SDK/Foundation/NSError.swift
add: stdlib/public/SDK/Foundation/PlistEncoder.swift
add: stdlib/public/SDK/Foundation/JSONEncoder.swift

Commit f7cd0a6343969889ed84bcbd44cd15262c9349b0 by Itai Ferber:
Add Codable conformance to Array

edit: stdlib/public/core/Codable.swift

Commit 44682f7a721ce80706c88a8b7d316f2f4f94c49b by Itai Ferber:
Ensure all Dates can always round-trip by default

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c6f8834d2679646981f46903b3125383352d46c5 by Itai Ferber:
Remove unnecessary CodingKey implementation

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c5fc1e3f78c3cf0fc94ff9f0e9276266adce8014 by Itai Ferber:
Use encode(contentsOf:) instead of a loop

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit d177bdf748c5e86f06e12852317a7b73b51b5248 by Itai Ferber:
Add preliminary {JSON,Plist}Encoder tests

add: test/stdlib/TestJSONEncoder.swift
add: test/stdlib/TestPlistEncoder.swift

Commit 328ebe856776fe63df524eb6d4fcf6199cbaa785 by github:
Revert "[stdlib] Dictionary/Set enhancements"

edit: validation-test/stdlib/Set.swift
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/api-digester/source-stability.swift.expected
edit: validation-test/stdlib/Dictionary.swift
delete: validation-test/stdlib/HashedCollectionFilter3.swift
delete: validation-test/stdlib/HashedCollectionFilter4.swift

Commit 1de530e229ab5736980f2e9162c2fe7dc97fe82c by github:
Revert "Improve disjunction selection"

edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
delete: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift

Commit 1163ea7c7a7c0caa744450ce8c4f3fe06724c184 by github:
[stdlib] swapAt method (#9119)

edit: stdlib/public/core/CollectionAlgorithms.swift.gyb
edit: stdlib/public/core/SequenceAlgorithms.swift.gyb
edit: stdlib/public/core/Reverse.swift
edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/MutableCollection.swift
edit: stdlib/public/core/Sort.swift.gyb
edit: stdlib/public/core/ContiguousArrayBuffer.swift
edit: stdlib/public/core/StringCharacterView.swift

Commit 7778fc2fb359ff92b956fa6f146ecbd55a935129 by Itai Ferber:
Fix encoding container linker errors

edit: stdlib/public/core/Codable.swift

Commit 68525ce45042bf7316a507bf2fb6975e1be2333e by Bob Wilson:
swift-stdlib-tool is not a shell script and can be stripped

edit: utils/build-script-impl

Commit bcdf09d166a7b6c32f642d67d40a03b50a96884b by Mark Lacey:
[stdlib] Disambiguate a subscript operation.

edit: stdlib/public/core/Substring.swift.gyb

Commit 253d0080efdbe8b4788cea48ab5782a6bf3949ce by Robert Widmann:
Improve diagnostic for attempted initialization of non-nominal types

edit: include/swift/AST/DiagnosticsSema.def
edit: lib/Sema/CSDiag.cpp
add: test/decl/init/nonnominal_init.swift

Commit ecfa406fc580df48260c6ad606bfd11c10f6ad4c by Mark Lacey:
Re-instate "Improve disjunction selection"

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
edit: validation-test/stdlib/Set.swift

Commit 40c89048ba68d4aa182a0420b7910596b0427b19 by Argyrios Kyrtzidis:
[index] Make sure that we index implicit constructors

edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/Index/Inputs/cross_language.m
edit: tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp
edit: lib/AST/SourceEntityWalker.cpp
edit: test/SourceKit/Indexing/index_is_test_candidate_objc.swift.response
edit: test/SourceKit/Indexing/rdar_21602898.swift.response
edit: lib/Index/Index.cpp
edit: test/SourceKit/Indexing/Inputs/test_module.index.response
edit: test/Index/index_module.swift
edit: lib/Migrator/SyntacticMigratorPass.cpp
edit: test/IDE/reconstruct_type_from_mangled_name.swift
edit: test/Index/cross_language.swift
edit: test/SourceKit/DocSupport/doc_source_file.swift.response
edit: test/SourceKit/Indexing/Inputs/cycle-depend/A.response
edit: test/SourceKit/Indexing/sr_3815.swift.response
edit: test/Index/kinds.swift
edit: test/SourceKit/Indexing/index_forbid_typecheck.swift.response

Commit b48377bb142edde165a8734aa54f3c8d36cecab3 by Argyrios Kyrtzidis:
[test] Update linux test:

edit: test/SourceKit/Indexing/index_is_test_candidate.swift.response

Commit 9e38a8efea6771f94643b900b1f3d2f0cadca56e by Mark Lacey:
Do not hard-code a result type that the type checker will fill in.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp

Commit de10c41915bb53713fc9cea8496e0b5fe0d669aa by Mark Lacey:
Fix another case where the type checker will set the correct types.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp


(Robert Widmann) #4

I can’t imagine the space engine had anything to do with that floating point test working again in resilient mode, but I’ll investigate.

Thanks~

~Robert Widmann

···

On Apr 30, 2017, at 5:55 PM, Mark Lacey <mark.lacey@apple.com> wrote:

Ben / Robert, I bisected the failures here and it looks like they are due to these two changes:

Robert, The XFAILed FP test that is now passing (and thus…failing) is due to:

commit 42c59554a0e980ab83f52eda41140c4b2c465834
Author: Robert Widmann <devteam.codafi@gmail.com <mailto:devteam.codafi@gmail.com>>
Date: Tue Apr 4 14:49:41 2017 -0400

    Introduce the Space Engine

Ben, the range failure appears to be due to:

commit 946b776e371717f89ba5b4225efcbec5eb07d1b0
Author: Ben Cohen <airspeedswift@users.noreply.github.com <mailto:airspeedswift@users.noreply.github.com>>
Date: Fri Apr 28 12:59:04 2017 -0700

    [stdlib] One-sided ranges and RangeExpression (#8710)

Mark

On Apr 30, 2017, at 5:27 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

New issue found!

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#185]

Build URL: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/
Project: oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build: Sun, 30 Apr 2017 03:47:00 -0700
Build duration: 1 hr 40 min
Identified problems:

Unexpected pass: This build failed because a test marked as XFAIL unexpectedly passes. This could mean that the cause for the XFAIL is fixed, but it warrants investigation in any case.
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#1511526070b011c97a-0462-424c-ac47-5640e6148d79>
Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/185/consoleFull#-2067387497fca400bf-2f4a-462e-b517-e058d770b2d7>
Changes

Commit 62279325193350328f9a4d27fa292195f5db4d26 by github:
[stdlib] Custom Reverse[RandomAccess]Collection.Iterator

edit: stdlib/public/core/Reverse.swift

Commit 3c5b393e0c07c222950e626e5c4553358e22365d by Mark Lacey:
[Constraint solver] Rework how we select the next disjunction to visit.

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift

Commit 2ce58c1eb315ad3083c30fed2fa7cbde305092ea by Itai Ferber:
Add JSON and property list encoders and decoders

add: stdlib/public/SDK/Foundation/Codable.swift
edit: stdlib/public/SDK/Foundation/CMakeLists.txt
edit: stdlib/public/SDK/Foundation/NSError.swift
add: stdlib/public/SDK/Foundation/PlistEncoder.swift
add: stdlib/public/SDK/Foundation/JSONEncoder.swift

Commit f7cd0a6343969889ed84bcbd44cd15262c9349b0 by Itai Ferber:
Add Codable conformance to Array

edit: stdlib/public/core/Codable.swift

Commit 44682f7a721ce80706c88a8b7d316f2f4f94c49b by Itai Ferber:
Ensure all Dates can always round-trip by default

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c6f8834d2679646981f46903b3125383352d46c5 by Itai Ferber:
Remove unnecessary CodingKey implementation

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit c5fc1e3f78c3cf0fc94ff9f0e9276266adce8014 by Itai Ferber:
Use encode(contentsOf:) instead of a loop

edit: stdlib/public/SDK/Foundation/Codable.swift

Commit d177bdf748c5e86f06e12852317a7b73b51b5248 by Itai Ferber:
Add preliminary {JSON,Plist}Encoder tests

add: test/stdlib/TestJSONEncoder.swift
add: test/stdlib/TestPlistEncoder.swift

Commit 328ebe856776fe63df524eb6d4fcf6199cbaa785 by github:
Revert "[stdlib] Dictionary/Set enhancements"

edit: validation-test/stdlib/Set.swift
edit: stdlib/public/core/HashedCollections.swift.gyb
edit: test/api-digester/source-stability.swift.expected
edit: validation-test/stdlib/Dictionary.swift
delete: validation-test/stdlib/HashedCollectionFilter3.swift
delete: validation-test/stdlib/HashedCollectionFilter4.swift

Commit 1de530e229ab5736980f2e9162c2fe7dc97fe82c by github:
Revert "Improve disjunction selection"

edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
delete: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: validation-test/stdlib/Set.swift

Commit 1163ea7c7a7c0caa744450ce8c4f3fe06724c184 by github:
[stdlib] swapAt method (#9119)

edit: stdlib/public/core/CollectionAlgorithms.swift.gyb
edit: stdlib/public/core/SequenceAlgorithms.swift.gyb
edit: stdlib/public/core/Reverse.swift
edit: stdlib/public/core/Arrays.swift.gyb
edit: stdlib/public/core/MutableCollection.swift
edit: stdlib/public/core/Sort.swift.gyb
edit: stdlib/public/core/ContiguousArrayBuffer.swift
edit: stdlib/public/core/StringCharacterView.swift

Commit 7778fc2fb359ff92b956fa6f146ecbd55a935129 by Itai Ferber:
Fix encoding container linker errors

edit: stdlib/public/core/Codable.swift

Commit 68525ce45042bf7316a507bf2fb6975e1be2333e by Bob Wilson:
swift-stdlib-tool is not a shell script and can be stripped

edit: utils/build-script-impl

Commit bcdf09d166a7b6c32f642d67d40a03b50a96884b by Mark Lacey:
[stdlib] Disambiguate a subscript operation.

edit: stdlib/public/core/Substring.swift.gyb

Commit 253d0080efdbe8b4788cea48ab5782a6bf3949ce by Robert Widmann:
Improve diagnostic for attempted initialization of non-nominal types

edit: include/swift/AST/DiagnosticsSema.def
edit: lib/Sema/CSDiag.cpp
add: test/decl/init/nonnominal_init.swift

Commit ecfa406fc580df48260c6ad606bfd11c10f6ad4c by Mark Lacey:
Re-instate "Improve disjunction selection"

add: validation-test/Sema/type_checker_perf/generic_operators.swift.gyb
edit: lib/Sema/CSSolver.cpp
edit: validation-test/stdlib/Data.swift
edit: validation-test/stdlib/Set.swift

Commit 40c89048ba68d4aa182a0420b7910596b0427b19 by Argyrios Kyrtzidis:
[index] Make sure that we index implicit constructors

edit: lib/IDE/SwiftSourceDocInfo.cpp
edit: test/Index/Inputs/cross_language.m
edit: tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp
edit: lib/AST/SourceEntityWalker.cpp
edit: test/SourceKit/Indexing/index_is_test_candidate_objc.swift.response
edit: test/SourceKit/Indexing/rdar_21602898.swift.response
edit: lib/Index/Index.cpp
edit: test/SourceKit/Indexing/Inputs/test_module.index.response
edit: test/Index/index_module.swift
edit: lib/Migrator/SyntacticMigratorPass.cpp
edit: test/IDE/reconstruct_type_from_mangled_name.swift
edit: test/Index/cross_language.swift
edit: test/SourceKit/DocSupport/doc_source_file.swift.response
edit: test/SourceKit/Indexing/Inputs/cycle-depend/A.response
edit: test/SourceKit/Indexing/sr_3815.swift.response
edit: test/Index/kinds.swift
edit: test/SourceKit/Indexing/index_forbid_typecheck.swift.response

Commit b48377bb142edde165a8734aa54f3c8d36cecab3 by Argyrios Kyrtzidis:
[test] Update linux test:

edit: test/SourceKit/Indexing/index_is_test_candidate.swift.response

Commit 9e38a8efea6771f94643b900b1f3d2f0cadca56e by Mark Lacey:
Do not hard-code a result type that the type checker will fill in.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp

Commit de10c41915bb53713fc9cea8496e0b5fe0d669aa by Mark Lacey:
Fix another case where the type checker will set the correct types.

edit: lib/Sema/DerivedConformanceEquatableHashable.cpp