1

Report

[FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#176]

Build URL:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/176/
Project:
oss-swift_tools-RA_stdlib-RDA_test-macos-resilience
Date of build:
Mon, 22 Jan 2018 03:47:00 -0600
Build duration:
37 min

Identified problems:

  • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
  • Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:

Changes

  • Commit 817c0b368e485986126e3f82e7dbe48301b6cfc8 by dgregor:
    [WIP] Emit nominal type access functions for imported types.

    • edit: test/Runtime/demangleToMetadataObjC.swift
    • edit: lib/IRGen/GenMeta.cpp
    • edit: lib/IRGen/GenProto.cpp
    • edit: lib/IRGen/IRGenModule.h
    • edit: lib/IRGen/IRGenModule.cpp

  • Commit ca76c76272f0ee5479e4411b3eeb69fb032cb47e by dgregor:
    [IRGen] Maintain the prior use of isForeign() for identifying foreign

    • edit: lib/IRGen/GenMeta.cpp

  • Commit 2c9ad900ae74f91f1b1745e628bfd6e03020fb73 by dgregor:
    [Mangled name -> metadata] Handle import-as-member types.

    • edit: stdlib/public/runtime/MetadataLookup.cpp
    • edit: test/Runtime/demangleToMetadataObjC.swift

  • Commit 30ecd8ed7f8089fdb4dcdd2b82660cc842e1f45e by dgregor:
    [IRGen] Always emit access functions into nominal type descriptors.

    • edit: lib/IRGen/GenMeta.cpp
    • edit: test/IRGen/foreign_types.sil
    • edit: test/IRGen/Inputs/abi/c_layout.h

  • Commit 902ea27a67cb08b5cc1120d65116fee099583126 by dgregor:
    [IRGen] Consistently record runtime metadata for foreign types.

    • edit: test/IRGen/Inputs/abi/c_layout.h
    • edit: test/IRGen/foreign_types.sil
    • edit: lib/IRGen/GenMeta.cpp
    • edit: lib/IRGen/GenDecl.cpp
    • edit: test/Runtime/demangleToMetadataObjC.swift

  • Commit 834a121b10ea6d67aeb647328f74880f2ccc2e61 by spestov:
    AST: @objc_non_lazy_realization should be underscored and

    • edit: include/swift/AST/Attr.def
    • edit: stdlib/public/core/HashedCollections.swift.gyb
    • edit: stdlib/public/core/ContiguousArrayBuffer.swift
    • edit: test/IDE/complete_decl_attribute.swift
    • edit: test/IRGen/objc-sections.swift
    • edit: test/IRGen/objc_subclass.swift

  • Commit 8f9f7afc5527a39f2550e0097f1cbcdd94e5a163 by spestov:
    AST: Static properties of fixed-layout types are resilient

    • edit: test/SILGen/fixed_layout_attribute.swift
    • add: validation-test/Evolution/Inputs/struct_change_stored_to_computed_static.swift
    • edit: validation-test/Evolution/Inputs/struct_change_stored_to_computed.swift
    • edit: lib/Sema/CodeSynthesis.cpp
    • edit: include/swift/AST/Decl.h
    • add: validation-test/Evolution/test_struct_change_stored_to_computed_static.swift
    • edit: lib/AST/Decl.cpp

  • Commit 7dc7a1fc4cf912ac1bf4649352c47d2ea104253d by spestov:
    Serialization: When deserializing a SIL function in the merge-modules

    • edit: test/multifile/default-arguments/two-modules/main.swift
    • edit: lib/Serialization/DeserializeSIL.cpp
    • delete: test/multifile/default-arguments/two-modules/Inputs/library.swift
    • add: test/multifile/default-arguments/two-modules/Inputs/library1.swift
    • add: test/multifile/default-arguments/two-modules/Inputs/library2.swift

  • Commit 1831b5471e58c310d6d7a99d8c933cee7d792ed5 by spestov:
    SIL: Clean up 'early serialization' a bit

    • edit: test/SIL/Serialization/init_existential_inst_deserializes_witness_tables.swift
    • edit: include/swift/SIL/SILWitnessTable.h
    • edit: test/SILOptimizer/dead_function_elimination.swift
    • edit: test/SILOptimizer/alive_method_with_thunk.swift
    • edit: test/SILOptimizer/dead_witness_module.swift
    • edit: lib/SILOptimizer/UtilityPasses/SerializeSILPass.cpp
    • edit: test/SIL/Serialization/vtable_deserialization.swift
    • edit: lib/SIL/SILWitnessTable.cpp
    • edit: lib/Serialization/DeserializeSIL.cpp
    • edit: test/SILOptimizer/sil_witness_tables_external_witnesstable.swift
    • edit: include/swift/SIL/SILVTable.h
    • edit: lib/SIL/SILVTable.cpp

  • Commit 75463e30f37c9c22dddf62d11ec16cc1a38e4c06 by michael.ilseman:
    [stdlib] Rename _StringCore to _LegacyStringCore. NFC.

    • edit: test/IDE/print_stdlib.swift
    • edit: stdlib/public/core/String.swift
    • edit: test/Demangle/Inputs/simplified-manglings.txt
    • edit: test/stdlib/NewStringAppending.swift
    • edit: stdlib/public/core/StringUTF8.swift
    • edit: test/SILOptimizer/sil_combine_objc.sil
    • edit: stdlib/public/core/Substring.swift.gyb
    • edit: validation-test/stdlib/String.swift
    • edit: stdlib/public/core/StringCore.swift
    • edit: stdlib/public/core/Character.swift
    • edit: stdlib/public/core/ThreadLocalStorage.swift
    • edit: stdlib/public/core/StringCharacterView.swift
    • edit: test/Demangle/Inputs/manglings.txt
    • edit: test/stdlib/NewString.swift
    • edit: stdlib/public/core/StringUTF16.swift
    • edit: stdlib/public/core/StringBridge.swift
    • edit: stdlib/public/core/StringUnicodeScalarView.swift

  • Commit 3be2faf5d320000b2fae7049dc2400eb1dd4dcbf by michael.ilseman:
    [String] Initial implementation of 64-bit StringGuts.

    • edit: validation-test/Reflection/reflect_String.swift
    • edit: stdlib/public/core/FloatingPointParsing.swift.gyb
    • edit: stdlib/public/core/StringHashable.swift
    • edit: test/stdlib/test_runtime_function_counters.swift
    • add: stdlib/public/core/StringVariant.swift
    • edit: test/IRGen/keypaths.sil
    • edit: validation-test/stdlib/String.swift
    • edit: stdlib/public/core/StringUTF16.swift
    • add: stdlib/public/core/UnmanagedOpaqueString.swift
    • edit: stdlib/public/core/KeyPath.swift
    • edit: test/Interpreter/SDK/Foundation_NSString.swift
    • edit: test/IRGen/vtable_multi_file.swift
    • edit: stdlib/public/core/StringLegacy.swift
    • edit: test/stdlib/NewString.swift
    • edit: test/stdlib/RuntimeObjC.swift
    • edit: stdlib/public/core/String.swift
    • edit: stdlib/public/core/UnicodeScalar.swift
    • edit: test/stdlib/NewStringAppending.swift
    • edit: stdlib/public/core/ThreadLocalStorage.swift
    • edit: stdlib/public/core/UTF32.swift
    • add: stdlib/public/core/StringStorage.swift
    • edit: stdlib/public/core/StringComparable.swift
    • edit: stdlib/public/core/ObjCMirrors.swift
    • edit: stdlib/public/core/Substring.swift.gyb
    • edit: stdlib/public/core/Builtin.swift
    • edit: stdlib/public/core/StringBuffer.swift
    • edit: test/IRGen/big_types_corner_cases.swift
    • edit: stdlib/public/core/FixedArray.swift.gyb
    • edit: test/stdlib/test_runtime_function_counters_with_disabled_assertions.swift
    • edit: validation-test/Reflection/reflect_multiple_types.swift
    • edit: test/IRGen/struct_layout.sil
    • edit: stdlib/public/core/StringRangeReplaceableCollection.swift.gyb
    • add: stdlib/public/core/UnmanagedString.swift
    • edit: validation-test/stdlib/StringSlicesConcurrentAppend.swift
    • edit: test/stdlib/NSDictionary.swift
    • add: stdlib/public/core/StringGraphemeBreaking.swift
    • edit: validation-test/Reflection/reflect_Character.swift
    • edit: test/stdlib/StringReallocation.swift
    • edit: stdlib/public/core/UTF16.swift
    • add: stdlib/public/core/StringObject.swift
    • edit: stdlib/public/core/OutputStream.swift
    • edit: stdlib/public/stubs/LibcShims.cpp
    • edit: stdlib/public/core/CTypes.swift
    • edit: validation-test/stdlib/StringHashableComparable.swift.gyb
    • edit: stdlib/public/core/CMakeLists.txt
    • edit: stdlib/public/core/StringUnicodeScalarView.swift
    • edit: stdlib/public/core/Character.swift
    • edit: test/IDE/print_stdlib.swift
    • edit: stdlib/public/core/StringBridge.swift
    • edit: stdlib/public/core/IntegerParsing.swift
    • edit: benchmark/utils/DriverUtils.swift
    • edit: stdlib/public/core/CharacterUnicodeScalars.swift
    • edit: stdlib/public/core/StringCharacterView.swift
    • edit: validation-test/stdlib/StringViews.swift
    • edit: stdlib/public/core/ValidUTF8Buffer.swift
    • edit: test/stdlib/NSSlowString.swift
    • edit: test/DebugInfo/LoadableByAddress.swift
    • edit: stdlib/public/core/GroupInfo.json
    • add: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/core/StringIndexConversions.swift
    • edit: stdlib/public/core/Unicode.swift
    • edit: stdlib/public/SwiftShims/LibcShims.h
    • edit: stdlib/public/core/StringCore.swift
    • edit: stdlib/public/core/StringUTF8.swift

  • Commit b360bd6d69818feaf75516a8b2d656ca053139ee by michael.ilseman:
    Remove _LegacyStringCore :tada::tada::tada:

    • edit: stdlib/public/core/String.swift
    • edit: stdlib/public/core/StringUTF16.swift
    • edit: stdlib/public/core/StringBridge.swift
    • edit: stdlib/public/core/StringGuts.swift
    • edit: test/stdlib/Character.swift
    • edit: stdlib/public/core/CMakeLists.txt
    • delete: stdlib/public/core/StringCore.swift
    • edit: stdlib/public/core/GroupInfo.json

  • Commit 5cf9fd741459fd9e29df03702033a7f8d2fa1240 by michael.ilseman:
    Remove _StringBuffer :tada::tada::tada:

    • delete: stdlib/public/core/StringBuffer.swift
    • edit: stdlib/public/core/StringBridge.swift
    • edit: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/core/Builtin.swift
    • edit: stdlib/public/core/String.swift
    • edit: test/stdlib/NewStringAppending.swift
    • edit: stdlib/public/core/CMakeLists.txt
    • edit: stdlib/public/core/CString.swift
    • edit: stdlib/public/core/GroupInfo.json

  • Commit f2a96496a0a44a86bf5b35f5fad9023ae4ac7add by michael.ilseman:
    [StringGuts] Support for 32-bit platforms

    • edit: stdlib/public/SDK/Foundation/NSString.swift
    • edit: stdlib/public/core/StringVariant.swift
    • edit: test/stdlib/test_runtime_function_counters_with_disabled_assertions.swift
    • edit: test/IRGen/lazy_multi_file.swift
    • edit: validation-test/Reflection/reflect_String.swift
    • edit: stdlib/public/core/Arrays.swift.gyb
    • edit: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/runtime/SwiftValue.mm
    • edit: test/IRGen/vtable_multi_file.swift
    • edit: validation-test/Reflection/reflect_multiple_types.swift
    • edit: stdlib/public/core/ReflectionLegacy.swift
    • edit: test/stdlib/test_runtime_function_counters.swift
    • edit: test/DebugInfo/closure-args.swift
    • edit: stdlib/public/core/StringObject.swift
    • edit: stdlib/public/stubs/LibcShims.cpp
    • edit: test/DebugInfo/self.swift
    • edit: stdlib/public/runtime/Reflection.mm
    • edit: test/DebugInfo/letstring.swift
    • edit: stdlib/public/core/StringComparable.swift
    • edit: stdlib/public/runtime/SwiftObject.mm
    • edit: stdlib/public/runtime/SwiftObject.h

  • Commit 90e894729a0791ce2c78d18607e9c4c8f3667d9d by michael.ilseman:
    [StringGuts] Linux support

    • edit: stdlib/public/core/StringObject.swift
    • edit: stdlib/public/core/StringHashable.swift
    • edit: stdlib/public/core/StringStorage.swift
    • edit: test/IRGen/struct_layout.sil
    • edit: stdlib/public/core/String.swift
    • edit: validation-test/Reflection/reflect_String.swift
    • edit: stdlib/public/core/UnmanagedOpaqueString.swift
    • edit: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/core/StringLegacy.swift
    • edit: test/IRGen/objc_subclass.swift
    • edit: validation-test/Reflection/reflect_multiple_types.swift
    • edit: test/IRGen/keypaths.sil
    • edit: test/stdlib/StringReallocation.swift
    • edit: validation-test/stdlib/String.swift
    • edit: stdlib/public/core/StringComparable.swift
    • edit: stdlib/public/core/StringBridge.swift

  • Commit 6d1866f8461a6646190445d65bebae9d223252cd by michael.ilseman:
    [StringGuts] Clean-up in preparation for merge.

    • edit: stdlib/public/core/Builtin.swift
    • edit: stdlib/public/stubs/LibcShims.cpp
    • edit: stdlib/public/core/StringComparable.swift
    • edit: stdlib/public/core/StringBridge.swift
    • edit: stdlib/public/core/StringObject.swift
    • edit: stdlib/public/SwiftShims/LibcShims.h
    • edit: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/core/CString.swift

  • Commit b8d8949166ce09096e962f62ed33b09c8a239a3d by michael.ilseman:
    String & String views: Add bounds checking to range subscripts.

    • edit: stdlib/public/core/StringRangeReplaceableCollection.swift.gyb
    • edit: stdlib/public/core/StringStorage.swift
    • edit: stdlib/public/core/Substring.swift.gyb
    • edit: validation-test/stdlib/String.swift

  • Commit b61b53330f910f22a250618571f6adfedebc9047 by michael.ilseman:
    [Builtin] Add _isValidAddress pointer-value check.

    • edit: stdlib/public/core/StringGuts.swift
    • edit: stdlib/public/core/Builtin.swift

  • Commit 3c9fa1627cf66ec94778e8b62e2ec4a7d0af09c6 by ditaliano:
    [AllocBoxToStack] Use SILBUilderWithScope instead of SILBuilder.

    • edit: lib/SILOptimizer/Transforms/AllocBoxToStack.cpp

  • Commit f86e9edf081a4d026321db0e8af93e755c4cce74 by mark.lacey:
    Add support for key paths for the new IUO implementation.

    • edit: lib/Sema/CSApply.cpp

  • Commit 096150a927c467079964f882d1c2c82aaca34faf by milseman:
    [gardening] Strip trailing whitespace

    • edit: benchmark/single-source/CSVParsing.swift

  • Commit 7e58fd2cb5e6237cf453de3f3258b3574ca7bbea by milseman:
    [benchmark] Add two new CSVParsing alternative benchmarks.

    • edit: benchmark/utils/main.swift
    • edit: benchmark/single-source/CSVParsing.swift

  • Commit e909a3c723c9a40334b527d7634af24474890646 by milseman:
    [benchmark] De-trivialize OpenClose and Calculator.

    • edit: benchmark/single-source/OpenClose.swift
    • edit: benchmark/single-source/Calculator.swift

  • Commit 142f57ff19b96e391f19f0e00df99a08927b126b by dgregor:
    [IRGen test] Remove Objective-C dependency for new test code.

    • edit: test/IRGen/Inputs/abi/c_layout.h

  • Commit cad0722305a668bac9699c424605b1ab723e3cdc by mark.lacey:
    Remove unused argument to type matcher.

    • edit: lib/AST/Type.cpp
    • edit: lib/Sema/TypeCheckDecl.cpp
    • edit: unittests/AST/TypeMatchTests.cpp
    • edit: include/swift/AST/Types.h
    • edit: lib/SIL/SILFunctionType.cpp
    • edit: lib/AST/Decl.cpp
2

Michael, seems most likely to be related to your changes.

3

I’ll try to reproduce. It passed PR full testing, but there might be something different about this configuration. If it’s blocking an important bot, you should revert temporarily.

4

@rudkx @Michael_Ilseman has this been reverted?

********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 520.61s
********************
Failing Tests (2):
    Swift(macosx-x86_64) :: stdlib/String.swift
    Swift(macosx-x86_64) :: stdlib/NewStringAppending.swift
5

No, but I can reproduce locally now. Do you want to revert?

6

This seems heavily dependent on configuration, as PR bots and @lorenty haven't been able to reproduce it with the same command

7

I'm testing a targeted fix

1 Like
8

We should revert it, if we think its going to take 1hr or more to fix this issue. We don't want to block daily toolchain.

9

(I have a slight hesitation because the revert would be hugely impactful, as in half the standard library and is itself risky if master has drifted)

10

Success on the workaround. Opening PR with quick fix!

11

Thanks!

12

https://github.com/apple/swift/pull/14060

13

Nifty PR preview. I like discourse already!

2 Likes