[Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

···

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift

Ack, will take a look soon.

Xi

···

On Nov 2, 2017, at 9:13 AM, Douglas Gregor <dgregor@apple.com> wrote:

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift

Any update on this?

Can you revert in the meantime if you’re not able to fix it within the next hour?

···

On Nov 2, 2017, at 9:26 AM, Xi Ge <xi_ge@apple.com> wrote:

Ack, will take a look soon.

Xi

On Nov 2, 2017, at 9:13 AM, Douglas Gregor <dgregor@apple.com <mailto:dgregor@apple.com>> wrote:

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift

It seems to be a false positive of Asan container overflow checker. I've a PR to tentatively fix it.

It's still testing

···

--
Xi

On Nov 2, 2017, at 1:28 PM, Erik Eckstein <eeckstein@apple.com> wrote:

Any update on this?

Can you revert in the meantime if you’re not able to fix it within the next hour?

On Nov 2, 2017, at 9:26 AM, Xi Ge <xi_ge@apple.com <mailto:xi_ge@apple.com>> wrote:

Ack, will take a look soon.

Xi

On Nov 2, 2017, at 9:13 AM, Douglas Gregor <dgregor@apple.com <mailto:dgregor@apple.com>> wrote:

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift

It seems my tentative fix doesn't fix this issue. As Erik suggested, I've reverted the commit on master.

···

--
Xi

On Nov 2, 2017, at 1:28 PM, Erik Eckstein <eeckstein@apple.com> wrote:

Any update on this?

Can you revert in the meantime if you’re not able to fix it within the next hour?

On Nov 2, 2017, at 9:26 AM, Xi Ge <xi_ge@apple.com <mailto:xi_ge@apple.com>> wrote:

Ack, will take a look soon.

Xi

On Nov 2, 2017, at 9:13 AM, Douglas Gregor <dgregor@apple.com <mailto:dgregor@apple.com>> wrote:

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift

Thanks!

···

On Nov 2, 2017, at 3:26 PM, Xi Ge <xi_ge@apple.com> wrote:

It seems my tentative fix doesn't fix this issue. As Erik suggested, I've reverted the commit on master.

--
Xi

On Nov 2, 2017, at 1:28 PM, Erik Eckstein <eeckstein@apple.com <mailto:eeckstein@apple.com>> wrote:

Any update on this?

Can you revert in the meantime if you’re not able to fix it within the next hour?

On Nov 2, 2017, at 9:26 AM, Xi Ge <xi_ge@apple.com <mailto:xi_ge@apple.com>> wrote:

Ack, will take a look soon.

Xi

On Nov 2, 2017, at 9:13 AM, Douglas Gregor <dgregor@apple.com <mailto:dgregor@apple.com>> wrote:

Xi, this is failing in

  swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int)

which might be related to your recent changes.

  - Doug

On Nov 2, 2017, at 1:45 AM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#526]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/526/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Wed, 01 Nov 2017 23:53:36 -0500
Build duration: 3 hr 52 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#1519508151ba62d58e-7248-467b-91e0-c7508d5cf947&gt;
Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/526/consoleFull#-13442314533122a513-f36a-4c87-8ed7-cbc36a1ec144&gt;
Changes

Commit 4a54f51e052df35f10c372cc72fb7f422fb2dece by daniel_dunbar:
[Xcode] Add GTEST_NO_LLVM_RAW_OSTREAM declarations for Xcode project.

edit: llbuild.xcodeproj/project.pbxproj

Commit 26f6a751c4dc97383f35bc2d913317df15b54c15 by dgregor:
Remove extensions on ImplicitlyUnwrappedOptional from the stdlib.

edit: stdlib/public/core/ImplicitlyUnwrappedOptional.swift

Commit 2e2c7e8dd6e3e352e51d96a89df4895da85a6bec by dgregor:
Update tests for removal of ImplicitlyUnwrappedOptional extensions.

edit: test/IDE/complete_dynamic_lookup.swift
edit: test/Interpreter/SDK/objc_dynamic_lookup.swift
edit: test/IDE/print_stdlib.swift
edit: test/Interpreter/SDK/objc_keypath.swift

Commit 094395b940fc088102fc017c9c5b02baa84e8119 by github:
[test] Remove -whole-module-optimization from test IRGen/asmname.swift

edit: test/IRGen/asmname.swift

Commit 0d98c4c5df5ce4d50498355d2218815597c70d2d by github:
libSyntax: Ensure round-trip printing when we build syntax tree from

edit: test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
edit: lib/Syntax/SyntaxParsingContext.cpp
edit: lib/Parse/Parser.cpp
edit: include/swift/AST/Module.h
edit: lib/Parse/ParseExpr.cpp
edit: include/swift/Parse/Lexer.h
edit: include/swift/Parse/Parser.h
edit: lib/Parse/Lexer.cpp
edit: include/swift/Syntax/SyntaxParsingContext.h
edit: lib/Parse/ParseDecl.cpp
edit: test/Syntax/round_trip_parse_gen.swift