[Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #293

Slava_Pestov · September 26, 2017, 4:55am

This is from my changes. I think I know what the problem is, I’ll test a fix now.

Slava

···

On Sep 25, 2017, at 9:38 PM, no-reply@swift.org wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#293]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/293/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Mon, 25 Sep 2017 20:02:29 -0500
Build duration: 3 hr 36 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/293/consoleFull#753924207ba62d58e-7248-467b-91e0-c7508d5cf947>
Tests:

Name: Swift(macosx-x86_64)
Failed: 0 test(s), Passed: 9927 test(s), Total: 9927 test(s)
Name: Swift-Unit
Failed: 1 test(s), Passed: 523 test(s), Total: 524 test(s)
Failed: Swift-Unit.runtime/_/SwiftRuntimeTests.MetadataTest.getGenericMetadata <https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/293/testReport/junit/Swift-Unit/runtime___SwiftRuntimeTests/MetadataTest_getGenericMetadata>

Changes

Commit 5fe76898d53255a1bbb50afe72a333b198b03ccf by lance_parker:
Make Bool conform to CVarArg protocol

edit: stdlib/public/core/VarArgs.swift

Commit 6056ebede18f76b319fad8c7e41304c88ab2cf60 by lance_parker:
Add tests for Bool’s conformance to CVarArg

add: test/stdlib/Inputs/VariadicBool/module.map
add: test/stdlib/Inputs/VariadicBool/variadicBool.h
add: test/stdlib/Inputs/VariadicBool/variadicBool.c
add: validation-test/stdlib/BoolDiagnostics.swift
add: validation-test/stdlib/Bool.swift

Commit 9fa2cc819228b32465cf831a006ea584b1a9b07e by lance_parker:
removed uneeded compiler flags

edit: validation-test/stdlib/Bool.swift

Commit 59f7bfe50245e41e4b9548c705252a6dece4966c by rlevenstein:
Provide a comment clarifying why there could be an infinite loop and how

edit: lib/SIL/SILBuilder.cpp

Commit 9745ec82693f7b4498aaf17a8bc6e187d16fa366 by rjmccall:
Build fix for LLDB: resolve ambiguity with operator delete so that

edit: include/swift/SIL/SILInstruction.h

Commit 07b92322350807d66022f7546be10752884291e1 by lance_parker:
Correctly handle big endian systems, updated the comment for va_arg

edit: validation-test/stdlib/Bool.swift
edit: stdlib/public/core/VarArgs.swift
edit: test/stdlib/Inputs/VariadicBool/variadicBool.c

Commit 9880d8eb9c4886c092991a2142490746faf956ea by eeckstein:
Fix output of function name in crash trace.

edit: lib/SILOptimizer/PassManager/PassManager.cpp

Commit 1b960d58b7f28c2bd6e92aac5546b338e5d16531 by mgottesman:
[benchmark] Extract multisource benchmark cmake code into helper

edit: benchmark/cmake/modules/AddSwiftBenchmarkSuite.cmake

Commit 5dfbec05c4bff40074d833993ebb8797aab0df08 by mgottesman:
[benchmark] Allow for swift3 and swift4 multi source benchmarks

edit: benchmark/cmake/modules/AddSwiftBenchmarkSuite.cmake
edit: benchmark/CMakeLists.txt

Commit 5707014b2e6bc946a753474275edacc4b21fc679 by spestov:
IRGen: Remove an unnecessary cast

edit: lib/IRGen/NominalMetadataVisitor.h

Commit 5c0c660727227029ef5c2089f7be8f36e5fae9a1 by spestov:
IRGen: Emit nested generic context information in the nominal type

edit: include/swift/Runtime/Metadata.h
edit: include/swift/ABI/MetadataValues.h
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/generic_classes.sil
edit: test/IRGen/generic_structs.sil
edit: test/IRGen/enum.sil
edit: test/IRGen/generic_vtable.swift

Commit 704b8566a9555f6e5170ccd442f48f86b8f76388 by spestov:
IRGen: Stop fulfilling generic parameters from the parent type

add: test/IRGen/nested_generics.swift
edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/GenMeta.cpp

Commit 9bdb71b6143e69284e9ad8bb46553733e5a7064e by spestov:
Runtime: Stop looking at parent type metadata in

edit: test/stdlib/TypeName.swift
edit: stdlib/public/runtime/Demangle.cpp

Commit 61639cf9713aef480be4b8bb05569383cb45216a by spestov:
RemoteAST: Stop looking at parent metadata field

edit: include/swift/Reflection/TypeRefBuilder.h
edit: lib/RemoteAST/RemoteAST.cpp
edit: include/swift/Remote/MetadataReader.h
edit: include/swift/Reflection/ReflectionContext.h

Commit 453a5bc431317659a01e89a1322e7906d2cdf91e by spestov:
IRGen: Remove Fulfillment::searchParentTypeMetadata()

edit: lib/IRGen/Fulfillment.cpp
edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/Fulfillment.h

Commit 0fa9f761b18672bee9528ad490feec02692c6241 by spestov:
IRGen: Remove NominalParent metadata path component type

edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/MetadataPath.h

Commit 3ab5b6fa198ddf574323cdbbc1d97c107598c822 by spestov:
IRGen/Runtime: Remove parent field from type metadata

edit: test/IRGen/keypaths.sil
edit: test/IRGen/nested_types.sil
edit: test/IRGen/foreign_types.sil
edit: include/swift/Runtime/Metadata.h
edit: test/IRGen/enum.sil
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/enum_value_semantics.sil
edit: test/IRGen/associated_type_witness.swift
edit: test/IRGen/field_type_vectors.sil
edit: test/IRGen/enum_resilience.swift
edit: unittests/runtime/Metadata.cpp
edit: lib/IRGen/EnumMetadataVisitor.h
edit: lib/IRGen/ClassMetadataVisitor.h
edit: lib/IRGen/StructMetadataVisitor.h
edit: lib/IRGen/MetadataLayout.cpp
edit: test/IRGen/struct_resilience.swift
edit: include/swift/ABI/MetadataValues.h
edit: test/IRGen/generic_structs.sil
edit: lib/IRGen/MetadataLayout.h
edit: stdlib/public/runtime/Metadata.cpp

Commit 55cd329cb386ebde893f3e127570c34a1edde8ad by spestov:
Reflection: Remove logic for the parent metadata source

edit: stdlib/public/Reflection/MetadataSource.cpp
edit: include/swift/Reflection/MetadataSourceBuilder.h
edit: lib/IRGen/GenReflection.cpp
edit: include/swift/Reflection/MetadataSources.def
edit: include/swift/Reflection/ReflectionContext.h
edit: include/swift/Reflection/MetadataSource.h

Commit 8b73de60a9ec5043c44ae2bc210846fbe3445a11 by spestov:
IRGen: Remove GenericTypeRequirements::ParentType

edit: lib/IRGen/GenericRequirement.h
delete: validation-test/execution/crashers/rdar18157434.swift
edit: lib/IRGen/GenDecl.cpp
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/nested_generics.swift
add: validation-test/execution/crashers_fixed/rdar33767511.swift
edit: lib/IRGen/GenProto.cpp

Commit e6eb7df33aac413c7afdbad339e5627aa454ad72 by github:
Refactoring tool: Ensure we don't need to check applicability again when

edit: lib/IDE/Refactoring.cpp

Commit 03ad44c0fa1d3e047f6c300ad9da12c92e90a5be by vsk:
[llvm-cov] Warn if -show-functions is used without query files

edit: tools/llvm-cov/CodeCoverage.cpp
edit: test/tools/llvm-cov/report.cpp

Commit 315d77d79f1df44e5ac72b873dce822b3db6d7b7 by vsk:
[docs] llvm-cov: Document -show-instantiation-summary

edit: docs/CommandGuide/llvm-cov.rst

Commit 068eca3dd566249379f5c855337e713cea30851f by vsk:
[docs] llvm-cov: Make docs for boolean options more consistent

edit: docs/CommandGuide/llvm-cov.rst

Slava_Pestov · September 26, 2017, 6:09am

This should fix it: Fix ASAN failure in runtime metadata unit tests by slavapestov · Pull Request #12119 · apple/swift · GitHub

Slava

···

On Sep 25, 2017, at 9:55 PM, Slava Pestov via swift-dev <swift-dev@swift.org> wrote:

This is from my changes. I think I know what the problem is, I’ll test a fix now.

Slava

On Sep 25, 2017, at 9:38 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-ASAN-RA-osx [#293]

Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/293/
Project: oss-swift-incremental-ASAN-RA-osx
Date of build: Mon, 25 Sep 2017 20:02:29 -0500
Build duration: 3 hr 36 min
Identified problems:

Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
Indication 1 <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/293/consoleFull#753924207ba62d58e-7248-467b-91e0-c7508d5cf947>
Tests:

Name: Swift(macosx-x86_64)
Failed: 0 test(s), Passed: 9927 test(s), Total: 9927 test(s)
Name: Swift-Unit
Failed: 1 test(s), Passed: 523 test(s), Total: 524 test(s)
Failed: Swift-Unit.runtime/_/SwiftRuntimeTests.MetadataTest.getGenericMetadata <https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/293/testReport/junit/Swift-Unit/runtime___SwiftRuntimeTests/MetadataTest_getGenericMetadata>

Changes

Commit 5fe76898d53255a1bbb50afe72a333b198b03ccf by lance_parker:
Make Bool conform to CVarArg protocol

edit: stdlib/public/core/VarArgs.swift

Commit 6056ebede18f76b319fad8c7e41304c88ab2cf60 by lance_parker:
Add tests for Bool’s conformance to CVarArg

add: test/stdlib/Inputs/VariadicBool/module.map
add: test/stdlib/Inputs/VariadicBool/variadicBool.h
add: test/stdlib/Inputs/VariadicBool/variadicBool.c
add: validation-test/stdlib/BoolDiagnostics.swift
add: validation-test/stdlib/Bool.swift

Commit 9fa2cc819228b32465cf831a006ea584b1a9b07e by lance_parker:
removed uneeded compiler flags

edit: validation-test/stdlib/Bool.swift

Commit 59f7bfe50245e41e4b9548c705252a6dece4966c by rlevenstein:
Provide a comment clarifying why there could be an infinite loop and how

edit: lib/SIL/SILBuilder.cpp

Commit 9745ec82693f7b4498aaf17a8bc6e187d16fa366 by rjmccall:
Build fix for LLDB: resolve ambiguity with operator delete so that

edit: include/swift/SIL/SILInstruction.h

Commit 07b92322350807d66022f7546be10752884291e1 by lance_parker:
Correctly handle big endian systems, updated the comment for va_arg

edit: validation-test/stdlib/Bool.swift
edit: stdlib/public/core/VarArgs.swift
edit: test/stdlib/Inputs/VariadicBool/variadicBool.c

Commit 9880d8eb9c4886c092991a2142490746faf956ea by eeckstein:
Fix output of function name in crash trace.

edit: lib/SILOptimizer/PassManager/PassManager.cpp

Commit 1b960d58b7f28c2bd6e92aac5546b338e5d16531 by mgottesman:
[benchmark] Extract multisource benchmark cmake code into helper

edit: benchmark/cmake/modules/AddSwiftBenchmarkSuite.cmake

Commit 5dfbec05c4bff40074d833993ebb8797aab0df08 by mgottesman:
[benchmark] Allow for swift3 and swift4 multi source benchmarks

edit: benchmark/cmake/modules/AddSwiftBenchmarkSuite.cmake
edit: benchmark/CMakeLists.txt

Commit 5707014b2e6bc946a753474275edacc4b21fc679 by spestov:
IRGen: Remove an unnecessary cast

edit: lib/IRGen/NominalMetadataVisitor.h

Commit 5c0c660727227029ef5c2089f7be8f36e5fae9a1 by spestov:
IRGen: Emit nested generic context information in the nominal type

edit: include/swift/Runtime/Metadata.h
edit: include/swift/ABI/MetadataValues.h
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/generic_classes.sil
edit: test/IRGen/generic_structs.sil
edit: test/IRGen/enum.sil
edit: test/IRGen/generic_vtable.swift

Commit 704b8566a9555f6e5170ccd442f48f86b8f76388 by spestov:
IRGen: Stop fulfilling generic parameters from the parent type

add: test/IRGen/nested_generics.swift
edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/GenMeta.cpp

Commit 9bdb71b6143e69284e9ad8bb46553733e5a7064e by spestov:
Runtime: Stop looking at parent type metadata in

edit: test/stdlib/TypeName.swift
edit: stdlib/public/runtime/Demangle.cpp

Commit 61639cf9713aef480be4b8bb05569383cb45216a by spestov:
RemoteAST: Stop looking at parent metadata field

edit: include/swift/Reflection/TypeRefBuilder.h
edit: lib/RemoteAST/RemoteAST.cpp
edit: include/swift/Remote/MetadataReader.h
edit: include/swift/Reflection/ReflectionContext.h

Commit 453a5bc431317659a01e89a1322e7906d2cdf91e by spestov:
IRGen: Remove Fulfillment::searchParentTypeMetadata()

edit: lib/IRGen/Fulfillment.cpp
edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/Fulfillment.h

Commit 0fa9f761b18672bee9528ad490feec02692c6241 by spestov:
IRGen: Remove NominalParent metadata path component type

edit: lib/IRGen/GenProto.cpp
edit: lib/IRGen/MetadataPath.h

Commit 3ab5b6fa198ddf574323cdbbc1d97c107598c822 by spestov:
IRGen/Runtime: Remove parent field from type metadata

edit: test/IRGen/keypaths.sil
edit: test/IRGen/nested_types.sil
edit: test/IRGen/foreign_types.sil
edit: include/swift/Runtime/Metadata.h
edit: test/IRGen/enum.sil
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/enum_value_semantics.sil
edit: test/IRGen/associated_type_witness.swift
edit: test/IRGen/field_type_vectors.sil
edit: test/IRGen/enum_resilience.swift
edit: unittests/runtime/Metadata.cpp
edit: lib/IRGen/EnumMetadataVisitor.h
edit: lib/IRGen/ClassMetadataVisitor.h
edit: lib/IRGen/StructMetadataVisitor.h
edit: lib/IRGen/MetadataLayout.cpp
edit: test/IRGen/struct_resilience.swift
edit: include/swift/ABI/MetadataValues.h
edit: test/IRGen/generic_structs.sil
edit: lib/IRGen/MetadataLayout.h
edit: stdlib/public/runtime/Metadata.cpp

Commit 55cd329cb386ebde893f3e127570c34a1edde8ad by spestov:
Reflection: Remove logic for the parent metadata source

edit: stdlib/public/Reflection/MetadataSource.cpp
edit: include/swift/Reflection/MetadataSourceBuilder.h
edit: lib/IRGen/GenReflection.cpp
edit: include/swift/Reflection/MetadataSources.def
edit: include/swift/Reflection/ReflectionContext.h
edit: include/swift/Reflection/MetadataSource.h

Commit 8b73de60a9ec5043c44ae2bc210846fbe3445a11 by spestov:
IRGen: Remove GenericTypeRequirements::ParentType

edit: lib/IRGen/GenericRequirement.h
delete: validation-test/execution/crashers/rdar18157434.swift
edit: lib/IRGen/GenDecl.cpp
edit: lib/IRGen/GenMeta.cpp
edit: test/IRGen/nested_generics.swift
add: validation-test/execution/crashers_fixed/rdar33767511.swift
edit: lib/IRGen/GenProto.cpp

Commit e6eb7df33aac413c7afdbad339e5627aa454ad72 by github:
Refactoring tool: Ensure we don't need to check applicability again when

edit: lib/IDE/Refactoring.cpp

Commit 03ad44c0fa1d3e047f6c300ad9da12c92e90a5be by vsk:
[llvm-cov] Warn if -show-functions is used without query files

edit: tools/llvm-cov/CodeCoverage.cpp
edit: test/tools/llvm-cov/report.cpp

Commit 315d77d79f1df44e5ac72b873dce822b3db6d7b7 by vsk:
[docs] llvm-cov: Document -show-instantiation-summary

edit: docs/CommandGuide/llvm-cov.rst

Commit 068eca3dd566249379f5c855337e713cea30851f by vsk:
[docs] llvm-cov: Make docs for boolean options more consistent

edit: docs/CommandGuide/llvm-cov.rst

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev