Asan is detecting a use after free. Michael G or Joe, is this likely either of you?
SUMMARY: AddressSanitizer: heap-use-after-free (/Users/buildnode/jenkins/workspace/oss-swift-incremental-ASAN-RA-osx/buildbot_incremental_asan/swift-macosx-x86_64/bin/swift:x86_64+0x101bc796c) in swift::eraseUsesOfInstruction(swift::SILInstruction*, std::__1::function<void (swift::SILInstruction*)>)
···
On Aug 29, 2017, at 4:15 PM, no-reply@swift.org wrote:
[FAILURE] oss-swift-incremental-ASAN-RA-osx [#114 ]
Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/114/
Changes
Commit 58fefc174cb6fade894c9c9349dbf34bab7f34a6 by mgottesman:
edit: test/SIL/ownership-verifier/use_verifier.sil
Commit fb1b2a8d9d2277a53c7b1bc76f983ccd38b9f925 by shajrawi:
edit: lib/SILOptimizer/Transforms/SILLowerAggregateInstrs.cpp
Commit 5c65887fd00e99237eb1032634249634e8a7a236 by xi_ge:
edit: lib/IDE/SyntaxModel.cpp
shajrawi
August 29, 2017, 11:27pm
2
My commit might have uncovered an old bug in eraseUsesOfInstruction by changing which large-types are expanded in the optimizer, but it did not cause this underlying problem:
There’s a bug in the recursive eraser’s logic that, in rare occasions, deletes a ‘user’ that’s yet to be iterated over in the Instruction’s users loop. This caused the compiler to crash.
Last week I upstream a commit that worked around this issue by adding the following check:
I am assuming ASAN is hitting this issue now.
Regards,
···
On Aug 29, 2017, at 4:17 PM, Michael Ilseman <milseman@apple.com> wrote:
Asan is detecting a use after free. Michael G or Joe, is this likely either of you?
SUMMARY: AddressSanitizer: heap-use-after-free (/Users/buildnode/jenkins/workspace/oss-swift-incremental-ASAN-RA-osx/buildbot_incremental_asan/swift-macosx-x86_64/bin/swift:x86_64+0x101bc796c) in swift::eraseUsesOfInstruction(swift::SILInstruction*, std::__1::function<void (swift::SILInstruction*)>)
On Aug 29, 2017, at 4:15 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:
[FAILURE] oss-swift-incremental-ASAN-RA-osx [#114 ]
Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/114/
Changes
Commit 58fefc174cb6fade894c9c9349dbf34bab7f34a6 by mgottesman:
edit: test/SIL/ownership-verifier/use_verifier.sil
Commit fb1b2a8d9d2277a53c7b1bc76f983ccd38b9f925 by shajrawi:
edit: lib/SILOptimizer/Transforms/SILLowerAggregateInstrs.cpp
Commit 5c65887fd00e99237eb1032634249634e8a7a236 by xi_ge:
edit: lib/IDE/SyntaxModel.cpp
shajrawi
August 30, 2017, 12:59am
3
This PR should fix it: Fixes a bug in eraseUsesOfInstruction's iterator by shajrawi · Pull Request #11686 · apple/swift · GitHub
Regards,
···
On Aug 29, 2017, at 16:27, Joe Shajrawi <shajrawi@apple.com> wrote:
My commit might have uncovered an old bug in eraseUsesOfInstruction by changing which large-types are expanded in the optimizer, but it did not cause this underlying problem:
There’s a bug in the recursive eraser’s logic that, in rare occasions, deletes a ‘user’ that’s yet to be iterated over in the Instruction’s users loop. This caused the compiler to crash.
Last week I upstream a commit that worked around this issue by adding the following check:
I am assuming ASAN is hitting this issue now.
Regards,
On Aug 29, 2017, at 4:17 PM, Michael Ilseman <milseman@apple.com <mailto:milseman@apple.com>> wrote:
Asan is detecting a use after free. Michael G or Joe, is this likely either of you?
SUMMARY: AddressSanitizer: heap-use-after-free (/Users/buildnode/jenkins/workspace/oss-swift-incremental-ASAN-RA-osx/buildbot_incremental_asan/swift-macosx-x86_64/bin/swift:x86_64+0x101bc796c) in swift::eraseUsesOfInstruction(swift::SILInstruction*, std::__1::function<void (swift::SILInstruction*)>)
On Aug 29, 2017, at 4:15 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:
[FAILURE] oss-swift-incremental-ASAN-RA-osx [#114 ]
Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/114/
Changes
Commit 58fefc174cb6fade894c9c9349dbf34bab7f34a6 by mgottesman:
edit: test/SIL/ownership-verifier/use_verifier.sil
Commit fb1b2a8d9d2277a53c7b1bc76f983ccd38b9f925 by shajrawi:
edit: lib/SILOptimizer/Transforms/SILLowerAggregateInstrs.cpp
Commit 5c65887fd00e99237eb1032634249634e8a7a236 by xi_ge:
edit: lib/IDE/SyntaxModel.cpp
shajrawi@apple.com | 
(+1) 408-930-5203