[Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #3757

Report

[FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#3757]

Build URL:
https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/3757/
Project:
oss-swift-incremental-RA-linux-ubuntu-16_10
Date of build:
Wed, 16 May 2018 13:39:11 -0500
Build duration:
44 sec

Identified problems:

  • Compile Error: This build failed because of a compile error. Below is a list of all errors in the build log:

Tests:

Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 10538 test(s), Total: 10538 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 517 test(s), Total: 517 test(s)

Changes

  • Commit 8b59295a92e1c9e08287be4301aef8385010e011 by mikeash:
    [Runtime] Change protocol conformance scanning to use a concurrent array

    • edit: include/swift/Runtime/Concurrent.h
    • edit: stdlib/public/runtime/ProtocolConformance.cpp
  • Commit 2a0c4bf3680a8a0128bb6a23a79d1b325d3d5dae by mikeash:
    [Runtime] Clean up and lightly document ConcurrentReadableArray. Check

    • edit: include/swift/Runtime/Concurrent.h
  • Commit 68adaebf527db1337a278880bca641c8c4276234 by mikeash:
    [Runtime] Properly set the count in newly allocated storage in

    • edit: include/swift/Runtime/Concurrent.h
  • Commit da4fa67d7e6e53e347fe8cfdfb23afbc3d1e0df9 by mikeash:
    [Runtime] Move ConcurrentReadableArray's allocate/deallocate functions

    • add: include/swift/Runtime/Atomic.h
    • edit: include/swift/Runtime/Concurrent.h
    • edit: stdlib/public/SwiftShims/RefCount.h
    • edit: stdlib/public/runtime/ProtocolConformance.cpp

Missing an #include; I don't know how the PR testing missed this.

/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/swift/include/swift/Runtime/Concurrent.h:451:8: error: no template named 'vector' in namespace 'std' **13:39:53**   std::vector<Storage *> FreeList; **13:39:53**   ~~~~~^

Exactly what I was wondering. Here's a PR for the fix:

https://github.com/apple/swift/pull/16658

I kicked off the test for it, but feel free to merge it directly if you think it's better not to wait.

Mike

I skipped the tests and pushed it. Thanks!