[Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #7287


(Slava Pestov) #1

This error is caused by stale build artifacts:

/home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol lookup error: /home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: undefined symbol: _TFesRxs22RandomAccessCollectionwx5Indexs10Strideablewx7IndiceszGVs14CountableRangewxS0__wx13IndexDistancezWxS2_11SubSequence7IndicesS4__wxS0_zWxS2_S5_S5_8Iterator7Element_WxS2_S6__zGS3_wxS0__WxS2_S7__zGVs16IndexingIteratorGS3_wxS0___WxS2_S5__zGS3_wxS0__WxS2_S4__zWxS2_S5_S6_S4__WxS2_S0__zWxS2_S5_S5_S7_S8__WxS2_8_Element_zWxS2_S5_S5_S7_S8__WxS0_6Stride_zWxS2_S5_S6_S4__WxS2_S6_S6__zGS3_wxS0__WxS2_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S5__zGS3_wxS0__WxS2_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_13IndexDistance_zWxS2_S5_S6_S4__WxS2_S5_S6__zGS3_wxS0__WxS2_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5__zGS3_wxS0__WxS2_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S6_S5__zGS3_wxS0__WxS2_S6_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7__zGS9_GS3_wxS0___WxS2_S6_S5_S5__zGS3_wxS0__WxS2_S6_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7__zGS9_GS3_wxS0___WxS2_S5_S6_S5__zGS3_wxS0__WxS2_S5_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5_S5__zGS3_wxS0__WxS2_S5_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7_S8__zWxS2_S5_S5_S7_S8__rS_g7indicesGS3_wxS0__

I changed the mangling and it appears something was not recompiled. Is anyone looking into these issues?

···

On Sep 6, 2016, at 2:06 PM, no-reply@swift.org wrote:

[FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7287]

Build URL: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/
Project: oss-swift-incremental-RA-linux-ubuntu-14_04
Date of build: Tue, 06 Sep 2016 13:48:21 -0700
Build duration: 18 min
Tests:

Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 8283 test(s), Total: 8283 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 296 test(s), Total: 296 test(s)

Changes

Commit 21ad46b3f650166fef63b458b799c70668c24134 by spestov:
AST: Replace ArchetypeBuilder's adoptArchetypes flag with generic

edit: lib/Sema/TypeCheckDecl.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: lib/Sema/TypeChecker.h
edit: lib/AST/ASTContext.cpp

Commit fb347db4fab1fad6a2a78d8e661929c97949e240 by spestov:
AST: Add dump() method to Requirement and GenericEnvironment

edit: lib/AST/ASTPrinter.cpp
edit: include/swift/AST/Requirement.h
edit: lib/AST/ASTDumper.cpp
edit: include/swift/AST/GenericEnvironment.h

Commit 247852cf6dd00a998a544bcf0b7e3ef67d929179 by spestov:
AST: Remove unused parameter from

edit: include/swift/AST/ProtocolConformance.h
edit: include/swift/AST/Substitution.h
edit: lib/AST/ProtocolConformance.cpp
edit: lib/AST/Substitution.cpp

Commit 798a07a937ff6bbda682ac776ad51df69464323b by spestov:
AST: Fix Type::transform() building of GenericSignatures

edit: lib/AST/Type.cpp

Commit fbe95735980414dd4c256437a3069c305e41053d by spestov:
AST: Add some utility methods to GenericSignature

edit: lib/AST/GenericEnvironment.cpp
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/Substitution.cpp
edit: lib/AST/Module.cpp
edit: include/swift/AST/Substitution.h
edit: lib/Sema/CSApply.cpp
edit: include/swift/AST/GenericSignature.h

Commit 19c982bcd9994e1bcddf1db95ddfc6ba85ea1b85 by spestov:
AST: Add new TypeBase::getSuperclassForDecl()

edit: lib/AST/Type.cpp
edit: include/swift/AST/Types.h

Commit c28529315bc75ccebf01ae45d00428e087c59a0c by spestov:
AST: Tweak conformance lookup for class-constrained archetypes

edit: lib/AST/Module.cpp

Commit 07790d3e5e79b292cdde7534c5804dd0cec34fd2 by spestov:
SILGen: Re-work witness thunk emission a bit

edit: lib/SILGen/SILGenDecl.cpp
edit: lib/SILGen/SILGenPoly.cpp
edit: lib/SILGen/SILGen.h
edit: test/SILGen/witnesses.swift

Commit 772cf3a2fa3a1fd2941895bf952997ac7acf5210 by spestov:
SIL Optimizer: More principled substitution remapping in devirtualizer

edit: test/SILOptimizer/devirt_static_witness_method.sil
edit: lib/SILOptimizer/Utils/Devirtualize.cpp
edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
edit: lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp
edit: lib/SIL/SILModule.cpp
edit: include/swift/SIL/SILModule.h
edit: lib/SILOptimizer/Transforms/SpeculativeDevirtualizer.cpp

Commit 890863da10938059c73dc7eda0f8b01ae785f806 by spestov:
ArchetypeBuilder: const correctness

edit: include/swift/AST/ArchetypeBuilder.h
edit: include/swift/SIL/TypeLowering.h
edit: lib/AST/ArchetypeBuilder.cpp

Commit 71cf5919c6146849778ad454528f3f7d0d11ef86 by spestov:
ArchetypeBuilder: More principled usage of RequirementSource

edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
edit: test/Generics/superclass_constraint.swift
edit: test/Generics/associated_type_typo.swift
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h

Commit f19192d498695e1f7f6c30eda36132bc32392b57 by spestov:
ArchetypeBuilder: Sort requirements in enumerateRequirements()

edit: test/Generics/associated_type_typo.swift
edit: test/SILGen/interface_type_mangling.swift
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
delete: validation-test/IDE/crashers/073-swift-archetypebuilder-enumeraterequirements.swift
add: validation-test/IDE/crashers_fixed/073-swift-archetypebuilder-enumeraterequirements.swift

Commit 7a7af62012c14a85edb57d24597f6b51aea09f56 by spestov:
ArchetypeBuilder: use enumerateRequirements() in getGenericSignature()

edit: test/Generics/superclass_constraint.swift
edit: test/SILGen/witnesses.swift
edit: test/SILOptimizer/specialize_reabstraction.sil
edit: test/Serialization/serialize_attr.swift
edit: test/SILGen/interface_type_mangling.swift
edit: test/SILGen/specialize_attr.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/AST/GenericSignature.cpp
edit: test/SILGen/default_arguments_generic.swift
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SIL/Parser/generic_signature_with_depth.swift

Commit 9771ec84dd8c3fdc7188ec8c383ddb0c160b6b44 by spestov:
Sema: Improve checking of associated type superclass constraints

edit: test/Generics/associated_types_inherit.swift
edit: test/decl/protocol/req/recursion.swift
edit: test/decl/protocol/conforms/associated_type.swift
edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/DiagnosticsSema.def
edit: test/NameBinding/reference-dependencies.swift

Commit 15fd3da5dd3513c97d62d00104be5d6d48830427 by spestov:
SIL: Prepare parser for removal of getCanonicalManglingSignature()

edit: lib/Parse/ParseSIL.cpp

Commit 3b1721795f5177f297c58ad21d73ad14a6f3c600 by spestov:
AST: Nuke GenericSignature::getCanonicalManglingSignature()

edit: lib/IRGen/GenProto.cpp
edit: test/SIL/Parser/generic_signature_with_depth.swift
edit: test/Serialization/function.swift
edit: test/Generics/superclass_constraint.swift
edit: test/SIL/Serialization/deserialize_generic_marker.sil
edit: lib/AST/ASTContext.cpp
edit: test/SILGen/errors.swift
edit: test/SILGen/generic_literals.swift
edit: lib/AST/Mangle.cpp
edit: test/Generics/requirement_inference.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: validation-test/stdlib/CollectionDiagnostics.swift
edit: include/swift/AST/GenericSignature.h
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SILGen/witness_same_type.swift
edit: test/SIL/Parser/default_witness_tables.sil
edit: lib/Sema/ConstraintSystem.cpp
edit: test/SILOptimizer/eager_specialize.sil
edit: include/swift/AST/ASTContext.h

Commit 38e58b23aa9d4446d3726c840651adcaabbfda7e by spestov:
AST: Fix regression with reference-dependencies-members test

edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/Module.h

Commit dc49f82c2a4ad10f71309ca822ddfb0e6027f6bb by spestov:
Sema: Eagerly mark associated type conformances as used

add: test/SILOptimizer/Inputs/specialize_inherited_multifile.swift
edit: lib/Sema/TypeCheckProtocol.cpp
add: test/SILOptimizer/specialize_inherited_multifile.swift

Commit db4464bf39b7102ff2889134a1f5e2f3ab0519a4 by spestov:
Sema: Remove unused parameter from

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 2149061df1ad4572e2519023498c644523fd2fd7 by spestov:
Sema: Clean up hack forcing use of NSError-related conformances

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 6e77f625852366913850f82a5e0e3dc905f49bff by spestov:
AST: Add some handy assertions to GenericSignature

edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ASTContext.cpp

Commit af56a0108c1ed8b5adf88c99766067ea32df17c3 by spestov:
Sema: Add a couple of comments

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 0c30979f477ce8de146960b95a9c5583117f2220 by spestov:
Resolve some crashers

add: validation-test/compiler_crashers_fixed/28342-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28383-swift-constraints-constraintgraphnode-getmembertype.swift
delete: validation-test/compiler_crashers/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28403-swift-genericsignature-getsubstitutionmap.swift
add: validation-test/compiler_crashers_fixed/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28399-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28399-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28403-swift-genericsignature-getsubstitutionmap.swift
delete: validation-test/compiler_crashers/28342-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28383-swift-constraints-constraintgraphnode-getmembertype.swift


(Philippe Hausler) #2

Because Foundation has no information upon the dependency graph for swift; perhaps we should just be recompiling everything every single time for libFoundation.so. It seems like a waste of CPU cycles but I don’t really see any way around it.

···

On Sep 6, 2016, at 2:41 PM, Slava Pestov via swift-dev <swift-dev@swift.org> wrote:

This error is caused by stale build artifacts:

/home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol lookup error: /home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: undefined symbol: _TFesRxs22RandomAccessCollectionwx5Indexs10Strideablewx7IndiceszGVs14CountableRangewxS0__wx13IndexDistancezWxS2_11SubSequence7IndicesS4__wxS0_zWxS2_S5_S5_8Iterator7Element_WxS2_S6__zGS3_wxS0__WxS2_S7__zGVs16IndexingIteratorGS3_wxS0___WxS2_S5__zGS3_wxS0__WxS2_S4__zWxS2_S5_S6_S4__WxS2_S0__zWxS2_S5_S5_S7_S8__WxS2_8_Element_zWxS2_S5_S5_S7_S8__WxS0_6Stride_zWxS2_S5_S6_S4__WxS2_S6_S6__zGS3_wxS0__WxS2_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S5__zGS3_wxS0__WxS2_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_13IndexDistance_zWxS2_S5_S6_S4__WxS2_S5_S6__zGS3_wxS0__WxS2_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5__zGS3_wxS0__WxS2_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S6_S5__zGS3_wxS0__WxS2_S6_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7__zGS9_GS3_wxS0___WxS2_S6_S5_S5__zGS3_wxS0__WxS2_S6_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7__zGS9_GS3_wxS0___WxS2_S5_S6_S5__zGS3_wxS0__WxS2_S5_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5_S5__zGS3_wxS0__WxS2_S5_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7_S8__zWxS2_S5_S5_S7_S8__rS_g7indicesGS3_wxS0__

I changed the mangling and it appears something was not recompiled. Is anyone looking into these issues?

On Sep 6, 2016, at 2:06 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7287]

Build URL: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/
Project: oss-swift-incremental-RA-linux-ubuntu-14_04
Date of build: Tue, 06 Sep 2016 13:48:21 -0700
Build duration: 18 min
Tests:

Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 8283 test(s), Total: 8283 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 296 test(s), Total: 296 test(s)

Changes

Commit 21ad46b3f650166fef63b458b799c70668c24134 by spestov:
AST: Replace ArchetypeBuilder's adoptArchetypes flag with generic

edit: lib/Sema/TypeCheckDecl.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: lib/Sema/TypeChecker.h
edit: lib/AST/ASTContext.cpp

Commit fb347db4fab1fad6a2a78d8e661929c97949e240 by spestov:
AST: Add dump() method to Requirement and GenericEnvironment

edit: lib/AST/ASTPrinter.cpp
edit: include/swift/AST/Requirement.h
edit: lib/AST/ASTDumper.cpp
edit: include/swift/AST/GenericEnvironment.h

Commit 247852cf6dd00a998a544bcf0b7e3ef67d929179 by spestov:
AST: Remove unused parameter from

edit: include/swift/AST/ProtocolConformance.h
edit: include/swift/AST/Substitution.h
edit: lib/AST/ProtocolConformance.cpp
edit: lib/AST/Substitution.cpp

Commit 798a07a937ff6bbda682ac776ad51df69464323b by spestov:
AST: Fix Type::transform() building of GenericSignatures

edit: lib/AST/Type.cpp

Commit fbe95735980414dd4c256437a3069c305e41053d by spestov:
AST: Add some utility methods to GenericSignature

edit: lib/AST/GenericEnvironment.cpp
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/Substitution.cpp
edit: lib/AST/Module.cpp
edit: include/swift/AST/Substitution.h
edit: lib/Sema/CSApply.cpp
edit: include/swift/AST/GenericSignature.h

Commit 19c982bcd9994e1bcddf1db95ddfc6ba85ea1b85 by spestov:
AST: Add new TypeBase::getSuperclassForDecl()

edit: lib/AST/Type.cpp
edit: include/swift/AST/Types.h

Commit c28529315bc75ccebf01ae45d00428e087c59a0c by spestov:
AST: Tweak conformance lookup for class-constrained archetypes

edit: lib/AST/Module.cpp

Commit 07790d3e5e79b292cdde7534c5804dd0cec34fd2 by spestov:
SILGen: Re-work witness thunk emission a bit

edit: lib/SILGen/SILGenDecl.cpp
edit: lib/SILGen/SILGenPoly.cpp
edit: lib/SILGen/SILGen.h
edit: test/SILGen/witnesses.swift

Commit 772cf3a2fa3a1fd2941895bf952997ac7acf5210 by spestov:
SIL Optimizer: More principled substitution remapping in devirtualizer

edit: test/SILOptimizer/devirt_static_witness_method.sil
edit: lib/SILOptimizer/Utils/Devirtualize.cpp
edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
edit: lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp
edit: lib/SIL/SILModule.cpp
edit: include/swift/SIL/SILModule.h
edit: lib/SILOptimizer/Transforms/SpeculativeDevirtualizer.cpp

Commit 890863da10938059c73dc7eda0f8b01ae785f806 by spestov:
ArchetypeBuilder: const correctness

edit: include/swift/AST/ArchetypeBuilder.h
edit: include/swift/SIL/TypeLowering.h
edit: lib/AST/ArchetypeBuilder.cpp

Commit 71cf5919c6146849778ad454528f3f7d0d11ef86 by spestov:
ArchetypeBuilder: More principled usage of RequirementSource

edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
edit: test/Generics/superclass_constraint.swift
edit: test/Generics/associated_type_typo.swift
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h

Commit f19192d498695e1f7f6c30eda36132bc32392b57 by spestov:
ArchetypeBuilder: Sort requirements in enumerateRequirements()

edit: test/Generics/associated_type_typo.swift
edit: test/SILGen/interface_type_mangling.swift
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
delete: validation-test/IDE/crashers/073-swift-archetypebuilder-enumeraterequirements.swift
add: validation-test/IDE/crashers_fixed/073-swift-archetypebuilder-enumeraterequirements.swift

Commit 7a7af62012c14a85edb57d24597f6b51aea09f56 by spestov:
ArchetypeBuilder: use enumerateRequirements() in getGenericSignature()

edit: test/Generics/superclass_constraint.swift
edit: test/SILGen/witnesses.swift
edit: test/SILOptimizer/specialize_reabstraction.sil
edit: test/Serialization/serialize_attr.swift
edit: test/SILGen/interface_type_mangling.swift
edit: test/SILGen/specialize_attr.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/AST/GenericSignature.cpp
edit: test/SILGen/default_arguments_generic.swift
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SIL/Parser/generic_signature_with_depth.swift

Commit 9771ec84dd8c3fdc7188ec8c383ddb0c160b6b44 by spestov:
Sema: Improve checking of associated type superclass constraints

edit: test/Generics/associated_types_inherit.swift
edit: test/decl/protocol/req/recursion.swift
edit: test/decl/protocol/conforms/associated_type.swift
edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/DiagnosticsSema.def
edit: test/NameBinding/reference-dependencies.swift

Commit 15fd3da5dd3513c97d62d00104be5d6d48830427 by spestov:
SIL: Prepare parser for removal of getCanonicalManglingSignature()

edit: lib/Parse/ParseSIL.cpp

Commit 3b1721795f5177f297c58ad21d73ad14a6f3c600 by spestov:
AST: Nuke GenericSignature::getCanonicalManglingSignature()

edit: lib/IRGen/GenProto.cpp
edit: test/SIL/Parser/generic_signature_with_depth.swift
edit: test/Serialization/function.swift
edit: test/Generics/superclass_constraint.swift
edit: test/SIL/Serialization/deserialize_generic_marker.sil
edit: lib/AST/ASTContext.cpp
edit: test/SILGen/errors.swift
edit: test/SILGen/generic_literals.swift
edit: lib/AST/Mangle.cpp
edit: test/Generics/requirement_inference.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: validation-test/stdlib/CollectionDiagnostics.swift
edit: include/swift/AST/GenericSignature.h
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SILGen/witness_same_type.swift
edit: test/SIL/Parser/default_witness_tables.sil
edit: lib/Sema/ConstraintSystem.cpp
edit: test/SILOptimizer/eager_specialize.sil
edit: include/swift/AST/ASTContext.h

Commit 38e58b23aa9d4446d3726c840651adcaabbfda7e by spestov:
AST: Fix regression with reference-dependencies-members test

edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/Module.h

Commit dc49f82c2a4ad10f71309ca822ddfb0e6027f6bb by spestov:
Sema: Eagerly mark associated type conformances as used

add: test/SILOptimizer/Inputs/specialize_inherited_multifile.swift
edit: lib/Sema/TypeCheckProtocol.cpp
add: test/SILOptimizer/specialize_inherited_multifile.swift

Commit db4464bf39b7102ff2889134a1f5e2f3ab0519a4 by spestov:
Sema: Remove unused parameter from

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 2149061df1ad4572e2519023498c644523fd2fd7 by spestov:
Sema: Clean up hack forcing use of NSError-related conformances

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 6e77f625852366913850f82a5e0e3dc905f49bff by spestov:
AST: Add some handy assertions to GenericSignature

edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ASTContext.cpp

Commit af56a0108c1ed8b5adf88c99766067ea32df17c3 by spestov:
Sema: Add a couple of comments

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 0c30979f477ce8de146960b95a9c5583117f2220 by spestov:
Resolve some crashers

add: validation-test/compiler_crashers_fixed/28342-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28383-swift-constraints-constraintgraphnode-getmembertype.swift
delete: validation-test/compiler_crashers/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28403-swift-genericsignature-getsubstitutionmap.swift
add: validation-test/compiler_crashers_fixed/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28399-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28399-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28403-swift-genericsignature-getsubstitutionmap.swift
delete: validation-test/compiler_crashers/28342-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28383-swift-constraints-constraintgraphnode-getmembertype.swift

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Slava Pestov) #3

What do you do when the swift module file format changes? Should I bump the module version when something ABI-related changes, even if the serialization format itself didn’t change?

Slava

···

On Sep 6, 2016, at 2:44 PM, Philippe Hausler <phausler@apple.com> wrote:

Because Foundation has no information upon the dependency graph for swift; perhaps we should just be recompiling everything every single time for libFoundation.so. It seems like a waste of CPU cycles but I don’t really see any way around it.

On Sep 6, 2016, at 2:41 PM, Slava Pestov via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

This error is caused by stale build artifacts:

/home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol lookup error: /home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: undefined symbol: _TFesRxs22RandomAccessCollectionwx5Indexs10Strideablewx7IndiceszGVs14CountableRangewxS0__wx13IndexDistancezWxS2_11SubSequence7IndicesS4__wxS0_zWxS2_S5_S5_8Iterator7Element_WxS2_S6__zGS3_wxS0__WxS2_S7__zGVs16IndexingIteratorGS3_wxS0___WxS2_S5__zGS3_wxS0__WxS2_S4__zWxS2_S5_S6_S4__WxS2_S0__zWxS2_S5_S5_S7_S8__WxS2_8_Element_zWxS2_S5_S5_S7_S8__WxS0_6Stride_zWxS2_S5_S6_S4__WxS2_S6_S6__zGS3_wxS0__WxS2_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S5__zGS3_wxS0__WxS2_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_13IndexDistance_zWxS2_S5_S6_S4__WxS2_S5_S6__zGS3_wxS0__WxS2_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5__zGS3_wxS0__WxS2_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S6_S5__zGS3_wxS0__WxS2_S6_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7__zGS9_GS3_wxS0___WxS2_S6_S5_S5__zGS3_wxS0__WxS2_S6_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7__zGS9_GS3_wxS0___WxS2_S5_S6_S5__zGS3_wxS0__WxS2_S5_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5_S5__zGS3_wxS0__WxS2_S5_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7_S8__zWxS2_S5_S5_S7_S8__rS_g7indicesGS3_wxS0__

I changed the mangling and it appears something was not recompiled. Is anyone looking into these issues?

On Sep 6, 2016, at 2:06 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:

[FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7287]

Build URL: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/
Project: oss-swift-incremental-RA-linux-ubuntu-14_04
Date of build: Tue, 06 Sep 2016 13:48:21 -0700
Build duration: 18 min
Tests:

Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 8283 test(s), Total: 8283 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 296 test(s), Total: 296 test(s)

Changes

Commit 21ad46b3f650166fef63b458b799c70668c24134 by spestov:
AST: Replace ArchetypeBuilder's adoptArchetypes flag with generic

edit: lib/Sema/TypeCheckDecl.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: lib/Sema/TypeChecker.h
edit: lib/AST/ASTContext.cpp

Commit fb347db4fab1fad6a2a78d8e661929c97949e240 by spestov:
AST: Add dump() method to Requirement and GenericEnvironment

edit: lib/AST/ASTPrinter.cpp
edit: include/swift/AST/Requirement.h
edit: lib/AST/ASTDumper.cpp
edit: include/swift/AST/GenericEnvironment.h

Commit 247852cf6dd00a998a544bcf0b7e3ef67d929179 by spestov:
AST: Remove unused parameter from

edit: include/swift/AST/ProtocolConformance.h
edit: include/swift/AST/Substitution.h
edit: lib/AST/ProtocolConformance.cpp
edit: lib/AST/Substitution.cpp

Commit 798a07a937ff6bbda682ac776ad51df69464323b by spestov:
AST: Fix Type::transform() building of GenericSignatures

edit: lib/AST/Type.cpp

Commit fbe95735980414dd4c256437a3069c305e41053d by spestov:
AST: Add some utility methods to GenericSignature

edit: lib/AST/GenericEnvironment.cpp
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/Substitution.cpp
edit: lib/AST/Module.cpp
edit: include/swift/AST/Substitution.h
edit: lib/Sema/CSApply.cpp
edit: include/swift/AST/GenericSignature.h

Commit 19c982bcd9994e1bcddf1db95ddfc6ba85ea1b85 by spestov:
AST: Add new TypeBase::getSuperclassForDecl()

edit: lib/AST/Type.cpp
edit: include/swift/AST/Types.h

Commit c28529315bc75ccebf01ae45d00428e087c59a0c by spestov:
AST: Tweak conformance lookup for class-constrained archetypes

edit: lib/AST/Module.cpp

Commit 07790d3e5e79b292cdde7534c5804dd0cec34fd2 by spestov:
SILGen: Re-work witness thunk emission a bit

edit: lib/SILGen/SILGenDecl.cpp
edit: lib/SILGen/SILGenPoly.cpp
edit: lib/SILGen/SILGen.h
edit: test/SILGen/witnesses.swift

Commit 772cf3a2fa3a1fd2941895bf952997ac7acf5210 by spestov:
SIL Optimizer: More principled substitution remapping in devirtualizer

edit: test/SILOptimizer/devirt_static_witness_method.sil
edit: lib/SILOptimizer/Utils/Devirtualize.cpp
edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
edit: lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp
edit: lib/SIL/SILModule.cpp
edit: include/swift/SIL/SILModule.h
edit: lib/SILOptimizer/Transforms/SpeculativeDevirtualizer.cpp

Commit 890863da10938059c73dc7eda0f8b01ae785f806 by spestov:
ArchetypeBuilder: const correctness

edit: include/swift/AST/ArchetypeBuilder.h
edit: include/swift/SIL/TypeLowering.h
edit: lib/AST/ArchetypeBuilder.cpp

Commit 71cf5919c6146849778ad454528f3f7d0d11ef86 by spestov:
ArchetypeBuilder: More principled usage of RequirementSource

edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
edit: test/Generics/superclass_constraint.swift
edit: test/Generics/associated_type_typo.swift
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h

Commit f19192d498695e1f7f6c30eda36132bc32392b57 by spestov:
ArchetypeBuilder: Sort requirements in enumerateRequirements()

edit: test/Generics/associated_type_typo.swift
edit: test/SILGen/interface_type_mangling.swift
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
delete: validation-test/IDE/crashers/073-swift-archetypebuilder-enumeraterequirements.swift
add: validation-test/IDE/crashers_fixed/073-swift-archetypebuilder-enumeraterequirements.swift

Commit 7a7af62012c14a85edb57d24597f6b51aea09f56 by spestov:
ArchetypeBuilder: use enumerateRequirements() in getGenericSignature()

edit: test/Generics/superclass_constraint.swift
edit: test/SILGen/witnesses.swift
edit: test/SILOptimizer/specialize_reabstraction.sil
edit: test/Serialization/serialize_attr.swift
edit: test/SILGen/interface_type_mangling.swift
edit: test/SILGen/specialize_attr.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/AST/GenericSignature.cpp
edit: test/SILGen/default_arguments_generic.swift
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SIL/Parser/generic_signature_with_depth.swift

Commit 9771ec84dd8c3fdc7188ec8c383ddb0c160b6b44 by spestov:
Sema: Improve checking of associated type superclass constraints

edit: test/Generics/associated_types_inherit.swift
edit: test/decl/protocol/req/recursion.swift
edit: test/decl/protocol/conforms/associated_type.swift
edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/DiagnosticsSema.def
edit: test/NameBinding/reference-dependencies.swift

Commit 15fd3da5dd3513c97d62d00104be5d6d48830427 by spestov:
SIL: Prepare parser for removal of getCanonicalManglingSignature()

edit: lib/Parse/ParseSIL.cpp

Commit 3b1721795f5177f297c58ad21d73ad14a6f3c600 by spestov:
AST: Nuke GenericSignature::getCanonicalManglingSignature()

edit: lib/IRGen/GenProto.cpp
edit: test/SIL/Parser/generic_signature_with_depth.swift
edit: test/Serialization/function.swift
edit: test/Generics/superclass_constraint.swift
edit: test/SIL/Serialization/deserialize_generic_marker.sil
edit: lib/AST/ASTContext.cpp
edit: test/SILGen/errors.swift
edit: test/SILGen/generic_literals.swift
edit: lib/AST/Mangle.cpp
edit: test/Generics/requirement_inference.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: validation-test/stdlib/CollectionDiagnostics.swift
edit: include/swift/AST/GenericSignature.h
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SILGen/witness_same_type.swift
edit: test/SIL/Parser/default_witness_tables.sil
edit: lib/Sema/ConstraintSystem.cpp
edit: test/SILOptimizer/eager_specialize.sil
edit: include/swift/AST/ASTContext.h

Commit 38e58b23aa9d4446d3726c840651adcaabbfda7e by spestov:
AST: Fix regression with reference-dependencies-members test

edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/Module.h

Commit dc49f82c2a4ad10f71309ca822ddfb0e6027f6bb by spestov:
Sema: Eagerly mark associated type conformances as used

add: test/SILOptimizer/Inputs/specialize_inherited_multifile.swift
edit: lib/Sema/TypeCheckProtocol.cpp
add: test/SILOptimizer/specialize_inherited_multifile.swift

Commit db4464bf39b7102ff2889134a1f5e2f3ab0519a4 by spestov:
Sema: Remove unused parameter from

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 2149061df1ad4572e2519023498c644523fd2fd7 by spestov:
Sema: Clean up hack forcing use of NSError-related conformances

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 6e77f625852366913850f82a5e0e3dc905f49bff by spestov:
AST: Add some handy assertions to GenericSignature

edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ASTContext.cpp

Commit af56a0108c1ed8b5adf88c99766067ea32df17c3 by spestov:
Sema: Add a couple of comments

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 0c30979f477ce8de146960b95a9c5583117f2220 by spestov:
Resolve some crashers

add: validation-test/compiler_crashers_fixed/28342-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28383-swift-constraints-constraintgraphnode-getmembertype.swift
delete: validation-test/compiler_crashers/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28403-swift-genericsignature-getsubstitutionmap.swift
add: validation-test/compiler_crashers_fixed/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28399-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28399-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28403-swift-genericsignature-getsubstitutionmap.swift
delete: validation-test/compiler_crashers/28342-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28383-swift-constraints-constraintgraphnode-getmembertype.swift

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev


(Philippe Hausler) #4

The graph only looks at deps from Foundation's tree because we have no generator for ninja to validate changes against.

···

Sent from my iPhone

On Sep 6, 2016, at 2:52 PM, Slava Pestov <spestov@apple.com> wrote:

What do you do when the swift module file format changes? Should I bump the module version when something ABI-related changes, even if the serialization format itself didn’t change?

Slava

On Sep 6, 2016, at 2:44 PM, Philippe Hausler <phausler@apple.com> wrote:

Because Foundation has no information upon the dependency graph for swift; perhaps we should just be recompiling everything every single time for libFoundation.so. It seems like a waste of CPU cycles but I don’t really see any way around it.

On Sep 6, 2016, at 2:41 PM, Slava Pestov via swift-dev <swift-dev@swift.org> wrote:

This error is caused by stale build artifacts:

/home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol lookup error: /home/buildnode/disk2/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: undefined symbol: _TFesRxs22RandomAccessCollectionwx5Indexs10Strideablewx7IndiceszGVs14CountableRangewxS0__wx13IndexDistancezWxS2_11SubSequence7IndicesS4__wxS0_zWxS2_S5_S5_8Iterator7Element_WxS2_S6__zGS3_wxS0__WxS2_S7__zGVs16IndexingIteratorGS3_wxS0___WxS2_S5__zGS3_wxS0__WxS2_S4__zWxS2_S5_S6_S4__WxS2_S0__zWxS2_S5_S5_S7_S8__WxS2_8_Element_zWxS2_S5_S5_S7_S8__WxS0_6Stride_zWxS2_S5_S6_S4__WxS2_S6_S6__zGS3_wxS0__WxS2_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S5__zGS3_wxS0__WxS2_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_13IndexDistance_zWxS2_S5_S6_S4__WxS2_S5_S6__zGS3_wxS0__WxS2_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5__zGS3_wxS0__WxS2_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7__zGS9_GS3_wxS0___WxS2_S6_S6_S5__zGS3_wxS0__WxS2_S6_S6_S4__zWxS2_S5_S6_S4__WxS2_S6_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7__zGS9_GS3_wxS0___WxS2_S6_S5_S5__zGS3_wxS0__WxS2_S6_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7__zGS9_GS3_wxS0___WxS2_S5_S6_S5__zGS3_wxS0__WxS2_S5_S6_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S10__zWxS2_S5_S5_S7_S8__WxS2_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S7__zGS9_GS3_wxS0___WxS2_S5_S5_S5__zGS3_wxS0__WxS2_S5_S5_S0__zWxS2_S5_S5_S7_S8__WxS2_S5_S5_S10__zWxS2_S5_S5_S7_S8__WxS2_S6_S6_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S6_S5_S7_S8__zWxS2_S5_S5_S7_S8__WxS2_S5_S6_S7_S8__zWxS2_S5_S5_S7_S8__rS_g7indicesGS3_wxS0__

I changed the mangling and it appears something was not recompiled. Is anyone looking into these issues?

On Sep 6, 2016, at 2:06 PM, no-reply@swift.org wrote:

[FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#7287]

Build URL: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/7287/
Project: oss-swift-incremental-RA-linux-ubuntu-14_04
Date of build: Tue, 06 Sep 2016 13:48:21 -0700
Build duration: 18 min
Tests:

Name: Swift(linux-x86_64)
Failed: 0 test(s), Passed: 8283 test(s), Total: 8283 test(s)
Name: Swift-Unit
Failed: 0 test(s), Passed: 296 test(s), Total: 296 test(s)

Changes

Commit 21ad46b3f650166fef63b458b799c70668c24134 by spestov:
AST: Replace ArchetypeBuilder's adoptArchetypes flag with generic

edit: lib/Sema/TypeCheckDecl.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: lib/Sema/TypeChecker.h
edit: lib/AST/ASTContext.cpp

Commit fb347db4fab1fad6a2a78d8e661929c97949e240 by spestov:
AST: Add dump() method to Requirement and GenericEnvironment

edit: lib/AST/ASTPrinter.cpp
edit: include/swift/AST/Requirement.h
edit: lib/AST/ASTDumper.cpp
edit: include/swift/AST/GenericEnvironment.h

Commit 247852cf6dd00a998a544bcf0b7e3ef67d929179 by spestov:
AST: Remove unused parameter from

edit: include/swift/AST/ProtocolConformance.h
edit: include/swift/AST/Substitution.h
edit: lib/AST/ProtocolConformance.cpp
edit: lib/AST/Substitution.cpp

Commit 798a07a937ff6bbda682ac776ad51df69464323b by spestov:
AST: Fix Type::transform() building of GenericSignatures

edit: lib/AST/Type.cpp

Commit fbe95735980414dd4c256437a3069c305e41053d by spestov:
AST: Add some utility methods to GenericSignature

edit: lib/AST/GenericEnvironment.cpp
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/Substitution.cpp
edit: lib/AST/Module.cpp
edit: include/swift/AST/Substitution.h
edit: lib/Sema/CSApply.cpp
edit: include/swift/AST/GenericSignature.h

Commit 19c982bcd9994e1bcddf1db95ddfc6ba85ea1b85 by spestov:
AST: Add new TypeBase::getSuperclassForDecl()

edit: lib/AST/Type.cpp
edit: include/swift/AST/Types.h

Commit c28529315bc75ccebf01ae45d00428e087c59a0c by spestov:
AST: Tweak conformance lookup for class-constrained archetypes

edit: lib/AST/Module.cpp

Commit 07790d3e5e79b292cdde7534c5804dd0cec34fd2 by spestov:
SILGen: Re-work witness thunk emission a bit

edit: lib/SILGen/SILGenDecl.cpp
edit: lib/SILGen/SILGenPoly.cpp
edit: lib/SILGen/SILGen.h
edit: test/SILGen/witnesses.swift

Commit 772cf3a2fa3a1fd2941895bf952997ac7acf5210 by spestov:
SIL Optimizer: More principled substitution remapping in devirtualizer

edit: test/SILOptimizer/devirt_static_witness_method.sil
edit: lib/SILOptimizer/Utils/Devirtualize.cpp
edit: lib/SILOptimizer/SILCombiner/SILCombinerMiscVisitors.cpp
edit: lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp
edit: lib/SIL/SILModule.cpp
edit: include/swift/SIL/SILModule.h
edit: lib/SILOptimizer/Transforms/SpeculativeDevirtualizer.cpp

Commit 890863da10938059c73dc7eda0f8b01ae785f806 by spestov:
ArchetypeBuilder: const correctness

edit: include/swift/AST/ArchetypeBuilder.h
edit: include/swift/SIL/TypeLowering.h
edit: lib/AST/ArchetypeBuilder.cpp

Commit 71cf5919c6146849778ad454528f3f7d0d11ef86 by spestov:
ArchetypeBuilder: More principled usage of RequirementSource

edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
edit: test/Generics/superclass_constraint.swift
edit: test/Generics/associated_type_typo.swift
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h

Commit f19192d498695e1f7f6c30eda36132bc32392b57 by spestov:
ArchetypeBuilder: Sort requirements in enumerateRequirements()

edit: test/Generics/associated_type_typo.swift
edit: test/SILGen/interface_type_mangling.swift
edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ArchetypeBuilder.cpp
edit: test/Generics/requirement_inference.swift
delete: validation-test/IDE/crashers/073-swift-archetypebuilder-enumeraterequirements.swift
add: validation-test/IDE/crashers_fixed/073-swift-archetypebuilder-enumeraterequirements.swift

Commit 7a7af62012c14a85edb57d24597f6b51aea09f56 by spestov:
ArchetypeBuilder: use enumerateRequirements() in getGenericSignature()

edit: test/Generics/superclass_constraint.swift
edit: test/SILGen/witnesses.swift
edit: test/SILOptimizer/specialize_reabstraction.sil
edit: test/Serialization/serialize_attr.swift
edit: test/SILGen/interface_type_mangling.swift
edit: test/SILGen/specialize_attr.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/AST/GenericSignature.cpp
edit: test/SILGen/default_arguments_generic.swift
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SIL/Parser/generic_signature_with_depth.swift

Commit 9771ec84dd8c3fdc7188ec8c383ddb0c160b6b44 by spestov:
Sema: Improve checking of associated type superclass constraints

edit: test/Generics/associated_types_inherit.swift
edit: test/decl/protocol/req/recursion.swift
edit: test/decl/protocol/conforms/associated_type.swift
edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/DiagnosticsSema.def
edit: test/NameBinding/reference-dependencies.swift

Commit 15fd3da5dd3513c97d62d00104be5d6d48830427 by spestov:
SIL: Prepare parser for removal of getCanonicalManglingSignature()

edit: lib/Parse/ParseSIL.cpp

Commit 3b1721795f5177f297c58ad21d73ad14a6f3c600 by spestov:
AST: Nuke GenericSignature::getCanonicalManglingSignature()

edit: lib/IRGen/GenProto.cpp
edit: test/SIL/Parser/generic_signature_with_depth.swift
edit: test/Serialization/function.swift
edit: test/Generics/superclass_constraint.swift
edit: test/SIL/Serialization/deserialize_generic_marker.sil
edit: lib/AST/ASTContext.cpp
edit: test/SILGen/errors.swift
edit: test/SILGen/generic_literals.swift
edit: lib/AST/Mangle.cpp
edit: test/Generics/requirement_inference.swift
edit: lib/AST/ArchetypeBuilder.cpp
edit: lib/Sema/TypeCheckGeneric.cpp
edit: validation-test/stdlib/CollectionDiagnostics.swift
edit: include/swift/AST/GenericSignature.h
edit: lib/AST/GenericSignature.cpp
edit: include/swift/AST/ArchetypeBuilder.h
edit: test/SILGen/witness_same_type.swift
edit: test/SIL/Parser/default_witness_tables.sil
edit: lib/Sema/ConstraintSystem.cpp
edit: test/SILOptimizer/eager_specialize.sil
edit: include/swift/AST/ASTContext.h

Commit 38e58b23aa9d4446d3726c840651adcaabbfda7e by spestov:
AST: Fix regression with reference-dependencies-members test

edit: lib/Sema/TypeCheckProtocol.cpp
edit: include/swift/AST/Module.h

Commit dc49f82c2a4ad10f71309ca822ddfb0e6027f6bb by spestov:
Sema: Eagerly mark associated type conformances as used

add: test/SILOptimizer/Inputs/specialize_inherited_multifile.swift
edit: lib/Sema/TypeCheckProtocol.cpp
add: test/SILOptimizer/specialize_inherited_multifile.swift

Commit db4464bf39b7102ff2889134a1f5e2f3ab0519a4 by spestov:
Sema: Remove unused parameter from

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 2149061df1ad4572e2519023498c644523fd2fd7 by spestov:
Sema: Clean up hack forcing use of NSError-related conformances

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 6e77f625852366913850f82a5e0e3dc905f49bff by spestov:
AST: Add some handy assertions to GenericSignature

edit: lib/AST/GenericSignature.cpp
edit: lib/AST/ASTContext.cpp

Commit af56a0108c1ed8b5adf88c99766067ea32df17c3 by spestov:
Sema: Add a couple of comments

edit: lib/Sema/TypeCheckProtocol.cpp

Commit 0c30979f477ce8de146960b95a9c5583117f2220 by spestov:
Resolve some crashers

add: validation-test/compiler_crashers_fixed/28342-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28383-swift-constraints-constraintgraphnode-getmembertype.swift
delete: validation-test/compiler_crashers/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28398-swift-archetypebuilder-getgenericsignature.swift
add: validation-test/compiler_crashers_fixed/28403-swift-genericsignature-getsubstitutionmap.swift
add: validation-test/compiler_crashers_fixed/28320-swift-archetypebuilder-enumeraterequirements.swift
delete: validation-test/compiler_crashers/28399-getpointerelementtype-is-not-storagetype.swift
add: validation-test/compiler_crashers_fixed/28399-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28403-swift-genericsignature-getsubstitutionmap.swift
delete: validation-test/compiler_crashers/28342-getpointerelementtype-is-not-storagetype.swift
delete: validation-test/compiler_crashers/28383-swift-constraints-constraintgraphnode-getmembertype.swift

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev