[Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

vedantk · April 3, 2017, 11:31pm

This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

···

On Apr 3, 2017, at 4:29 PM, no-reply@swift.org wrote:

[FAILURE] oss-swift-4.0-incremental-RA-osx [#71]

Build URL: https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/
Project: oss-swift-4.0-incremental-RA-osx
Date of build: Mon, 03 Apr 2017 15:39:24 -0700
Build duration: 49 min
Identified problems:

  • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
    • Indication 1
Tests:

Name: Swift(macosx-x86_64)
Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
  • Failed: Swift(macosx-x86_64).Python.gyb.swift
Name: Swift-Unit
Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)

Changes

  • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
Revert "[InlineCost] Fix codesize issue caused by r286814"

    • edit: test/Transforms/Inline/inline-fast-math-flags.ll
    • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
    • edit: test/Transforms/Inline/inline-cold.ll
    • edit: test/Transforms/Inline/inline-hot-callee.ll
    • edit: lib/Analysis/InlineCost.cpp
    • edit: test/Transforms/Inline/inline-cold-callee.ll
    • edit: test/Transforms/Inline/inline-optsize.ll
    • edit: test/Transforms/Inline/alloca-bonus.ll
    • edit: test/Transforms/Inline/ptr-diff.ll
    • edit: test/Transforms/Inline/inline-hot-callsite.ll
    • edit: test/Transforms/Inline/inline_unreachable-2.ll

  • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
Revert "[Inliner] Tweak inline threshold for code size regression"

    • edit: test/Transforms/Inline/ptr-diff.ll

  • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
Revert "[InlineCost] Remove skew when calculating call costs"

    • edit: test/Transforms/Inline/inline_unreachable-2.ll
    • edit: test/Transforms/Inline/ptr-diff.ll
    • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
    • edit: test/Transforms/Inline/inline-hot-callsite.ll
    • edit: test/Transforms/Inline/inline-optsize.ll
    • edit: test/Transforms/Inline/inline-cold.ll
    • edit: test/Transforms/Inline/alloca-bonus.ll
    • edit: lib/Analysis/InlineCost.cpp
    • edit: test/Transforms/Inline/inline-cold-callee.ll
    • edit: test/Transforms/Inline/inline-hot-callee.ll

  • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
Revert "[InlineCost] Reduce inline thresholds to compensate for cost

    • edit: test/Transforms/Inline/inline-fp.ll
    • edit: include/llvm/Analysis/InlineCost.h
    • edit: test/Transforms/Inline/ephemeral.ll

Hugh_Bellamy · April 4, 2017, 3:17am

This issue was fixed in Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8384 · apple/swift · GitHub, I think.

···

On 4 April 2017 at 06:31, Vedant Kumar <vsk@apple.com> wrote:

This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-reply@swift.org wrote:
>
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>
> Build URL: https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/
71/
> Project: oss-swift-4.0-incremental-RA-osx
> Date of build: Mon, 03 Apr 2017 15:39:24 -0700
> Build duration: 49 min
> Identified problems:
>
> • Regression test failed: This build failed because a regression
test in the test suite FAILed. Below is a list of all errors:
> • Indication 1
> Tests:
>
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>
> Changes
>
> • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
>
> • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> • edit: test/Transforms/Inline/
optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
>
> • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
>
> • edit: test/Transforms/Inline/ptr-diff.ll
>
> • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
>
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/
optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
>
> • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>
> • edit: test/Transforms/Inline/inline-fp.ll
> • edit: include/llvm/Analysis/InlineCost.h
> • edit: test/Transforms/Inline/ephemeral.ll

mishal_shah · April 4, 2017, 3:57am

We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid python lint failure.

Thanks,
Mishal Shah

···

On Apr 3, 2017, at 8:17 PM, Hugh Bellamy <hughbellars@gmail.com> wrote:

This issue was fixed in Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8384 · apple/swift · GitHub, I think.

On 4 April 2017 at 06:31, Vedant Kumar <vsk@apple.com <mailto:vsk@apple.com>> wrote:
This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:
>
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>
> Build URL: https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/
> Project: oss-swift-4.0-incremental-RA-osx
> Date of build: Mon, 03 Apr 2017 15:39:24 -0700
> Build duration: 49 min
> Identified problems:
>
> • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
> • Indication 1
> Tests:
>
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>
> Changes
>
> • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
>
> • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
>
> • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
>
> • edit: test/Transforms/Inline/ptr-diff.ll
>
> • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
>
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
>
> • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>
> • edit: test/Transforms/Inline/inline-fp.ll
> • edit: include/llvm/Analysis/InlineCost.h
> • edit: test/Transforms/Inline/ephemeral.ll

Hugh_Bellamy · April 4, 2017, 4:22am

Ah I see. I've sent in [swift-4.0-branch] Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8529 · apple/swift · GitHub

Thanks
Hugh

···

On 4 April 2017 at 10:57, mishal_shah <mishal_shah@apple.com> wrote:

We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid
python lint failure.

Thanks,
Mishal Shah

On Apr 3, 2017, at 8:17 PM, Hugh Bellamy <hughbellars@gmail.com> wrote:

This issue was fixed in Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8384 · apple/swift · GitHub, I think.

On 4 April 2017 at 06:31, Vedant Kumar <vsk@apple.com> wrote:

This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-reply@swift.org wrote:
>
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>
> Build URL: https://ci.swift.org/job/oss-s
wift-4.0-incremental-RA-osx/71/
> Project: oss-swift-4.0-incremental-RA-osx
> Date of build: Mon, 03 Apr 2017 15:39:24 -0700
> Build duration: 49 min
> Identified problems:
>
> • Regression test failed: This build failed because a regression
test in the test suite FAILed. Below is a list of all errors:
> • Indication 1
> Tests:
>
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>
> Changes
>
> • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant
Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
>
> • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> • edit: test/Transforms/Inline/optimiz
ation-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
>
> • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant
Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
>
> • edit: test/Transforms/Inline/ptr-diff.ll
>
> • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant
Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
>
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/optimiz
ation-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
>
> • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant
Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>
> • edit: test/Transforms/Inline/inline-fp.ll
> • edit: include/llvm/Analysis/InlineCost.h
> • edit: test/Transforms/Inline/ephemeral.ll

mishal_shah · April 4, 2017, 4:49am

Thanks!

···

On Apr 3, 2017, at 9:22 PM, Hugh Bellamy <hughbellars@gmail.com> wrote:

Ah I see. I've sent in [swift-4.0-branch] Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8529 · apple/swift · GitHub

Thanks
Hugh

On 4 April 2017 at 10:57, mishal_shah <mishal_shah@apple.com <mailto:mishal_shah@apple.com>> wrote:
We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid python lint failure.

Thanks,
Mishal Shah

On Apr 3, 2017, at 8:17 PM, Hugh Bellamy <hughbellars@gmail.com <mailto:hughbellars@gmail.com>> wrote:

This issue was fixed in Make sure to lint the interpreted, not compiled python file by hughbe · Pull Request #8384 · apple/swift · GitHub, I think.

On 4 April 2017 at 06:31, Vedant Kumar <vsk@apple.com <mailto:vsk@apple.com>> wrote:
This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-reply@swift.org <mailto:no-reply@swift.org> wrote:
>
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>
> Build URL: https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/
> Project: oss-swift-4.0-incremental-RA-osx
> Date of build: Mon, 03 Apr 2017 15:39:24 -0700
> Build duration: 49 min
> Identified problems:
>
> • Regression test failed: This build failed because a regression test in the test suite FAILed. Below is a list of all errors:
> • Indication 1
> Tests:
>
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>
> Changes
>
> • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
>
> • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
>
> • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
>
> • edit: test/Transforms/Inline/ptr-diff.ll
>
> • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
>
> • edit: test/Transforms/Inline/inline_unreachable-2.ll
> • edit: test/Transforms/Inline/ptr-diff.ll
> • edit: test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> • edit: test/Transforms/Inline/inline-hot-callsite.ll
> • edit: test/Transforms/Inline/inline-optsize.ll
> • edit: test/Transforms/Inline/inline-cold.ll
> • edit: test/Transforms/Inline/alloca-bonus.ll
> • edit: lib/Analysis/InlineCost.cpp
> • edit: test/Transforms/Inline/inline-cold-callee.ll
> • edit: test/Transforms/Inline/inline-hot-callee.ll
>
> • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>
> • edit: test/Transforms/Inline/inline-fp.ll
> • edit: include/llvm/Analysis/InlineCost.h
> • edit: test/Transforms/Inline/ephemeral.ll