I’ve finished the implementation of SE-0022, the #selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
Jordan
···
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
- Doug
···
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com <mailto:jordan_rose@apple.com>> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
It's a grammatical ambiguity we had overlooked. Add a space between the [ and # for now, and we'll see what we can do.
- Doug
···
Sent from my iPhone
On Feb 5, 2016, at 12:22 AM, Thomas Krajacic <thomas.krajacic@gmail.com> wrote:
Thanks for looking into it,
Thomas
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
On Feb 5, 2016, at 6:59 AM, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Feb 5, 2016, at 12:22 AM, Thomas Krajacic <thomas.krajacic@gmail.com <mailto:thomas.krajacic@gmail.com>> wrote:
- Doug
Thanks for looking into it,
Thomas
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com <mailto:jordan_rose@apple.com>> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
On Feb 5, 2016, at 5:15 PM, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Feb 5, 2016, at 6:59 AM, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Feb 5, 2016, at 12:22 AM, Thomas Krajacic <thomas.krajacic@gmail.com> wrote:
- Doug
Thanks for looking into it,
Thomas
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
This caused CI to fail because I pulled this in before pulling in the changes for #column, #line, etc. Reverted, and now tracked with a pull request:
···
On Feb 5, 2016, at 5:46 PM, Ted kremenek via swift-dev <swift-dev@swift.org> wrote:
On Feb 5, 2016, at 5:15 PM, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
On Feb 5, 2016, at 6:59 AM, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
On Feb 5, 2016, at 12:22 AM, Thomas Krajacic <thomas.krajacic@gmail.com <mailto:thomas.krajacic@gmail.com>> wrote:
- Doug
Thanks for looking into it,
Thomas
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com <mailto:jordan_rose@apple.com>> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.
...MainWindowController.swift:132:53: Expected '#]' at end of object literal expression
...MainWindowController.swift:132:53: Expected 'let' or 'var' in conditional; use '&&' to join boolean conditions
...MainWindowController.swift:132:133: Braced block of statements is an unused closure
...MainWindowController.swift:132:133: Expression resolves to an unused function
On 29 Jan 2016, at 01:17, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
On Jan 28, 2016, at 3:48 PM, Jordan Rose <jordan_rose@apple.com> wrote:
On Jan 28, 2016, at 12:12, Douglas Gregor via swift-dev <swift-dev@swift.org> wrote:
Hi all,
I’ve finished the implementation of SE-0022, the selector expression. Part of that proposal is the deprecation of the use of string literals to form Selectors, which is something we would like to do in Swift 2.2 (so that we can remove it outright in Swift 3).
However, it’s a non-trivial set of changes, and I’d like review of the corresponding commits before pulling it into the branch. The commits are:
I will say I'm not happy that we don't have any real code completion or IDE support. That seems important for putting it into a release.
The code completion we have is just filling in the “selector(@objc method)” after “#” in expression contexts, which is very weak. There are two things we want:
* Better code completion in general for compound names, e.g., after “UIView.”, we probably want to see (or have some easy way to get to) the compound name “insertSubview(_:aboveSubview:)”. That’s really SE-0021 not having good code completion.
* Within selector(…), we want to see compound names as the primary completions after a type name, and limit to @objc methods.