Source compatibility failures on swift-4.2-branch

rudkx · 2018-03-25T15:04:10.602Z

I noticed that we had several failures in the source compatibility suite when using compilers built from swift-4.2-branch. It looks like most are cases where we just didn't update projects.json to XFAIL things that we already knew were failing with master.

However, there are two failures that are not already XFAILed on master, and I am wondering if anyone has any insight into them. Perhaps a couple fixes need to be cherry-picked to swift-4.2-branch?

CoreStore: unsupported relocation with subtraction expression, symbol '_$S9CoreStore5WhereVMn' can not be undefined in a subtraction expression

RxDataSources: <unknown>:0: note: symbol '_$S7RxSwift27RecursiveImmediateSchedulerCMn' can not be undefined in a subtraction expression

Andrew_Trick · 2018-03-25T21:11:25.110Z

Hi Mark,

Sorry I didn't see this sooner. It's probably this bug. I think there was a PR on master that fixed it:

github.com/apple/swift

[SR-7181] Swift CI: Swift Source Compatibility Suite (master)

opened 01:07AM - 13 Mar 18 UTC

closed 04:28PM - 14 Mar 18 UTC

atrick

bug Compiler

| | | |------------------|-----------------|… |Previous ID | SR-7181 | |Radar | rdar://38397927 | |Original Reporter | @atrick | |Type | Bug | |Status | Closed | |Resolution | Done | Attachment: [Download](https://user-images.githubusercontent.com/2727770/164962618-d8c8afbc-90ad-4677-8a92-17e02aa0813c.gz) <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Compiler | |Labels | Bug | |Assignee | @atrick | |Priority | Medium | md5: e6fc393ed55802d05ac04a2acf7eda80 </details> **Issue Description:** Jenkins URL: <https://ci.swift.org/job/swift-master-source-compat-suite/1421/> FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-Example_generic-platform-iOS.log FAIL_RxDataSources-Pods-Pods.xcodeproj_3.0_BuildXcodeProjectTarget_Pods-RxDataSources_generic-platform-iOS.log error: fatal error encountered during compilation; please file a bug report with your project and the crash log \<unknown\>:0: note: symbol '\_$S7RxSwift21AnyRecursiveSchedulerCMn' can not be undefined in a subtraction expression 1. IRGen: Set IGM.CurSourceFile while emitting SILFunctions. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 2. Runtime: Use type context descriptors to unique foreign metadata. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 3. Runtime: Prefab metadata records for Any and AnyObject. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 4. IRGen: Use known value witness tables for common type layouts. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 5. Runtime: Make generic parameter counts in context descriptors 16-bit. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 6. IRGen: Make outlined enum copy/destroy lazier and better mangled. ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 7. \[silgen\] Change SwitchEnumBuilder to invalidate the insertion point ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 8. \[Parse\] getLineNumber before parsing the closure (#15178) ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail)) 9. \[Lexer\] Remove dead code (#15179) ([detail](https://ci.swift.org/job/swift-master-source-compat-suite/1421/changes#detail))