SIL experts: what does it mean that we're generating new target-features in a test?

I'm seeing the following failure after making a change to the standard library. What should I do? Is it meaningful or should I just update the expectation of the test?

{code:none}
/Users/dave/src/s/swift/test/IRGen/ordering_x86.sil:44:12: error: expected string not found in input
// X86_64: #0 = {{.*}}"target-features"="+cx16,+fxsr,+mmx,+sse,+sse2,+sse3,+ssse3,+x87"
^
:20:31: note: scanning from here
define swiftcc void @baz() #0 {
^
:28:99: note: possible intended match here
attributes #0 = { "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "target-cpu"="core2" "target-features"="+cx16,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+ssse3,+x87" }
^
{code}

This is LLVM IR output, and it looks to me like perhaps you've updated your clang directory but not merged in the latest changes on the Swift master branch.

This was fixed a few weeks ago on master: https://github.com/apple/swift/pull/16681

1 Like

Yep, my bad; thanks.