Should static be a builtin and not keyword?

masters3d · 2018-03-19T18:01:28.554Z

Hi,

I was working with source kit and I was very surprised to find out that static is a "source.lang.swift.syntaxtype.keyword". Is this necessary? From the surface it looks like it ended up a keyword by accident. Split 'type' keyword into 'static' and 'class' · apple/swift@571c9b3 · GitHub

github.com/apple/swift

[SR-4834] Static should be attribute.builtin

opened 06:43AM - 09 May 17 UTC

closed 05:21PM - 11 May 17 UTC

masters3d

bug

| | | |------------------|-----------------|… |Previous ID | SR-4834 | |Radar | None | |Original Reporter | @masters3d | |Type | Bug | |Status | Closed | |Resolution | Done | <details> <summary>Environment</summary> Welcome to Apple Swift version 3.1 (swiftlang-802.0.51 clang-802.0.41). Type :help for assistance. </details> <details> <summary>Additional Detail from JIRA</summary> | | | |------------------|-----------------| |Votes | 0 | |Component/s | Source Tooling | |Labels | Bug | |Assignee | None | |Priority | Medium | md5: 8727462403ffc22f9f6eeaa352343c60 </details> **Issue Description:** AFAICT, All modifiers are represented in Sourcekit as `source.lang.swift.syntaxtype.attribute.builtin` except static. static comes up as `source.lang.swift.syntaxtype.keyword` This seems to be a bug since `static` seems to be just another modifier in this list. <https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/Declarations.html#//apple_ref/swift/grammar/declaration-modifiers>

I was working on swiftlint rule https://github.com/realm/SwiftLint/pull/1501 but static is getting hard to parse with sourcekit (even on 4.1)

Can static be reported as an attribute even though it is implemented as a keyword? Or does this change require changing the parse/compiler?
Can contextual keywords be reported as their actual context and not their intrinsic kind?
For example: class is a keyword, but sometimes it is used as a modifier. Can it be reported as a modifier when it is functioning as a modifier?

Thanks,
Cheyo

masters3d · 2018-05-02T17:38:15.415Z

Related bug: [SR-7252] SourceKit doesn't recognise `static` and `class` as declaration attribute · Issue #49800 · apple/swift · GitHub