SE-0354 (Second Review): Regex Literals

[tim1724 (Tim Buchheim)]

@stackotter

Someone may have brought this up already. But would the new parsing rules still misparse someFunction(/MyEnum.case1, /MyEnum.case2) ?

Yes. I think it would because it matches all four of these conditions:

• / appears in an expression position.
• There is a closing / on the same line.
• The first character following the opening / is not space or tab.
• There are no unbalanced ) characters between the two / characters.

The least intrusive fix is probably to put parentheses around the first expression:

someFunction((/MyEnum.case1), /MyEnum.case2)

This causes the potential regex literal to fail the "unbalanced )" condition, thus causing it not to be parsed as a regex.

Another choice would be to split the arguments across multiple lines, to make it fail the "closing / on the same line" condition:

someFunction(
    /MyEnum.case1,
    /MyEnum.case2
)