Review Manager Update
Thanks to everyone for their feedback so far.
The core team has discussed the review thread and concluded that the proposal should be accepted broadly as proposed:
-
#filewill be altered to only report the module and filename -
#filePathwill be introduced to replicate the previous full file+path for use cases that relied on the path previously. - While the team acknowledges that this does require some existing workflows to adapt to the new scheme, the binary size and privacy concerns over implicitly embedding the full path were significant enough to warrant this.
One area that the team felt still required addressing was the question of the format for the module+filename combination. The proposal explicitly left that unspecified, leaving open the possibility of changing the format at a later date. The core team prefers an approach of determining the format explicitly, allowing future tooling to rely on it to separate out the module name and file name.
As a result, the core team have asked the proposal author to amend the proposal to make the format of #file explicit, and a re-review focused specifically on this revision will be conducted.
Thanks to everyone for participating in this review.
Ben Cohen
Review Manager