SE-0274: Concise Magic File Names

[AlexanderM (Alexander Momchilov)]

+1 on the motivations, but -1 on the execution.

I hold the same critique as I did in the pitch thread:

@AlexanderM

I'm not a fan of the primitive obsession here. Why "file_path (module_name)"? Why not a SwiftFileDescriptor struct, with fields like:

• url: URL (relative to some portable base location),
• name: String,
• moduleName: String,
• lineNumber: Int,

and perhaps a custom implementation of CustomStringConvertible that glues them together with spaces and parentheses and what not.

I say this because given the current design, I'm fairly certain that most call sites will be constantly calling components(separatedBy: " ").

I would much prefer this to be implemented as a struct, so that we have a single #context (or whatever) for all your context checking needs, rather than creating a bunch of separate # identifiers.