[SE-0046] Implemented consistent function labels

Daniel_Eggert · 2016-04-07T17:15:52.000Z

With this being merged

https://github.com/apple/swift-corelibs-foundation/pull/305

where do I find a compiler that works? Everything stopped working for me, because utils/update-checkout currently checks out something that can't build a toolchain.

Does https://ci.swift.org/ have daily Toolchains?

/Daniel

ddunbar · 2016-04-07T23:44:39.000Z

With this being merged

[SE-0046] Implemented consistent function labels by harlanhaskins · Pull Request #305 · apple/swift-corelibs-foundation · GitHub

where do I find a compiler that works? Everything stopped working for me, because utils/update-checkout currently checks out something that can't build a toolchain.

Yes, this unfortunately just a reality of the language changing on trunk and the current development model -- if you want to track trunk you at times will need to build from trunk and not a snapshot.

Does https://ci.swift.org/ have daily Toolchains?

No, not currently.

- Daniel

···

On Apr 7, 2016, at 10:15 AM, Daniel Eggert via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

/Daniel

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Daniel_Eggert · 2016-04-08T10:12:04.000Z

I was trying to build off master, but it was failing for me. Works now. Sorry for the noise.

/Daniel

···

On 08 Apr 2016, at 01:44, Daniel Dunbar <daniel_dunbar@apple.com> wrote:

On Apr 7, 2016, at 10:15 AM, Daniel Eggert via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

With this being merged

[SE-0046] Implemented consistent function labels by harlanhaskins · Pull Request #305 · apple/swift-corelibs-foundation · GitHub

where do I find a compiler that works? Everything stopped working for me, because utils/update-checkout currently checks out something that can't build a toolchain.

Yes, this unfortunately just a reality of the language changing on trunk and the current development model -- if you want to track trunk you at times will need to build from trunk and not a snapshot.

Tony_Parker · 2016-04-08T14:52:31.000Z

These are turbulent times for syntax in Swift. :)

Pretty soon now we're also going to have to deal with the swift renaming rules as applied to all functions in corelibs-foundation.

- Tony

···

On Apr 8, 2016, at 3:12 AM, Daniel Eggert via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

On 08 Apr 2016, at 01:44, Daniel Dunbar <daniel_dunbar@apple.com> wrote:

On Apr 7, 2016, at 10:15 AM, Daniel Eggert via swift-corelibs-dev <swift-corelibs-dev@swift.org> wrote:

With this being merged

[SE-0046] Implemented consistent function labels by harlanhaskins · Pull Request #305 · apple/swift-corelibs-foundation · GitHub

where do I find a compiler that works? Everything stopped working for me, because utils/update-checkout currently checks out something that can't build a toolchain.

Yes, this unfortunately just a reality of the language changing on trunk and the current development model -- if you want to track trunk you at times will need to build from trunk and not a snapshot.

I was trying to build off master, but it was failing for me. Works now. Sorry for the noise.

/Daniel

_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Daniel_Eggert · 2016-04-08T16:58:56.000Z

I know. Trying to rebase my 5k+ line changes against master is turning into a full day undertaking at this point.

I'm currently seeing thousands of these on master:

.../Swift/swift-corelibs-foundation/Foundation/NSArray.swift:257:31: Extraneous '_' in parameter: 'anObject' has no keyword argument name

Is someone going to clean that up "soon"? I lost track of what we're trying to go for with the naming changes.

/Daniel

···

On 08 Apr 2016, at 16:52, Tony Parker <anthony.parker@apple.com> wrote:

These are turbulent times for syntax in Swift. :)

Pretty soon now we're also going to have to deal with the swift renaming rules as applied to all functions in corelibs-foundation.

- Tony

Tony_Parker · 2016-04-08T17:12:17.000Z

That looks like you might be using the older compiler. The newest (at least on master) should have the change applied for :

github.com

apple/swift-evolution/blob/main/proposals/0046-first-label.md

# Establish consistent label behavior across all parameters including first labels

* Proposal: [SE-0046](0046-first-label.md)
* Authors: [Jake Carter](https://github.com/JakeCarter), [Erica Sadun](http://github.com/erica)
* Review Manager: [Chris Lattner](https://github.com/lattner)
* Status: **Implemented (Swift 3)**
* Decision Notes: [Rationale](https://forums.swift.org/t/accepted-se-0046-establish-consistent-label-behavior-across-all-parameters-including-first-labels/1834)
* Bug: [SR-961](https://bugs.swift.org/browse/SR-961)

## Introduction
We propose to normalize the first parameter declaration in methods 
and functions. In this proposal, first parameter declarations will match
the existing behavior of the second and later parameters.
All parameters, regardless of position, will behave
uniformly. This will create a simple, consistent approach to parameter
declaration throughout the Swift programming language and bring 
method and function declarations in-sync with initializers, which
already use this standard.

*Discussion took place on the Swift Evolution mailing list in the [Make the first parameter in a function declaration follow the same rules as the others](https://forums.swift.org/t/pitch-make-the-first-parameter-in-a-function-declaration-follow-the-same-rules-as-the-others/1734) thread.*

This file has been truncated. show original

Since we are part of the Swift CI system, we have to keep master swift-corelibs-foundation up to date with the master of the Swift compiler.

- Tony

···

On Apr 8, 2016, at 9:58 AM, Daniel Eggert <danieleggert@me.com> wrote:

On 08 Apr 2016, at 16:52, Tony Parker <anthony.parker@apple.com> wrote:

These are turbulent times for syntax in Swift. :)

Pretty soon now we're also going to have to deal with the swift renaming rules as applied to all functions in corelibs-foundation.

- Tony

I know. Trying to rebase my 5k+ line changes against master is turning into a full day undertaking at this point.

I'm currently seeing thousands of these on master:

.../Swift/swift-corelibs-foundation/Foundation/NSArray.swift:257:31: Extraneous '_' in parameter: 'anObject' has no keyword argument name

Is someone going to clean that up "soon"? I lost track of what we're trying to go for with the naming changes.

/Daniel