[RFC] Requiring CMake 3.4.3 by Prerequisite.


(Michael Gottesman) #1

For a long time, we have been using CMake 2.8.*. This is an RFC to make it a pre-requisite to have cmake 3.4.3 matching LLVM.

The reason to do this is:

1. It will make it easier to cherry-pick upstream llvm changes that may require CMake 3.4.3 features into Swift's cmake system.
2. It allows us to use LLVMConfig.cmake and ClangConfig.cmake to import the proper dependencies.

We especially want number 2 since it nips linker dependency issues on Linux that come up every couple of months in various forms.

If you have any questions/concerns/etc, please feel free to respond publicly on this thread or privately by sending me an offlist email.

Assuming that there is no further discussion, I would like to give a notice about the update sometime this weekend (flipping the switch next week). So please give me your feedback in a reasonable amount of time. = ).

Thanks,
Michael


(Joe Bell) #2

Michael, as I mentioned earlier I upgraded my systems to 3.4.3 and resumed
building Swift. Regarding flipping the switch, I'm assuming you mean
replacing

cmake_minimum_required(VERSION 2.8.12)

with 3.4.3 in all of the various CMakeLists.txt files?

Joe

···

On Wed, Jun 29, 2016 at 12:13 PM, Michael Gottesman via swift-dev < swift-dev@swift.org> wrote:

For a long time, we have been using CMake 2.8.*. This is an RFC to make it
a pre-requisite to have cmake 3.4.3 matching LLVM.

The reason to do this is:

1. It will make it easier to cherry-pick upstream llvm changes that may
require CMake 3.4.3 features into Swift's cmake system.
2. It allows us to use LLVMConfig.cmake and ClangConfig.cmake to import
the proper dependencies.

We especially want number 2 since it nips linker dependency issues on
Linux that come up every couple of months in various forms.

If you have any questions/concerns/etc, please feel free to respond
publicly on this thread or privately by sending me an offlist email.

Assuming that there is no further discussion, I would like to give a
notice about the update sometime this weekend (flipping the switch next
week). So please give me your feedback in a reasonable amount of time. = ).

Thanks,
Michael
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

--
Joseph Bell
http://dev.iachieved.it/iachievedit/
@iachievedit


(Michael Gottesman) #3

Yes.

···

On Jun 30, 2016, at 2:47 PM, Joseph Bell <joe@iachieved.it> wrote:

Michael, as I mentioned earlier I upgraded my systems to 3.4.3 and resumed building Swift. Regarding flipping the switch, I'm assuming you mean replacing

cmake_minimum_required(VERSION 2.8.12)

with 3.4.3 in all of the various CMakeLists.txt files?

Joe

On Wed, Jun 29, 2016 at 12:13 PM, Michael Gottesman via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
For a long time, we have been using CMake 2.8.*. This is an RFC to make it a pre-requisite to have cmake 3.4.3 matching LLVM.

The reason to do this is:

1. It will make it easier to cherry-pick upstream llvm changes that may require CMake 3.4.3 features into Swift's cmake system.
2. It allows us to use LLVMConfig.cmake and ClangConfig.cmake to import the proper dependencies.

We especially want number 2 since it nips linker dependency issues on Linux that come up every couple of months in various forms.

If you have any questions/concerns/etc, please feel free to respond publicly on this thread or privately by sending me an offlist email.

Assuming that there is no further discussion, I would like to give a notice about the update sometime this weekend (flipping the switch next week). So please give me your feedback in a reasonable amount of time. = ).

Thanks,
Michael
_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

--
Joseph Bell
http://dev.iachieved.it/iachievedit/
@iachievedit


(Michael Gottesman) #4

I am now flipping the switch to require the upgraded cmake.

Michael

···

On Jun 30, 2016, at 3:24 PM, Michael Gottesman via swift-dev <swift-dev@swift.org> wrote:

Yes.

On Jun 30, 2016, at 2:47 PM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:

Michael, as I mentioned earlier I upgraded my systems to 3.4.3 and resumed building Swift. Regarding flipping the switch, I'm assuming you mean replacing

cmake_minimum_required(VERSION 2.8.12)

with 3.4.3 in all of the various CMakeLists.txt files?

Joe

On Wed, Jun 29, 2016 at 12:13 PM, Michael Gottesman via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
For a long time, we have been using CMake 2.8.*. This is an RFC to make it a pre-requisite to have cmake 3.4.3 matching LLVM.

The reason to do this is:

1. It will make it easier to cherry-pick upstream llvm changes that may require CMake 3.4.3 features into Swift's cmake system.
2. It allows us to use LLVMConfig.cmake and ClangConfig.cmake to import the proper dependencies.

We especially want number 2 since it nips linker dependency issues on Linux that come up every couple of months in various forms.

If you have any questions/concerns/etc, please feel free to respond publicly on this thread or privately by sending me an offlist email.

Assuming that there is no further discussion, I would like to give a notice about the update sometime this weekend (flipping the switch next week). So please give me your feedback in a reasonable amount of time. = ).

Thanks,
Michael
_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

--
Joseph Bell
http://dev.iachieved.it/iachievedit/
@iachievedit

_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev


(Michael Gottesman) #5

To git@github.com:apple/swift.git
   ffcafd7..4598b9e master -> master

···

On Jul 2, 2016, at 10:01 PM, Michael Gottesman <mgottesman@apple.com> wrote:

I am now flipping the switch to require the upgraded cmake.

Michael

On Jun 30, 2016, at 3:24 PM, Michael Gottesman via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:

Yes.

On Jun 30, 2016, at 2:47 PM, Joseph Bell <joe@iachieved.it <mailto:joe@iachieved.it>> wrote:

Michael, as I mentioned earlier I upgraded my systems to 3.4.3 and resumed building Swift. Regarding flipping the switch, I'm assuming you mean replacing

cmake_minimum_required(VERSION 2.8.12)

with 3.4.3 in all of the various CMakeLists.txt files?

Joe

On Wed, Jun 29, 2016 at 12:13 PM, Michael Gottesman via swift-dev <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote:
For a long time, we have been using CMake 2.8.*. This is an RFC to make it a pre-requisite to have cmake 3.4.3 matching LLVM.

The reason to do this is:

1. It will make it easier to cherry-pick upstream llvm changes that may require CMake 3.4.3 features into Swift's cmake system.
2. It allows us to use LLVMConfig.cmake and ClangConfig.cmake to import the proper dependencies.

We especially want number 2 since it nips linker dependency issues on Linux that come up every couple of months in various forms.

If you have any questions/concerns/etc, please feel free to respond publicly on this thread or privately by sending me an offlist email.

Assuming that there is no further discussion, I would like to give a notice about the update sometime this weekend (flipping the switch next week). So please give me your feedback in a reasonable amount of time. = ).

Thanks,
Michael
_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev

--
Joseph Bell
http://dev.iachieved.it/iachievedit/
@iachievedit

_______________________________________________
swift-dev mailing list
swift-dev@swift.org <mailto:swift-dev@swift.org>
https://lists.swift.org/mailman/listinfo/swift-dev